From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F30A6C433E2 for ; Tue, 15 Sep 2020 22:13:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B6B072080C for ; Tue, 15 Sep 2020 22:13:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600208018; bh=4Mrz8W4yVHSrjm/2NolY9eyeH8z6bCUGwiVV7IwY/mc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=OqkR3i5yzm/fTkwbjpVXPjCboLYbZGwXMh0onQmaJJWcgaLEt3pz1YJF+cHeqyPv3 FZh7H7qC0IHVjewT1Sv/kGrEa++ftWTnaF2gc3i3N0v3r4/FPlUxfUglPTT5sQqqBv axnlZSiUIArp9Nr0CP9EWnxOnCaBbB/u/u5Pu/7c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727812AbgIOWNe (ORCPT ); Tue, 15 Sep 2020 18:13:34 -0400 Received: from mail-il1-f196.google.com ([209.85.166.196]:39134 "EHLO mail-il1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727620AbgIOQjA (ORCPT ); Tue, 15 Sep 2020 12:39:00 -0400 Received: by mail-il1-f196.google.com with SMTP id s88so3621978ilb.6; Tue, 15 Sep 2020 09:38:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fQjq4psADqOTnHj/5X1me47R++0Wgzo4u+nIQzoreps=; b=Sfo3JtsgiNdG5PPVa8FD/kozMhckR1uaP64Uz22YZhAq/5arVVSQodJuwgBo6RpdlN Z3CD6i/BmLIbCqTrOF80KjoEuF5OTTn4Oxx50F5GPP1H6D/9oDmW+BCnsI8m4JSnEMr+ bcyGOZkBB+VZgL6LvpUAlAeEmXnh/d8YMCJT6A9lhN43a81ffrWep8uSJO7TLTDlanis p2mU6zOOS/q0q7Js6b10gJglXiMxYGs94VwaHadainnql8j4lUpCCWQzLSwz9tRFF5um SkZ05777oNU82U4OeKFjxkihWOJEKKIv+3YDIJcSBv1vAnAQaBYWC0ncFFU3ZLfd8FjH yESg== X-Gm-Message-State: AOAM53186k5WOOMn5NJVd2NQ+IxH70Uiojbqb0fBu05fF5C9tjQdKOqQ 6s+bG0hRwU0OjnE/ZAH5Cg== X-Google-Smtp-Source: ABdhPJyc/WK+I+3WGB3O4e0d/McGvpjNZjWv2eTGNesdR8lUL+lh2ZG1y+ZQBTzSh6qPvBnsqH/w/w== X-Received: by 2002:a92:6f0a:: with SMTP id k10mr15682854ilc.5.1600187897117; Tue, 15 Sep 2020 09:38:17 -0700 (PDT) Received: from xps15 ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id v20sm9059138ile.42.2020.09.15.09.38.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 09:38:16 -0700 (PDT) Received: (nullmailer pid 2088114 invoked by uid 1000); Tue, 15 Sep 2020 16:38:14 -0000 Date: Tue, 15 Sep 2020 10:38:14 -0600 From: Rob Herring To: Mauro Carvalho Chehab Cc: Felipe Balbi , linuxarm@huawei.com, mauro.chehab@huawei.com, John Stultz , Manivannan Sadhasivam , Greg Kroah-Hartman , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] dt-bindings: document a new quirk for dwc3 Message-ID: <20200915163814.GA2084568@bogus> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Sep 08, 2020 at 09:20:57AM +0200, Mauro Carvalho Chehab wrote: > At Hikey 970, setting the SPLIT disable at the General > User Register 3 is required. > > Without that, the URBs generated by the usbhid driver > return -EPROTO errors. That causes the code at > hid-core.c to call hid_io_error(), which schedules > a reset_work, causing a call to hid_reset(). > > In turn, the code there will call: > > usb_queue_reset_device(usbhid->intf); > > The net result is that the input devices won't work, and > will be reset on every 0.5 seconds: > > [ 33.122384] hub 1-1:1.0: state 7 ports 4 chg 0000 evt 0002 > [ 33.378220] usb 1-1.1: reset low-speed USB device number 3 using xhci-hcd > [ 33.698394] hub 1-1:1.0: state 7 ports 4 chg 0000 evt 0000 > [ 34.882365] hub 1-1:1.0: state 7 ports 4 chg 0000 evt 0002 > [ 35.138217] usb 1-1.1: reset low-speed USB device number 3 using xhci-hcd > [ 35.458617] hub 1-1:1.0: state 7 ports 4 chg 0000 evt 0000 > [ 36.642392] hub 1-1:1.0: state 7 ports 4 chg 0000 evt 0002 > [ 36.898207] usb 1-1.1: reset low-speed USB device number 3 using xhci-hcd > [ 37.218598] hub 1-1:1.0: state 7 ports 4 chg 0000 evt 0000 > [ 38.402368] hub 1-1:1.0: state 7 ports 4 chg 0000 evt 0002 > [ 38.658174] usb 1-1.1: reset low-speed USB device number 3 using xhci-hcd > [ 38.978594] hub 1-1:1.0: state 7 ports 4 chg 0000 evt 0000 > [ 40.162361] hub 1-1:1.0: state 7 ports 4 chg 0000 evt 0002 > [ 40.418148] usb 1-1.1: reset low-speed USB device number 3 using xhci-hcd > ... > [ 397.698132] usb 1-1.1: reset low-speed USB device number 3 using xhci-hcd > > Signed-off-by: Mauro Carvalho Chehab > --- > Documentation/devicetree/bindings/usb/dwc3.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt > index d03edf9d3935..1aae2b6160c1 100644 > --- a/Documentation/devicetree/bindings/usb/dwc3.txt > +++ b/Documentation/devicetree/bindings/usb/dwc3.txt > @@ -78,6 +78,9 @@ Optional properties: > park mode are disabled. > - snps,dis_metastability_quirk: when set, disable metastability workaround. > CAUTION: use only if you are absolutely sure of it. > + - snps,dis-split-quirk: when set, change the way URBs are handled by the > + driver. Needed to avoid -EPROTO errors with usbhid > + on some devices (Hikey 970). Can't this be implied by the compatible string? Yes we have quirk properties already, but the problem with them is you can't address them without a DT change. Rob