From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-power@fi.rohmeurope.com, Rob Herring <robh+dt@kernel.org>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Robert Jones <rjones@gateworks.com>,
devicetree@vger.kernel.org, Tim Harvey <tharvey@gateworks.com>,
linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH] dt-bindings: mfd: Correct interrupt flags in examples
Date: Tue, 15 Sep 2020 10:53:46 -0600 [thread overview]
Message-ID: <20200915165346.GA2112678@bogus> (raw)
In-Reply-To: <20200908145900.4423-1-krzk@kernel.org>
On Tue, 08 Sep 2020 16:59:00 +0200, Krzysztof Kozlowski wrote:
> GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
> These are simple defines so they could be used in DTS but they will not
> have the same meaning:
> 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
> 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING
>
> Correct the interrupt flags, assuming the author of the code wanted some
> logical behavior behind the name "ACTIVE_xxx", this is:
> ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> Documentation/devicetree/bindings/mfd/act8945a.txt | 2 +-
> Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml | 3 ++-
> Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt | 2 +-
> 3 files changed, 4 insertions(+), 3 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
prev parent reply other threads:[~2020-09-15 18:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 14:59 [PATCH] dt-bindings: mfd: Correct interrupt flags in examples Krzysztof Kozlowski
2020-09-09 6:29 ` Lee Jones
2020-09-09 6:30 ` Vaittinen, Matti
2020-09-09 8:17 ` krzk
2020-09-09 8:57 ` Vaittinen, Matti
2020-09-09 9:20 ` krzk
2020-09-09 10:19 ` Vaittinen, Matti
2020-09-09 15:22 ` Tim Harvey
2020-09-15 16:53 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915165346.GA2112678@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-power@fi.rohmeurope.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=rjones@gateworks.com \
--cc=robh+dt@kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).