From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89973C433E2 for ; Tue, 15 Sep 2020 17:28:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3CD1820936 for ; Tue, 15 Sep 2020 17:28:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600190900; bh=4u1mqOcesqjEmTr8oDpFU6Z/Y6vn1eQRNk+fs1zlmUc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=NASNfmClDKDub/aVxGAMo76fGYNMJzncemJvzD1S4/ZxcYXFeEg3z0shdTqpHufC4 Hl0PyQVFG0mFn+zfNNdwYy+XjFxDyOQfjOP2yU2wA0MEecgxutPnsfcVmqj5KL0CAt NCwtNxZIVttrMcBld3XvOwNDSyqNdl1jWEjGLgYc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727905AbgIOR1x (ORCPT ); Tue, 15 Sep 2020 13:27:53 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:40591 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727807AbgIOR1Z (ORCPT ); Tue, 15 Sep 2020 13:27:25 -0400 Received: by mail-pg1-f196.google.com with SMTP id j34so2334992pgi.7; Tue, 15 Sep 2020 10:27:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bETQrHlgY+giuYgPl/jo3S5uao6J8l5uzCi3TzZPVZA=; b=i3WxXzjABnhsIcJFfeqtuFUa+fPmwUPLSxSXAth3kDqbm20WFBaDiHT2WmhXB3pikZ iVqpRwveiWeVNBL6ReU7vAOy9RcRGW48YCLpPfIT9xMd3dkvR8EC+klAKgCOncmgSy2H YAUGYVZv7NzgeQBofjudKu6b/6vy5F71lvdjij7lqbHkZl3MGwJvrAWs2nOIrJeXtGBC 8ff5/S56rKm4Wo1xT4pc/7RWabdSZghG2O7YYc0OePv7CZmEACUBjZgD+j4AupohjLxE 1yeqkmhTEy2VamuHa64c0zcywuUCHLmU/+H54bTgBZB5OoYf7VQBN/3MpOUb58UwnZhc UlBg== X-Gm-Message-State: AOAM533ZQ6jBDoD2fXsQJbl8sENvizAN0v3VPiVad9OryPOzG90msd0i NhdsJ8PwjCYe39P+XDEroa7JueLEM9OVlak= X-Google-Smtp-Source: ABdhPJzTpqhRYoX0orE95dExGzGsMu6Z+Szq5lkJDUMDgJUa0R1o5rp/mlwEDwerBCCvE+fbcd+OCA== X-Received: by 2002:a92:db42:: with SMTP id w2mr4824823ilq.247.1600188927677; Tue, 15 Sep 2020 09:55:27 -0700 (PDT) Received: from xps15 ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id m15sm8983132ild.8.2020.09.15.09.55.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 09:55:27 -0700 (PDT) Received: (nullmailer pid 2115706 invoked by uid 1000); Tue, 15 Sep 2020 16:55:24 -0000 Date: Tue, 15 Sep 2020 10:55:24 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: Rob Herring , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Liam Girdwood , Mark Brown Subject: Re: [PATCH] ASoC: dt-bindings: Correct interrupt flags in examples Message-ID: <20200915165524.GA2115652@bogus> References: <20200908145954.4629-1-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200908145954.4629-1-krzk@kernel.org> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 08 Sep 2020 16:59:54 +0200, Krzysztof Kozlowski wrote: > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. > These are simple defines so they could be used in DTS but they will not > have the same meaning: > 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE > 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING > > Correct the interrupt flags, assuming the author of the code wanted some > logical behavior behind the name "ACTIVE_xxx", this is: > ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH > > Signed-off-by: Krzysztof Kozlowski > --- > Documentation/devicetree/bindings/sound/max98090.txt | 2 +- > Documentation/devicetree/bindings/sound/rt5640.txt | 2 +- > Documentation/devicetree/bindings/sound/rt5659.txt | 2 +- > Documentation/devicetree/bindings/sound/rt5665.txt | 2 +- > Documentation/devicetree/bindings/sound/rt5668.txt | 2 +- > Documentation/devicetree/bindings/sound/rt5677.txt | 2 +- > Documentation/devicetree/bindings/sound/rt5682.txt | 2 +- > 7 files changed, 7 insertions(+), 7 deletions(-) > Acked-by: Rob Herring