* [PATCH v5 1/3] dt-bindings: media: ov772x: Convert to json-schema
2020-09-10 16:20 [PATCH v5 0/3] dt-bindings: media: ov772x: Convert to json-schema Jacopo Mondi
@ 2020-09-10 16:20 ` Jacopo Mondi
2020-09-15 20:10 ` Rob Herring
2020-09-10 16:20 ` [PATCH v5 2/3] dt-bindings: media: ov772x: Make bus-type mandatory Jacopo Mondi
2020-09-10 16:20 ` [PATCH v5 3/3] dt-bindings: media: ov772x: Document endpoint props Jacopo Mondi
2 siblings, 1 reply; 11+ messages in thread
From: Jacopo Mondi @ 2020-09-10 16:20 UTC (permalink / raw)
To: robh+dt, devicetree, linux-media, Lad, Prabhakar
Cc: Jacopo Mondi, mchehab, sakari.ailus, hverkuil-cisco,
laurent.pinchart, linux-renesas-soc, Lad Prabhakar
Convert the ov772x binding document to json-schema and update
the MAINTAINERS file accordingly.
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
.../devicetree/bindings/media/i2c/ov772x.txt | 40 ----------
.../bindings/media/i2c/ovti,ov772x.yaml | 74 +++++++++++++++++++
MAINTAINERS | 2 +-
3 files changed, 75 insertions(+), 41 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/i2c/ov772x.txt
create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
diff --git a/Documentation/devicetree/bindings/media/i2c/ov772x.txt b/Documentation/devicetree/bindings/media/i2c/ov772x.txt
deleted file mode 100644
index 0b3ede5b8e6a..000000000000
--- a/Documentation/devicetree/bindings/media/i2c/ov772x.txt
+++ /dev/null
@@ -1,40 +0,0 @@
-* Omnivision OV7720/OV7725 CMOS sensor
-
-The Omnivision OV7720/OV7725 sensor supports multiple resolutions output,
-such as VGA, QVGA, and any size scaling down from CIF to 40x30. It also can
-support the YUV422, RGB565/555/444, GRB422 or raw RGB output formats.
-
-Required Properties:
-- compatible: shall be one of
- "ovti,ov7720"
- "ovti,ov7725"
-- clocks: reference to the xclk input clock.
-
-Optional Properties:
-- reset-gpios: reference to the GPIO connected to the RSTB pin which is
- active low, if any.
-- powerdown-gpios: reference to the GPIO connected to the PWDN pin which is
- active high, if any.
-
-The device node shall contain one 'port' child node with one child 'endpoint'
-subnode for its digital output video port, in accordance with the video
-interface bindings defined in Documentation/devicetree/bindings/media/
-video-interfaces.txt.
-
-Example:
-
-&i2c0 {
- ov772x: camera@21 {
- compatible = "ovti,ov7725";
- reg = <0x21>;
- reset-gpios = <&axi_gpio_0 0 GPIO_ACTIVE_LOW>;
- powerdown-gpios = <&axi_gpio_0 1 GPIO_ACTIVE_LOW>;
- clocks = <&xclk>;
-
- port {
- ov772x_0: endpoint {
- remote-endpoint = <&vcap1_in0>;
- };
- };
- };
-};
diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
new file mode 100644
index 000000000000..e7e2d31fcc23
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
@@ -0,0 +1,74 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/ovti,ov772x.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Omnivision OV7720/OV7725 CMOS sensor
+
+maintainers:
+ - Jacopo Mondi <jacopo@jmondi.org>
+
+description: |
+ The Omnivision OV7720/OV7725 sensor supports multiple resolutions output,
+ such as VGA, QVGA, and any size scaling down from CIF to 40x30. It also can
+ support the YUV422, RGB565/555/444, GRB422 or raw RGB output formats.
+
+properties:
+ compatible:
+ enum:
+ - ovti,ov7720
+ - ovti,ov7725
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ reset-gpios:
+ description: |
+ Reference to the GPIO connected to the RSTB pin which is active low.
+ maxItems: 1
+
+ powerdown-gpios:
+ description: |
+ Reference to the GPIO connected to the PWDN pin which is active high.
+ maxItems: 1
+
+ port:
+ type: object
+ description: |
+ Video output port. See ../video-interfaces.txt.
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - port
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ i2c0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ ov772x: camera@21 {
+ compatible = "ovti,ov7725";
+ reg = <0x21>;
+ reset-gpios = <&axi_gpio_0 0 GPIO_ACTIVE_LOW>;
+ powerdown-gpios = <&axi_gpio_0 1 GPIO_ACTIVE_LOW>;
+ clocks = <&xclk>;
+
+ port {
+ ov772x_0: endpoint {
+ remote-endpoint = <&vcap1_in0>;
+ };
+ };
+ };
+ };
+
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index cad34960d5ca..f55a6a4c75ba 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12817,7 +12817,7 @@ M: Jacopo Mondi <jacopo@jmondi.org>
L: linux-media@vger.kernel.org
S: Odd fixes
T: git git://linuxtv.org/media_tree.git
-F: Documentation/devicetree/bindings/media/i2c/ov772x.txt
+F: Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
F: drivers/media/i2c/ov772x.c
F: include/media/i2c/ov772x.h
--
2.28.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v5 1/3] dt-bindings: media: ov772x: Convert to json-schema
2020-09-10 16:20 ` [PATCH v5 1/3] " Jacopo Mondi
@ 2020-09-15 20:10 ` Rob Herring
0 siblings, 0 replies; 11+ messages in thread
From: Rob Herring @ 2020-09-15 20:10 UTC (permalink / raw)
To: Jacopo Mondi
Cc: sakari.ailus, linux-media, Lad Prabhakar, devicetree,
linux-renesas-soc, robh+dt, Lad, Prabhakar, mchehab,
hverkuil-cisco, laurent.pinchart
On Thu, 10 Sep 2020 18:20:53 +0200, Jacopo Mondi wrote:
> Convert the ov772x binding document to json-schema and update
> the MAINTAINERS file accordingly.
>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
> .../devicetree/bindings/media/i2c/ov772x.txt | 40 ----------
> .../bindings/media/i2c/ovti,ov772x.yaml | 74 +++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 75 insertions(+), 41 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/i2c/ov772x.txt
> create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v5 2/3] dt-bindings: media: ov772x: Make bus-type mandatory
2020-09-10 16:20 [PATCH v5 0/3] dt-bindings: media: ov772x: Convert to json-schema Jacopo Mondi
2020-09-10 16:20 ` [PATCH v5 1/3] " Jacopo Mondi
@ 2020-09-10 16:20 ` Jacopo Mondi
2020-09-11 5:37 ` Sakari Ailus
2020-09-10 16:20 ` [PATCH v5 3/3] dt-bindings: media: ov772x: Document endpoint props Jacopo Mondi
2 siblings, 1 reply; 11+ messages in thread
From: Jacopo Mondi @ 2020-09-10 16:20 UTC (permalink / raw)
To: robh+dt, devicetree, linux-media, Lad, Prabhakar
Cc: Jacopo Mondi, mchehab, sakari.ailus, hverkuil-cisco,
laurent.pinchart, linux-renesas-soc, Rob Herring, Lad Prabhakar
In order to establish required properties based on the selected
bus type, make the 'bus-type' property mandatory. As this change
documents an endpoint property, also document the 'remote-endpoint'
one now that the 'endpoint' schema has been expanded.
Binary compatibility with existing DTB is kept as the driver does not
enforce the property to be present, and shall fall-back to default
parallel bus configuration, which was the only supported bus type, if
the property is not specified.
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
.../bindings/media/i2c/ovti,ov772x.yaml | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
index e7e2d31fcc23..b034953b92e9 100644
--- a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
@@ -41,6 +41,21 @@ properties:
description: |
Video output port. See ../video-interfaces.txt.
+ properties:
+ endpoint:
+ type: object
+
+ properties:
+ bus-type:
+ enum: [5, 6]
+
+ required:
+ - bus-type
+
+ unevaluatedProperties: false
+
+ additionalProperties: false
+
required:
- compatible
- reg
@@ -65,6 +80,7 @@ examples:
port {
ov772x_0: endpoint {
+ bus-type = <5>;
remote-endpoint = <&vcap1_in0>;
};
};
--
2.28.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v5 2/3] dt-bindings: media: ov772x: Make bus-type mandatory
2020-09-10 16:20 ` [PATCH v5 2/3] dt-bindings: media: ov772x: Make bus-type mandatory Jacopo Mondi
@ 2020-09-11 5:37 ` Sakari Ailus
2020-09-11 8:58 ` Jacopo Mondi
0 siblings, 1 reply; 11+ messages in thread
From: Sakari Ailus @ 2020-09-11 5:37 UTC (permalink / raw)
To: Jacopo Mondi
Cc: robh+dt, devicetree, linux-media, Lad, Prabhakar, mchehab,
hverkuil-cisco, laurent.pinchart, linux-renesas-soc, Rob Herring,
Lad Prabhakar
Hi Jacopo,
On Thu, Sep 10, 2020 at 06:20:54PM +0200, Jacopo Mondi wrote:
> In order to establish required properties based on the selected
> bus type, make the 'bus-type' property mandatory. As this change
> documents an endpoint property, also document the 'remote-endpoint'
> one now that the 'endpoint' schema has been expanded.
>
> Binary compatibility with existing DTB is kept as the driver does not
> enforce the property to be present, and shall fall-back to default
> parallel bus configuration, which was the only supported bus type, if
> the property is not specified.
Could you add a comment on this to the driver, so this feature isn't
accidentally removed?
--
Regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v5 2/3] dt-bindings: media: ov772x: Make bus-type mandatory
2020-09-11 5:37 ` Sakari Ailus
@ 2020-09-11 8:58 ` Jacopo Mondi
2020-09-11 8:59 ` Prabhakar Mahadev Lad
0 siblings, 1 reply; 11+ messages in thread
From: Jacopo Mondi @ 2020-09-11 8:58 UTC (permalink / raw)
To: Sakari Ailus
Cc: Jacopo Mondi, robh+dt, devicetree, linux-media, Lad, Prabhakar,
mchehab, hverkuil-cisco, laurent.pinchart, linux-renesas-soc,
Rob Herring, Lad Prabhakar
Hi Sakari,
On Fri, Sep 11, 2020 at 08:37:57AM +0300, Sakari Ailus wrote:
> Hi Jacopo,
>
> On Thu, Sep 10, 2020 at 06:20:54PM +0200, Jacopo Mondi wrote:
> > In order to establish required properties based on the selected
> > bus type, make the 'bus-type' property mandatory. As this change
> > documents an endpoint property, also document the 'remote-endpoint'
> > one now that the 'endpoint' schema has been expanded.
> >
> > Binary compatibility with existing DTB is kept as the driver does not
> > enforce the property to be present, and shall fall-back to default
> > parallel bus configuration, which was the only supported bus type, if
> > the property is not specified.
>
> Could you add a comment on this to the driver, so this feature isn't
> accidentally removed?
Sure, can I send a patch in reply to this series to avoid a v6 ?
>
> --
> Regards,
>
> Sakari Ailus
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH v5 2/3] dt-bindings: media: ov772x: Make bus-type mandatory
2020-09-11 8:58 ` Jacopo Mondi
@ 2020-09-11 8:59 ` Prabhakar Mahadev Lad
2020-09-11 9:23 ` Sakari Ailus
2020-09-11 9:46 ` Jacopo Mondi
0 siblings, 2 replies; 11+ messages in thread
From: Prabhakar Mahadev Lad @ 2020-09-11 8:59 UTC (permalink / raw)
To: Jacopo Mondi, Sakari Ailus
Cc: Jacopo Mondi, robh+dt@kernel.org, devicetree@vger.kernel.org,
linux-media@vger.kernel.org, Lad, Prabhakar, mchehab@kernel.org,
hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com,
linux-renesas-soc@vger.kernel.org, Rob Herring
Hi Jacopo,
> -----Original Message-----
> From: Jacopo Mondi <jacopo@jmondi.org>
> Sent: 11 September 2020 09:59
> To: Sakari Ailus <sakari.ailus@linux.intel.com>
> Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>; robh+dt@kernel.org; devicetree@vger.kernel.org; linux-media@vger.kernel.org; Lad,
> Prabhakar <prabhakar.csengg@gmail.com>; mchehab@kernel.org; hverkuil-cisco@xs4all.nl; laurent.pinchart@ideasonboard.com; linux-
> renesas-soc@vger.kernel.org; Rob Herring <robh@kernel.org>; Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Subject: Re: [PATCH v5 2/3] dt-bindings: media: ov772x: Make bus-type mandatory
>
> Hi Sakari,
>
> On Fri, Sep 11, 2020 at 08:37:57AM +0300, Sakari Ailus wrote:
> > Hi Jacopo,
> >
> > On Thu, Sep 10, 2020 at 06:20:54PM +0200, Jacopo Mondi wrote:
> > > In order to establish required properties based on the selected
> > > bus type, make the 'bus-type' property mandatory. As this change
> > > documents an endpoint property, also document the 'remote-endpoint'
> > > one now that the 'endpoint' schema has been expanded.
> > >
> > > Binary compatibility with existing DTB is kept as the driver does not
> > > enforce the property to be present, and shall fall-back to default
> > > parallel bus configuration, which was the only supported bus type, if
> > > the property is not specified.
> >
> > Could you add a comment on this to the driver, so this feature isn't
> > accidentally removed?
>
> Sure, can I send a patch in reply to this series to avoid a v6 ?
If you don’t mind Ill handle this as part of bt656 additions ?
Cheers,
Prabhakar
Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v5 2/3] dt-bindings: media: ov772x: Make bus-type mandatory
2020-09-11 8:59 ` Prabhakar Mahadev Lad
@ 2020-09-11 9:23 ` Sakari Ailus
2020-09-11 9:46 ` Jacopo Mondi
1 sibling, 0 replies; 11+ messages in thread
From: Sakari Ailus @ 2020-09-11 9:23 UTC (permalink / raw)
To: Prabhakar Mahadev Lad
Cc: Jacopo Mondi, Jacopo Mondi, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-media@vger.kernel.org,
Lad, Prabhakar, mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
laurent.pinchart@ideasonboard.com,
linux-renesas-soc@vger.kernel.org, Rob Herring
On Fri, Sep 11, 2020 at 08:59:13AM +0000, Prabhakar Mahadev Lad wrote:
> Hi Jacopo,
>
> > -----Original Message-----
> > From: Jacopo Mondi <jacopo@jmondi.org>
> > Sent: 11 September 2020 09:59
> > To: Sakari Ailus <sakari.ailus@linux.intel.com>
> > Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>; robh+dt@kernel.org; devicetree@vger.kernel.org; linux-media@vger.kernel.org; Lad,
> > Prabhakar <prabhakar.csengg@gmail.com>; mchehab@kernel.org; hverkuil-cisco@xs4all.nl; laurent.pinchart@ideasonboard.com; linux-
> > renesas-soc@vger.kernel.org; Rob Herring <robh@kernel.org>; Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Subject: Re: [PATCH v5 2/3] dt-bindings: media: ov772x: Make bus-type mandatory
> >
> > Hi Sakari,
> >
> > On Fri, Sep 11, 2020 at 08:37:57AM +0300, Sakari Ailus wrote:
> > > Hi Jacopo,
> > >
> > > On Thu, Sep 10, 2020 at 06:20:54PM +0200, Jacopo Mondi wrote:
> > > > In order to establish required properties based on the selected
> > > > bus type, make the 'bus-type' property mandatory. As this change
> > > > documents an endpoint property, also document the 'remote-endpoint'
> > > > one now that the 'endpoint' schema has been expanded.
> > > >
> > > > Binary compatibility with existing DTB is kept as the driver does not
> > > > enforce the property to be present, and shall fall-back to default
> > > > parallel bus configuration, which was the only supported bus type, if
> > > > the property is not specified.
> > >
> > > Could you add a comment on this to the driver, so this feature isn't
> > > accidentally removed?
> >
> > Sure, can I send a patch in reply to this series to avoid a v6 ?
> If you don’t mind Ill handle this as part of bt656 additions ?
Both are fine for me.
--
Sakari Ailus
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v5 2/3] dt-bindings: media: ov772x: Make bus-type mandatory
2020-09-11 8:59 ` Prabhakar Mahadev Lad
2020-09-11 9:23 ` Sakari Ailus
@ 2020-09-11 9:46 ` Jacopo Mondi
1 sibling, 0 replies; 11+ messages in thread
From: Jacopo Mondi @ 2020-09-11 9:46 UTC (permalink / raw)
To: Prabhakar Mahadev Lad
Cc: Sakari Ailus, Jacopo Mondi, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-media@vger.kernel.org,
Lad, Prabhakar, mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
laurent.pinchart@ideasonboard.com,
linux-renesas-soc@vger.kernel.org, Rob Herring
Hi Prabhakar,
On Fri, Sep 11, 2020 at 08:59:13AM +0000, Prabhakar Mahadev Lad wrote:
> Hi Jacopo,
>
> > -----Original Message-----
> > From: Jacopo Mondi <jacopo@jmondi.org>
> > Sent: 11 September 2020 09:59
> > To: Sakari Ailus <sakari.ailus@linux.intel.com>
> > Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>; robh+dt@kernel.org; devicetree@vger.kernel.org; linux-media@vger.kernel.org; Lad,
> > Prabhakar <prabhakar.csengg@gmail.com>; mchehab@kernel.org; hverkuil-cisco@xs4all.nl; laurent.pinchart@ideasonboard.com; linux-
> > renesas-soc@vger.kernel.org; Rob Herring <robh@kernel.org>; Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Subject: Re: [PATCH v5 2/3] dt-bindings: media: ov772x: Make bus-type mandatory
> >
> > Hi Sakari,
> >
> > On Fri, Sep 11, 2020 at 08:37:57AM +0300, Sakari Ailus wrote:
> > > Hi Jacopo,
> > >
> > > On Thu, Sep 10, 2020 at 06:20:54PM +0200, Jacopo Mondi wrote:
> > > > In order to establish required properties based on the selected
> > > > bus type, make the 'bus-type' property mandatory. As this change
> > > > documents an endpoint property, also document the 'remote-endpoint'
> > > > one now that the 'endpoint' schema has been expanded.
> > > >
> > > > Binary compatibility with existing DTB is kept as the driver does not
> > > > enforce the property to be present, and shall fall-back to default
> > > > parallel bus configuration, which was the only supported bus type, if
> > > > the property is not specified.
> > >
> > > Could you add a comment on this to the driver, so this feature isn't
> > > accidentally removed?
> >
> > Sure, can I send a patch in reply to this series to avoid a v6 ?
> If you don’t mind Ill handle this as part of bt656 additions ?
It's not an issue for me. From a process perspective it might be
better if we know that comment and this series gets merged in the same
release to avoid 'holes', but if you're confident the BT.656 series will
land at the same time please go ahead!
>
> Cheers,
> Prabhakar
>
>
> Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v5 3/3] dt-bindings: media: ov772x: Document endpoint props
2020-09-10 16:20 [PATCH v5 0/3] dt-bindings: media: ov772x: Convert to json-schema Jacopo Mondi
2020-09-10 16:20 ` [PATCH v5 1/3] " Jacopo Mondi
2020-09-10 16:20 ` [PATCH v5 2/3] dt-bindings: media: ov772x: Make bus-type mandatory Jacopo Mondi
@ 2020-09-10 16:20 ` Jacopo Mondi
2020-09-15 20:12 ` Rob Herring
2 siblings, 1 reply; 11+ messages in thread
From: Jacopo Mondi @ 2020-09-10 16:20 UTC (permalink / raw)
To: robh+dt, devicetree, linux-media, Lad, Prabhakar
Cc: Jacopo Mondi, mchehab, sakari.ailus, hverkuil-cisco,
laurent.pinchart, linux-renesas-soc, Lad Prabhakar
Document endpoint properties for the parallel bus type and
add them to the example.
Specify a few constraints:
- If the bus type is BT.656 no hsync or vsync polarities can be
specified.
- If the bus width is 10 bits, not data-shift can be applied.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
.../bindings/media/i2c/ovti,ov772x.yaml | 44 +++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
index b034953b92e9..63b3779d7289 100644
--- a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
@@ -49,6 +49,45 @@ properties:
bus-type:
enum: [5, 6]
+ bus-width:
+ enum: [8, 10]
+ default: 10
+
+ data-shift:
+ enum: [0, 2]
+ default: 0
+
+ hsync-active:
+ enum: [0, 1]
+ default: 1
+
+ vsync-active:
+ enum: [0, 1]
+ default: 1
+
+ pclk-sample:
+ enum: [0, 1]
+ default: 1
+
+ allOf:
+ - if:
+ properties:
+ bus-type:
+ const: 6
+ then:
+ properties:
+ hsync-active: false
+ vsync-active: false
+
+ - if:
+ properties:
+ bus-width:
+ const: 10
+ then:
+ properties:
+ data-shift:
+ const: 0
+
required:
- bus-type
@@ -81,6 +120,11 @@ examples:
port {
ov772x_0: endpoint {
bus-type = <5>;
+ vsync-active = <0>;
+ hsync-active = <0>;
+ pclk-sample = <0>;
+ bus-width = <8>;
+ data-shift = <0>;
remote-endpoint = <&vcap1_in0>;
};
};
--
2.28.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v5 3/3] dt-bindings: media: ov772x: Document endpoint props
2020-09-10 16:20 ` [PATCH v5 3/3] dt-bindings: media: ov772x: Document endpoint props Jacopo Mondi
@ 2020-09-15 20:12 ` Rob Herring
0 siblings, 0 replies; 11+ messages in thread
From: Rob Herring @ 2020-09-15 20:12 UTC (permalink / raw)
To: Jacopo Mondi
Cc: robh+dt, devicetree, laurent.pinchart, linux-renesas-soc,
Lad, Prabhakar, sakari.ailus, linux-media, mchehab, Lad Prabhakar,
hverkuil-cisco
On Thu, 10 Sep 2020 18:20:55 +0200, Jacopo Mondi wrote:
> Document endpoint properties for the parallel bus type and
> add them to the example.
>
> Specify a few constraints:
> - If the bus type is BT.656 no hsync or vsync polarities can be
> specified.
> - If the bus width is 10 bits, not data-shift can be applied.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
> .../bindings/media/i2c/ovti,ov772x.yaml | 44 +++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread