From: Rob Herring <robh@kernel.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Jeykumar Sankaran <jsanka@codeaurora.org>,
Chandan Uddaraju <chandanu@codeaurora.org>,
Vara Reddy <varar@codeaurora.org>,
Tanmay Shah <tanmay@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Manu Gautam <mgautam@codeaurora.org>,
Sandeep Maheswaram <sanm@codeaurora.org>,
Douglas Anderson <dianders@chromium.org>,
Sean Paul <seanpaul@chromium.org>,
Jonathan Marek <jonathan@marek.ca>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
devicetree@vger.kernel.org, Rob Clark <robdclark@chromium.org>
Subject: Re: [PATCH v3 01/10] dt-bindings: phy: qcom,qmp-usb3-dp: Add DP phy information
Date: Tue, 15 Sep 2020 14:24:32 -0600 [thread overview]
Message-ID: <20200915202432.GA2435458@bogus> (raw)
In-Reply-To: <159972050159.2295844.14715100754744266014@swboyd.mtv.corp.google.com>
On Wed, Sep 09, 2020 at 11:48:21PM -0700, Stephen Boyd wrote:
> Quoting Stephen Boyd (2020-09-09 17:48:53)
> > This binding only describes the USB phy inside the USB3 + DP "combo"
> > phy. Add information for the DP phy and describe the sub-nodes that
> > represent the DP and USB3 phys that exist inside the combo wrapper.
> > Remove reg-names from required properties because it isn't required nor
> > used by the kernel driver.
> >
> > Cc: Jeykumar Sankaran <jsanka@codeaurora.org>
> > Cc: Chandan Uddaraju <chandanu@codeaurora.org>
> > Cc: Vara Reddy <varar@codeaurora.org>
> > Cc: Tanmay Shah <tanmay@codeaurora.org>
> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> > Cc: Manu Gautam <mgautam@codeaurora.org>
> > Cc: Sandeep Maheswaram <sanm@codeaurora.org>
> > Cc: Douglas Anderson <dianders@chromium.org>
> > Cc: Sean Paul <seanpaul@chromium.org>
> > Cc: Jonathan Marek <jonathan@marek.ca>
> > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > Cc: <devicetree@vger.kernel.org>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: Rob Clark <robdclark@chromium.org>
> > Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> > ---
> > .../bindings/phy/qcom,qmp-usb3-dp-phy.yaml | 91 +++++++++++++++++--
> > 1 file changed, 81 insertions(+), 10 deletions(-)
>
> I noticed that I didn't document the new compatible string I'm using,
> qcom,sc7180-qmp-usb3-dp-phy, ugh.
>
> Should I copy the whole file over and make a new document for the new
> compatible string? That feels like the better solution vs. making this
> binding have min/max stuff where it fails to enforce the DP part of the
> phy. We can delete this binding once the kernel tree isn't using it,
> right?
It generally depends on how much if/then schema you have (or should
have) vs. how much is common, but it's a judgement call. It looks
like you are just extending the binding for the most part. If there's
dtb warnings until the existing stuff gets updated, that's fine.
Rob
next prev parent reply other threads:[~2020-09-15 20:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 0:48 [PATCH v3 00/10] Support qcom USB3+DP combo phy (or type-c phy) Stephen Boyd
2020-09-10 0:48 ` [PATCH v3 01/10] dt-bindings: phy: qcom,qmp-usb3-dp: Add DP phy information Stephen Boyd
2020-09-10 6:48 ` Stephen Boyd
2020-09-15 20:24 ` Rob Herring [this message]
2020-09-16 19:42 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915202432.GA2435458@bogus \
--to=robh@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=chandanu@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jonathan@marek.ca \
--cc=jsanka@codeaurora.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgautam@codeaurora.org \
--cc=robdclark@chromium.org \
--cc=sanm@codeaurora.org \
--cc=seanpaul@chromium.org \
--cc=swboyd@chromium.org \
--cc=tanmay@codeaurora.org \
--cc=varar@codeaurora.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).