From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3971FC43461 for ; Wed, 16 Sep 2020 01:16:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE0A2207DE for ; Wed, 16 Sep 2020 01:15:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="nkRKWBkc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726136AbgIPBP7 (ORCPT ); Tue, 15 Sep 2020 21:15:59 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:55448 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726102AbgIPBP6 (ORCPT ); Tue, 15 Sep 2020 21:15:58 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 08G1FrPu028558; Tue, 15 Sep 2020 20:15:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1600218953; bh=fDEs7XwqFmPjCnnGMnLX8/Aurl9jh4eiU7mXh50CtGQ=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=nkRKWBkcoV/BWt9kvaiM+U7VVTvpcm5Hr6irdy5RkcN3EbGDRMGbbLYA5HgKDC6cF lCaG0CR9Z6YCZxjj2uYf6CkVace0SZ5NEZCaIEWC+WhURJi+0SjWfI2lY8Zr/qJ1DR kEIL2tAOwEDnTvaNft+uj2imc5j2EyxCR/moXv4Q= Received: from DFLE107.ent.ti.com (dfle107.ent.ti.com [10.64.6.28]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 08G1FqA3113288 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 15 Sep 2020 20:15:53 -0500 Received: from DFLE112.ent.ti.com (10.64.6.33) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 15 Sep 2020 20:15:52 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 15 Sep 2020 20:15:52 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 08G1Fqhb080323; Tue, 15 Sep 2020 20:15:52 -0500 Date: Tue, 15 Sep 2020 20:15:52 -0500 From: Nishanth Menon To: Suman Anna CC: Lokesh Vutla , Tero Kristo , Rob Herring , Linux ARM Mailing List , Device Tree Mailing List , Sekhar Nori , Grygorii Strashko , Kishon Vijay Abraham I Subject: Re: [PATCH v4 5/5] arm64: dts: ti: Add support for J7200 Common Processor Board Message-ID: <20200916011552.armvw6s7jxr4gxca@akan> References: <20200914162231.2535-1-lokeshvutla@ti.com> <20200914162231.2535-6-lokeshvutla@ti.com> <7d7f3ba2-d687-a90b-e4e9-6bec835e093f@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <7d7f3ba2-d687-a90b-e4e9-6bec835e093f@ti.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10:33-20200915, Suman Anna wrote: > On 9/14/20 11:22 AM, Lokesh Vutla wrote: > > Add support for J7200 Common Processor Board. > > The EVM architecture is very similar to J721E as follows: > > > > +------------------------------------------------------+ > > | +-------------------------------------------+ | > > | | | | > > | | Add-on Card 1 Options | | > > | | | | > > | +-------------------------------------------+ | > > | | > > | | > > | +-------------------+ | > > | | | | > > | | SOM | | > > | +--------------+ | | | > > | | | | | | > > | | Add-on | +-------------------+ | > > | | Card 2 | | Power Supply > > | | Options | | | > > | | | | | > > | +--------------+ | <--- > > +------------------------------------------------------+ > > Common Processor Board > > > > Common Processor board is the baseboard that has most of the actual > > connectors, power supply etc. A SOM (System on Module) is plugged on > > to the common processor board and this contains the SoC, PMIC, DDR and > > basic high speed components necessary for functionality. > > > > Note: > > * The minimum configuration required to boot up the board is System On > > Module(SOM) + Common Processor Board. > > * Since there is just a single SOM and Common Processor Board, we are > > maintaining common processor board as the base dts and SOM as the dtsi > > that we include. In the future as more SOM's appear, we should move > > common processor board as a dtsi and include configurations as dts. > > * All daughter cards beyond the basic boards shall be maintained as > > overlays. > > > > Reviewed-by: Grygorii Strashko > > Signed-off-by: Lokesh Vutla > > Signed-off-by: Peter Ujfalusi > > --- > > arch/arm64/boot/dts/ti/Makefile | 2 + > > .../dts/ti/k3-j7200-common-proc-board.dts | 64 +++++++++++++++++++ > > arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi | 29 +++++++++ > > 3 files changed, 95 insertions(+) > > create mode 100644 arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts > > create mode 100644 arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi > > > > diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile > > index 7f28be62b8da..65506f21ba30 100644 > > --- a/arch/arm64/boot/dts/ti/Makefile > > +++ b/arch/arm64/boot/dts/ti/Makefile > > @@ -9,3 +9,5 @@ > > dtb-$(CONFIG_ARCH_K3) += k3-am654-base-board.dtb > > > > dtb-$(CONFIG_ARCH_K3) += k3-j721e-common-proc-board.dtb > > + > > +dtb-$(CONFIG_ARCH_K3) += k3-j7200-common-proc-board.dtb > > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts > > new file mode 100644 > > index 000000000000..e27069317c4e > > --- /dev/null > > +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts > > @@ -0,0 +1,64 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (C) 2020 Texas Instruments Incorporated - https://www.ti.com/ > > + */ > > + > > +/dts-v1/; > > + > > +#include "k3-j7200-som-p0.dtsi" > > + > > +/ { > > + chosen { > > + stdout-path = "serial2:115200n8"; > > + bootargs = "console=ttyS2,115200n8 earlycon=ns16550a,mmio32,0x02800000"; > > + }; > > +}; > > + > > +&wkup_uart0 { > > + /* Wakeup UART is used by System firmware */ > > + status = "disabled"; > > +}; > > + > > +&main_uart0 { > > + power-domains = <&k3_pds 146 TI_SCI_PD_SHARED>; > > Perhaps a comment here to explain why this is being overwritten to use > PD_SHARED. I don't see anything in the Changelog either. Shared with ATF on this platform -> I can add this comment on applying. > > Otherwise, looks good. Would that be a reviewed-by? -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D