From: Marek Behun <marek.behun@nic.cz>
To: Rob Herring <robh@kernel.org>
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH leds] dt-bindings: leds: cznic,turris-omnia-leds: fix error in binding
Date: Wed, 16 Sep 2020 01:41:53 +0200 [thread overview]
Message-ID: <20200916014153.4dbb05d6@nic.cz> (raw)
In-Reply-To: <20200915212258.GA2525921@bogus>
On Tue, 15 Sep 2020 15:22:58 -0600
Rob Herring <robh@kernel.org> wrote:
> On Tue, Sep 15, 2020 at 02:54:26AM +0200, Marek Behún wrote:
> > There is a bug in the device tree binding for cznic,turris-omnia-leds
> > which causes make dt_binding_check to complain.
> >
> > The reason is that the multi-led property binding's regular expression
> > does not contain the `@` character, while the example nodes do.
> >
> > Fix this, and also allow for longer address in property name.
> >
> > Signed-off-by: Marek Behún <marek.behun@nic.cz>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: devicetree@vger.kernel.org
> > Cc: Pavel Machek <pavel@ucw.cz>
> > ---
> > .../devicetree/bindings/leds/cznic,turris-omnia-leds.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml
> > index 24ad1446445ea..486ab27d75f2f 100644
> > --- a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml
> > +++ b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml
> > @@ -30,7 +30,7 @@ properties:
> > const: 0
> >
> > patternProperties:
> > - "^multi-led[0-9a-f]$":
> > + "^multi-led@[0-9a-f]+$":
>
> There are only 12 LEDs on the device based on the description and 'reg',
> so 'b' is the max unit-address.
>
> I can fixup when applying: "^multi-led@[0-9a-b]$"
>
Please do, thanks.
Marek
next prev parent reply other threads:[~2020-09-15 23:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 0:54 [PATCH leds] dt-bindings: leds: cznic,turris-omnia-leds: fix error in binding Marek Behún
2020-09-15 21:22 ` Rob Herring
2020-09-15 23:41 ` Marek Behun [this message]
2020-09-16 3:02 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916014153.4dbb05d6@nic.cz \
--to=marek.behun@nic.cz \
--cc=devicetree@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).