From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEB51C2BB84 for ; Wed, 16 Sep 2020 18:45:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E23522208 for ; Wed, 16 Sep 2020 18:45:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728102AbgIPSpL (ORCPT ); Wed, 16 Sep 2020 14:45:11 -0400 Received: from lhrrgout.huawei.com ([185.176.76.210]:2873 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727803AbgIPSpK (ORCPT ); Wed, 16 Sep 2020 14:45:10 -0400 Received: from lhreml710-chm.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id 1AD492BC5282385D4790; Wed, 16 Sep 2020 11:38:02 +0100 (IST) Received: from localhost (10.52.126.84) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1913.5; Wed, 16 Sep 2020 11:38:01 +0100 Date: Wed, 16 Sep 2020 11:36:25 +0100 From: Jonathan Cameron To: Joel Stanley CC: Jonathan Cameron , , "Rob Herring" , devicetree , "Rick Altherr" , Andrew Jeffery Subject: Re: [PATCH v2 04/20] dt-bindings:iio:adc: aspeed,ast2400 yaml conversion Message-ID: <20200916113625.0000641e@Huawei.com> In-Reply-To: References: <20200909175946.395313-1-jic23@kernel.org> <20200909175946.395313-5-jic23@kernel.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.52.126.84] X-ClientProxiedBy: lhreml707-chm.china.huawei.com (10.201.108.56) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 10 Sep 2020 02:32:19 +0000 Joel Stanley wrote: > On Wed, 9 Sep 2020 at 18:02, Jonathan Cameron wrote: > > > > From: Jonathan Cameron > > > > Simple txt to yaml conversion. Part of a general move to convert > > all the IIO bindings over to yaml. > > > > Signed-off-by: Jonathan Cameron > > Cc: Rick Altherr > > Cc: Joel Stanley > > Cc: Andrew Jeffery > > Acked-by: Joel Stanley > > > > --- > > .../bindings/iio/adc/aspeed,ast2400-adc.yaml | 54 +++++++++++++++++++ > > .../bindings/iio/adc/aspeed_adc.txt | 22 -------- > > 2 files changed, 54 insertions(+), 22 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/aspeed,ast2400-adc.yaml b/Documentation/devicetree/bindings/iio/adc/aspeed,ast2400-adc.yaml > > new file mode 100644 > > index 000000000000..09018487d690 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/adc/aspeed,ast2400-adc.yaml > > This naming doesn't make sense, as the bindings are for the ast2500 > too (and they also apply for the ast2600). Convention is to name after a supported device and not use wild cards or generic names because the chances of it going wrong in future is far too high. Will every aspeed adc look the same? Seems impossible to predict so best we can do safely is to pick a part number. There are enormous numbers of examples of this in dt bindings and for that matter driver naming. Thanks, Jonathan > > > @@ -0,0 +1,54 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/iio/adc/aspeed,ast2400-adc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: ADC that forms part of an ASPEED server management processor. > > + > > +maintainers: > > + - Rick Altherr > > + > > +description: > > + This device is a 10-bit converter for 16 voltage channels. All inputs are > > + single ended. > > + > > +properties: > > + compatible: > > + enum: > > + - aspeed,ast2400-adc > > + - aspeed,ast2500-adc > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + description: > > + Input clock used to derive the sample clock. Expected to be the > > + SoC's APB clock. > > + > > + resets: true > > + > > + "#io-channel-cells": > > + const: 1 > > + > > +required: > > + - compatible > > + - reg > > + - clocks > > + - resets > > + - "#io-channel-cells" > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + adc@1e6e9000 { > > + compatible = "aspeed,ast2400-adc"; > > + reg = <0x1e6e9000 0xb0>; > > + clocks = <&syscon ASPEED_CLK_APB>; > > + resets = <&syscon ASPEED_RESET_ADC>; > > + #io-channel-cells = <1>; > > + }; > > +... > > diff --git a/Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt b/Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt > > deleted file mode 100644 > > index 034fc2ba100e..000000000000 > > --- a/Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt > > +++ /dev/null > > @@ -1,22 +0,0 @@ > > -Aspeed ADC > > - > > -This device is a 10-bit converter for 16 voltage channels. All inputs are > > -single ended. > > - > > -Required properties: > > -- compatible: Should be "aspeed,ast2400-adc" or "aspeed,ast2500-adc" > > -- reg: memory window mapping address and length > > -- clocks: Input clock used to derive the sample clock. Expected to be the > > - SoC's APB clock. > > -- resets: Reset controller phandle > > -- #io-channel-cells: Must be set to <1> to indicate channels are selected > > - by index. > > - > > -Example: > > - adc@1e6e9000 { > > - compatible = "aspeed,ast2400-adc"; > > - reg = <0x1e6e9000 0xb0>; > > - clocks = <&syscon ASPEED_CLK_APB>; > > - resets = <&syscon ASPEED_RESET_ADC>; > > - #io-channel-cells = <1>; > > - }; > > -- > > 2.28.0 > >