devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jeff LaBundy <jeff@labundy.com>
Cc: robh+dt@kernel.org, linux-input@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [RESEND 5/5] input: iqs269a: Make sliders two-dimensional
Date: Wed, 16 Sep 2020 17:03:29 -0700	[thread overview]
Message-ID: <20200917000329.GM1681290@dtor-ws> (raw)
In-Reply-To: <1600289400-27632-6-git-send-email-jeff@labundy.com>

On Wed, Sep 16, 2020 at 03:50:00PM -0500, Jeff LaBundy wrote:
> libinput rejects devices that define one axis without the orthogonal
> axis, as well as devices for which either axis's resolution is zero.
> 
> To solve this problem, present a thin y-axis with a resolution equal
> to one.

No, let's fix this in libinput please.

> 
> Signed-off-by: Jeff LaBundy <jeff@labundy.com>
> ---
>  drivers/input/misc/iqs269a.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/input/misc/iqs269a.c b/drivers/input/misc/iqs269a.c
> index 04947f1..4a0e4ec 100644
> --- a/drivers/input/misc/iqs269a.c
> +++ b/drivers/input/misc/iqs269a.c
> @@ -1377,6 +1377,8 @@ static int iqs269_input_init(struct iqs269_private *iqs269)
>  					     EV_KEY, BTN_TOUCH);
>  			input_set_abs_params(iqs269->slider[i],
>  					     ABS_X, 0, 255, 0, 0);
> +			input_set_abs_params(iqs269->slider[i],
> +					     ABS_Y, 0, 1, 0, 0);
>  		}
>  
>  		error = input_register_device(iqs269->slider[i]);
> -- 
> 2.7.4
> 

Thanks.

-- 
Dmitry

      reply	other threads:[~2020-09-17  0:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-16 20:49 [RESEND 0/5] input: iqs269a: Add support for slider gestures and OTP variants Jeff LaBundy
2020-09-16 20:49 ` [RESEND 1/5] dt-bindings: input: iqs269a: Add bindings for slider gestures Jeff LaBundy
2020-09-16 20:49 ` [RESEND 2/5] input: iqs269a: Add support " Jeff LaBundy
2020-09-16 20:49 ` [RESEND 3/5] dt-bindings: input: iqs269a: Add bindings for OTP variants Jeff LaBundy
2020-09-16 20:49 ` [RESEND 4/5] input: iqs269a: Add support " Jeff LaBundy
2020-09-16 20:50 ` [RESEND 5/5] input: iqs269a: Make sliders two-dimensional Jeff LaBundy
2020-09-17  0:03   ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200917000329.GM1681290@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jeff@labundy.com \
    --cc=linux-input@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).