Re: [PATCH 3/5] dt-bindings: pci: qcom: Document PCIe bindings for SM8250 SoC

Bjorn Andersson
2020-09-16T22:55:39Z

On Wed 16 Sep 08:19 CDT 2020, Manivannan Sadhasivam wrote:

> Document the PCIe DT bindings for SM8250 SoC. The PCIe IP is similar to
> the one used on SDM845, hence just add the compatible.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> Documentation/devicetree/bindings/pci/qcom,pcie.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.txt b/Documentation/devicetree/bindings/pci/qcom,pcie.txt
> index 02bc81bb8b2d..7fc328c54c39 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.txt
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.txt
> @@ -13,6 +13,7 @@
> - "qcom,pcie-ipq8074" for ipq8074
> - "qcom,pcie-qcs404" for qcs404
> - "qcom,pcie-sdm845" for sdm845
> + - "qcom,pcie-sm8250" for sm8250
>
> - reg:
> Usage: required

reg-names is missing "atu"

Regards,
Bjorn

> @@ -131,7 +132,7 @@
> - "slave_bus" AXI Slave clock
>
> -clock-names:
> - Usage: required for sdm845
> + Usage: required for sdm845 and sm8250
> Value type: <stringlist>
> Definition: Should contain the following entries
> - "aux" Auxiliary clock
> @@ -206,7 +207,7 @@
> - "ahb" AHB reset
>
> - reset-names:
> - Usage: required for sdm845
> + Usage: required for sdm845 and sm8250
> Value type: <stringlist>
> Definition: Should contain the following entries
> - "pci" PCIe core reset
> --
> 2.17.1
>