From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E1F5C433E2 for ; Thu, 17 Sep 2020 18:55:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F355F206BE for ; Thu, 17 Sep 2020 18:55:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600368934; bh=K35A2qsMNPXC5YuzjFZniTMwYA/oDSL0/3jmK22lyEA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=rEVJ5OOLdY2RReIEVtLROApqqY9lWApGP53+UziZxoDL7MQO5YIey8P/j0FI5fCpT nfIHDwoFkBsc2VVTtctLAAIwHaCe+etep+55/8DK5+KnOTwjEgqobWJluSCSYdpTFL tmHXm19MYC76p7+pw3N21B52cUe2qaWIpyK+rH0A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726338AbgIQSzP (ORCPT ); Thu, 17 Sep 2020 14:55:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:56706 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726414AbgIQSzI (ORCPT ); Thu, 17 Sep 2020 14:55:08 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0067122205; Thu, 17 Sep 2020 18:55:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600368908; bh=K35A2qsMNPXC5YuzjFZniTMwYA/oDSL0/3jmK22lyEA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lWx+OLY6c2HQQvQugbwG16vm03WQgmyd5yYtUqMqG3V3jqAXbgCZi5K8kmqasaVRn D+1txO7Y3O8kkMLqf1PqLxbN7a3H50Tp3GpdiyyxLTJOpd/UMQ6ogKXaOUjsR2cx0S wlRTlqDQS9NzniE8hNVXwjVLmrg2gMSxEQpvs6kc= From: Krzysztof Kozlowski To: Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Krzysztof Kozlowski , Adam Ford , Daniel Baluta , Anson Huang , Jacky Bai , Robin Gong , Peter Chen , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Tim Harvey Subject: [PATCH v2 3/4] arm64: dts: imx8mn: correct interrupt flags Date: Thu, 17 Sep 2020 20:54:48 +0200 Message-Id: <20200917185449.5687-3-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200917185449.5687-1-krzk@kernel.org> References: <20200917185449.5687-1-krzk@kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. These are simple defines so they could be used in DTS but they will not have the same meaning: 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING Correct the interrupt flags, assuming the author of the code wanted same logical behavior behind the name "ACTIVE_xxx", this is: ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW For level low interrupts, enable also internal pull up. It is required at least on imx8mm-evk, according to schematics. Signed-off-by: Krzysztof Kozlowski --- Not tested on HW. Changes since v1: 1. Correct title. 2. Enable pull ups. --- arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts | 4 ++-- arch/arm64/boot/dts/freescale/imx8mn-evk.dts | 3 ++- arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts index 8f7155716c84..b0e8cb256a78 100644 --- a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts +++ b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts @@ -55,7 +55,7 @@ reg = <0x4b>; pinctrl-0 = <&pinctrl_pmic>; interrupt-parent = <&gpio1>; - interrupts = <3 GPIO_ACTIVE_LOW>; + interrupts = <3 IRQ_TYPE_LEVEL_LOW>; rohm,reset-snvs-powered; regulators { @@ -157,7 +157,7 @@ &iomuxc { pinctrl_pmic: pmicirqgrp { fsl,pins = < - MX8MN_IOMUXC_GPIO1_IO03_GPIO1_IO3 0x41 + MX8MN_IOMUXC_GPIO1_IO03_GPIO1_IO3 0x141 >; }; }; diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts index b846526a8d8b..707d8486b4d8 100644 --- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts +++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts @@ -7,6 +7,7 @@ #include "imx8mn.dtsi" #include "imx8mn-evk.dtsi" +#include / { model = "NXP i.MX8MNano EVK board"; @@ -19,7 +20,7 @@ reg = <0x25>; pinctrl-0 = <&pinctrl_pmic>; interrupt-parent = <&gpio1>; - interrupts = <3 GPIO_ACTIVE_LOW>; + interrupts = <3 IRQ_TYPE_LEVEL_LOW>; regulators { buck1: BUCK1{ diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi index 7f4b904e9982..4aa0dbd578df 100644 --- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi @@ -225,7 +225,7 @@ pinctrl_pmic: pmicirqgrp { fsl,pins = < - MX8MN_IOMUXC_GPIO1_IO03_GPIO1_IO3 0x41 + MX8MN_IOMUXC_GPIO1_IO03_GPIO1_IO3 0x141 >; }; -- 2.17.1