From: Michael Auchter <michael.auchter@ni.com>
To: Ben Levinsky <ben.levinsky@xilinx.com>
Cc: punit1.agrawal@toshiba.co.jp, stefanos@xilinx.com,
michals@xilinx.com, devicetree@vger.kernel.org,
mathieu.poirier@linaro.org, emooring@xilinx.com,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
jliang@xilinx.com, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
Wendy Liang <wendy.liang@xilinx.com>,
Michal Simek <michal.simek@xilinx.com>,
Ed Mooring <ed.mooring@xilinx.com>, Jason Wu <j.wu@xilinx.com>
Subject: Re: [PATCH v14 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver
Date: Thu, 17 Sep 2020 17:11:20 -0500 [thread overview]
Message-ID: <20200917221120.GA15530@xaphan> (raw)
In-Reply-To: <20200917194341.16272-6-ben.levinsky@xilinx.com>
Hey Ben,
Split mode is still not functional in this patch series (as was the case
with the last few revisions).
Before sending out the next revision, can you _please_ ensure you're
testing all supported configurations?
On Thu, Sep 17, 2020 at 12:43:41PM -0700, Ben Levinsky wrote:
> +/**
> + * RPU core configuration
> + */
> +static enum rpu_oper_mode rpu_mode;
> +
<.. snip ..>
> +static int zynqmp_r5_remoteproc_probe(struct platform_device *pdev)
> +{
> + int ret, i = 0;
> + u32 lockstep_mode;
> + struct device *dev = &pdev->dev;
> + struct device_node *nc;
> +
> + ret = of_property_read_u32(dev->of_node,
> + "lockstep-mode",
> + &lockstep_mode);
> + if (ret < 0) {
> + return ret;
> + } else if (lockstep_mode != PM_RPU_MODE_LOCKSTEP &&
> + lockstep_mode != PM_RPU_MODE_SPLIT) {
> + dev_err(dev,
> + "Invalid lockstep-mode %x in %pOF\n",
> + lockstep_mode, dev->of_node);
> + return -EINVAL;
> + }
> +
> + rpu_mode = lockstep_mode;
> +
> + dev_dbg(dev, "RPU configuration: %s\n",
> + lockstep_mode ? "lockstep" : "split");
The binding documents lockstep-mode as:
> + lockstep-mode:
> + description:
> + R5 core configuration (split is 0 or lock-step and 1)
> + maxItems: 1
(Which needs to be reworded, but it looks like the intent was "split is
0 and lock-step is 1")
However, rpu_oper_mode is defined as:
> +enum rpu_oper_mode {
> + PM_RPU_MODE_LOCKSTEP = 0,
> + PM_RPU_MODE_SPLIT = 1,
> +};
so the assignment "rpu_mode = lockstep_mode" is incorrect.
- Michael
next prev parent reply other threads:[~2020-09-17 22:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 19:43 [PATCH v14 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP Ben Levinsky
2020-09-17 19:43 ` [PATCH v14 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration Ben Levinsky
2020-09-17 19:43 ` [PATCH v14 2/5] firmware: xilinx: Add shutdown/wakeup APIs Ben Levinsky
2020-09-17 19:43 ` [PATCH v14 3/5] firmware: xilinx: Add RPU configuration APIs Ben Levinsky
2020-09-17 19:43 ` [PATCH v14 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings Ben Levinsky
2020-09-18 6:28 ` Punit Agrawal
2020-09-17 19:43 ` [PATCH v14 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver Ben Levinsky
2020-09-17 22:11 ` Michael Auchter [this message]
2020-09-17 22:18 ` Ben Levinsky
2020-09-17 22:50 ` Ben Levinsky
2020-09-18 16:07 ` Michael Auchter
2020-09-18 18:01 ` Ben Levinsky
2020-09-18 19:06 ` Michael Auchter
2020-09-19 1:53 ` Wendy Liang
2020-09-20 23:16 ` Ben Levinsky
2020-09-21 5:09 ` Wendy Liang
2020-09-21 5:11 ` Wendy Liang
2020-09-21 10:04 ` Punit Agrawal
2020-09-18 16:04 ` Michael Auchter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917221120.GA15530@xaphan \
--to=michael.auchter@ni.com \
--cc=ben.levinsky@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=ed.mooring@xilinx.com \
--cc=emooring@xilinx.com \
--cc=j.wu@xilinx.com \
--cc=jliang@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=michal.simek@xilinx.com \
--cc=michals@xilinx.com \
--cc=punit1.agrawal@toshiba.co.jp \
--cc=robh+dt@kernel.org \
--cc=stefanos@xilinx.com \
--cc=wendy.liang@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).