From: Pavel Machek <pavel@ucw.cz>
To: Alexander Dahl <post@lespocky.de>
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
"Jacek Anaszewski" <jacek.anaszewski@gmail.com>,
"Dan Murphy" <dmurphy@ti.com>, "Rob Herring" <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org,
"Peter Ujfalusi" <peter.ujfalusi@ti.com>,
"Marek Behún" <marek.behun@nic.cz>,
"Alexander Dahl" <ada@thorsis.com>,
"Denis Osterland-Heim" <denis.osterland@diehl.com>
Subject: Re: [PATCH v5 1/3] leds: pwm: Remove platform_data support
Date: Sat, 19 Sep 2020 11:44:18 +0200 [thread overview]
Message-ID: <20200919094418.GC12294@duo.ucw.cz> (raw)
In-Reply-To: <20200919053145.7564-2-post@lespocky.de>
[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]
Hi!
> Since commit 141f15c66d94 ("leds: pwm: remove header") that platform
> interface is not usable from outside and there seems to be no in tree
> user anymore. All in-tree users of the leds-pwm driver seem to use DT
> currently. Getting rid of the old platform interface will allow the
> leds-pwm driver to switch over from 'devm_led_classdev_register()' to
> 'devm_led_classdev_register_ext()' later.
> @@ -61,6 +56,7 @@ static int led_pwm_set(struct led_classdev *led_cdev,
> return pwm_apply_state(led_dat->pwm, &led_dat->pwmstate);
> }
>
> +__attribute__((nonnull))
> static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv,
> struct led_pwm *led, struct fwnode_handle *fwnode)
> {
This normally goes elsewhere -- right? I'd expect:
static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv,
struct led_pwm *led, struct fwnode_handle *fwnode)
__attribute__((nonnull))
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2020-09-19 9:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-19 5:31 [PATCH v5 0/3] leds: pwm: Make automatic labels work Alexander Dahl
2020-09-19 5:31 ` [PATCH v5 1/3] leds: pwm: Remove platform_data support Alexander Dahl
2020-09-19 9:44 ` Pavel Machek [this message]
2020-09-28 11:04 ` Alexander Dahl
2020-09-30 17:24 ` Pavel Machek
2020-09-30 22:57 ` Alexander Dahl
2020-09-19 18:05 ` Marek Behun
2020-09-19 5:31 ` [PATCH v5 2/3] leds: pwm: Allow automatic labels for DT based devices Alexander Dahl
2020-09-19 9:44 ` Pavel Machek
2020-09-19 5:31 ` [PATCH v5 3/3] dt-bindings: leds: Convert pwm to yaml Alexander Dahl
2020-09-22 15:42 ` Rob Herring
2020-09-28 11:19 ` Alexander Dahl
2020-09-28 16:11 ` Rob Herring
2020-09-22 15:57 ` Rob Herring
2020-09-29 7:39 ` Alexander Dahl
2020-09-29 13:58 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200919094418.GC12294@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=ada@thorsis.com \
--cc=denis.osterland@diehl.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=peter.ujfalusi@ti.com \
--cc=post@lespocky.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).