From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BA5CC43464 for ; Mon, 21 Sep 2020 09:59:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4962521BE5 for ; Mon, 21 Sep 2020 09:59:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=beagleboard-org.20150623.gappssmtp.com header.i=@beagleboard-org.20150623.gappssmtp.com header.b="mnoq6BMh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726471AbgIUJ7R (ORCPT ); Mon, 21 Sep 2020 05:59:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726326AbgIUJ7Q (ORCPT ); Mon, 21 Sep 2020 05:59:16 -0400 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55224C061755 for ; Mon, 21 Sep 2020 02:59:16 -0700 (PDT) Received: by mail-ej1-x644.google.com with SMTP id i26so16777046ejb.12 for ; Mon, 21 Sep 2020 02:59:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=sl8uGkOUAXH9GoQjx9V+JkGylxwKYdt19btYfKxLbmw=; b=mnoq6BMhUMKYHNjZLAhOQC5sz2iGfzQxNEvmCunoDgFntNgGc7N1PxAKKBdqnAaFyk cfdOwPpq8pXxnJh/d+BGplVMxlXtQg5cRRr4R97rHYN0w/g7M8k9q/ndCWF5bsntgw5r cgI2vgLNKHnGWQyBjNFkIKZXcFEra3O0awGEIvA/sTpxFWQrKzanm1JwQmDw/u74vRA8 ZNINbJTxS8atLiTnmFpxj+eI6lBUPe7TYseFLMNN8le+1ENVRig0jmgvojBIZUqt4Z1Z ZmUyg/k2STu11/eNalBHkwiXgkeAJQJPdw4hufpBjKXNU5REWPdFkIBhF0LJPoen+M7V VqXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sl8uGkOUAXH9GoQjx9V+JkGylxwKYdt19btYfKxLbmw=; b=CyGup/N/pxZXyhpODCNwJRk2fbaoCr6fs3r3BVfmc1HfO4NxFDGArI982ia68vv6+L OuvnLUp2CYaQwsioHa8dU2PhoCPYhK54MfRWdkOXWHb5F7lWv7VhKpf/dghT50oArOQM 0n7huQV/a9DwAwT+T5aZRc2Z6OOky4zfD3+lmitNSIs2M252VuivQB9tRGjfu/s/qxpS HLPFAkbu2Pv+TptV22OAuad012xTKWCQu20DO13Jv/N4sq2xarSSs+yWZ4PEbpzXj/iP 6N7feieOcbKAR/8jg5vsTVc6Nmb8Q9mE4YBtbUph5VCXTL17z2z4qafCA7y0JiHXyiL3 j2yw== X-Gm-Message-State: AOAM53291qqZVia/n9HXDt+mz+3voH3Olj9M4te2bDDwgKT9IfYilN3f Wi6xyY4Ei+w0c/+f0ThqRsu7vg== X-Google-Smtp-Source: ABdhPJwV2XZWvXBk31Ggd3Mw92swsNCTa+hfyEth2y1cYI1jCOhFVLvWbHjmNeuzBB83LG6KVU/cDw== X-Received: by 2002:a17:906:2e14:: with SMTP id n20mr50204929eji.214.1600682355019; Mon, 21 Sep 2020 02:59:15 -0700 (PDT) Received: from x1 ([2001:16b8:5c50:7f01:652a:68b1:4040:26de]) by smtp.gmail.com with ESMTPSA id i26sm8303203edq.47.2020.09.21.02.59.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2020 02:59:14 -0700 (PDT) Date: Mon, 21 Sep 2020 11:59:12 +0200 From: Drew Fustini To: Tony Lindgren Cc: Rob Herring , Linus Walleij , Jason Kridner , Robert Nelson , Trent Piepho , Christina Quast , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH] ARM: dts: am335x: guardian: switch to AM33XX_PADCONF Message-ID: <20200921095912.GA3752675@x1> References: <20200919195159.3126193-1-drew@beagleboard.org> <20200921064707.GN7101@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200921064707.GN7101@atomide.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Sep 21, 2020 at 09:47:07AM +0300, Tony Lindgren wrote: > * Drew Fustini [200919 19:53]: > > Change the pin defintions from AM33XX_IOPAD to AM33XX_PADCONF macro so > > that it correctly handles changes to #pinctrl-cells. > > Thanks for fixing this. I wonder if we should now also change the define > for the old AM33XX_IOPAD macro? > > Or just remove it completely and mention that we've changed nr-pinctrl-cells > to use 3 now? > > Otherwise the unknown number of out-of-tree boards will be hitting this > too. > Christina Quast commented in f1ff9be7652b ("ARM: dts: am33xx: Added AM33XX_PADCONF macro") that AM33XX_IOPAD() was left in place to avoid breaking boards not in mainline. If we follow that logic, then I think that fixing AM33XX_IOPAD() for #pinctrl-cells = <2> would be the correct solution. Would this be acceptable? #define AM33XX_IOPAD(pa, val) OMAP_IOPAD_OFFSET((pa), 0x0800) (val) (0) thanks, drew