From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C0F2C43466 for ; Mon, 21 Sep 2020 14:31:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 52C8D21D95 for ; Mon, 21 Sep 2020 14:31:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727131AbgIUObL convert rfc822-to-8bit (ORCPT ); Mon, 21 Sep 2020 10:31:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726818AbgIUObL (ORCPT ); Mon, 21 Sep 2020 10:31:11 -0400 Received: from mail.nic.cz (mail.nic.cz [IPv6:2001:1488:800:400::400]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A064C061755; Mon, 21 Sep 2020 07:31:10 -0700 (PDT) Received: from localhost (unknown [IPv6:2a0e:b107:ae1:0:3e97:eff:fe61:c680]) by mail.nic.cz (Postfix) with ESMTPSA id C5D4C1409F6; Mon, 21 Sep 2020 16:31:07 +0200 (CEST) Date: Mon, 21 Sep 2020 16:31:07 +0200 From: Marek Behun To: Simon Guinot Cc: linux-leds@vger.kernel.org, Pavel Machek , Dan Murphy , =?UTF-8?B?T25kxZllag==?= Jirman , linux-kernel@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org, Simon Guinot , Vincent Donnefort , Thomas Petazzoni , Linus Walleij Subject: Re: [PATCH leds v1 10/10] leds: ns2: refactor and use struct led_init_data Message-ID: <20200921163107.205cd219@nic.cz> In-Reply-To: <20200921140322.GB4828@kw.sim.vm.gnt> References: <20200916231650.11484-1-marek.behun@nic.cz> <20200916231650.11484-11-marek.behun@nic.cz> <20200918130206.GE29951@kw.sim.vm.gnt> <20200918191405.516b51ff@nic.cz> <20200921125343.GA4828@kw.sim.vm.gnt> <20200921150208.6a296bc7@nic.cz> <20200921140322.GB4828@kw.sim.vm.gnt> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Virus-Scanned: clamav-milter 0.102.2 at mail X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 21 Sep 2020 16:03:22 +0200 Simon Guinot wrote: > On Mon, Sep 21, 2020 at 03:02:08PM +0200, Marek Behun wrote: > > On Mon, 21 Sep 2020 14:53:43 +0200 > > Simon Guinot wrote: > > > > > On Fri, Sep 18, 2020 at 07:14:05PM +0200, Marek Behun wrote: > > > > On Fri, 18 Sep 2020 15:02:06 +0200 > > > > Simon Guinot wrote: > > > > > > > > > On Thu, Sep 17, 2020 at 01:16:50AM +0200, Marek Behún wrote: > > > > > > > > > > Hi Marek, > > > > > > > > > > > By using struct led_init_data when registering we do not need to parse > > > > > > `label` DT property nor `linux,default-trigger` property. > > > > > > > > > > > > Also, move forward from platform data to device tree only: > > > > > > since commit c7896490dd1a ("leds: ns2: Absorb platform data") the > > > > > > platform data structure is absorbed into the driver, because nothing > > > > > > else in the source tree used it. Since nobody complained and all usage > > > > > > > > > > Well, I probably should have... > > > > > > > > > > I am using this driver on the Seagate Superbee NAS devices. This devices > > > > > are based on a x86 SoC. Since I have been unable to get from the ODM the > > > > > LED information written in the ACPI tables, then platform data are used > > > > > to pass the LED description to the driver. > > > > > > > > > > The support of this boards is not available mainline yet but it is still > > > > > on my todo list. So that's why I am complaining right now :) If it is > > > > > not too much trouble I'd like to keep platform data support in this > > > > > driver. > > > > > > > > > > Thanks in advance. > > > > > > > > > > Simon > > > > > > > > > > > > > Simon, what if we refactored the driver to use fwnode API instead of OF > > > > API? Then if it is impossible for you to write DTS for that device, > > > > instead of platform data you could implement your device via swnode > > > > fwnodes. :) > > > > > > Yes. That would be perfect. > > > > > > Simon > > > > BTW if you have access to device schematics I could try to write DTS, > > with schematics and the current board source file it should not be that > > hard. But I can't test it, since I don't have the board. > > Don't worry, I'll do the writing and the testing of the fwnode in the > x86 board files. This boards are not mainlined yet. So it is my problem. > > And actually if you don't have the time I can do the writing of the > fwnode support in the driver as well. And you can just let the driver > with the OF support. That's fine. > > But if you are willing to add fwnode support to the driver yourself, > then you are more than welcome to do it. On my side, I can help with > the testing. I can check that the ARM boards ant their DTB are still > supported by the driver. And I can also check the support of the x86 > boards with the addition of the fwnode properties. > > Simon Very well, I shall convert the driver to fwnode API and send the patch. Marek