From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3C54C4727D for ; Wed, 23 Sep 2020 06:54:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD6A623600 for ; Wed, 23 Sep 2020 06:54:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726716AbgIWGy1 (ORCPT ); Wed, 23 Sep 2020 02:54:27 -0400 Received: from muru.com ([72.249.23.125]:45114 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726179AbgIWGy0 (ORCPT ); Wed, 23 Sep 2020 02:54:26 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id D420080A0; Wed, 23 Sep 2020 06:54:26 +0000 (UTC) Date: Wed, 23 Sep 2020 09:55:20 +0300 From: Tony Lindgren To: Drew Fustini Cc: linux-arm-kernel@lists.infradead.org, Rob Herring , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Linus Walleij , Haojian Zhuang , devicetree@vger.kernel.org, bcousson@baylibre.com, Jason Kridner , Robert Nelson , Trent Piepho Subject: Re: [PATCH v2] pinctrl: single: fix debug output when #pinctrl-cells = 2 Message-ID: <20200923065520.GP7101@atomide.com> References: <20200913230306.2061645-1-drew@beagleboard.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200913230306.2061645-1-drew@beagleboard.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org * Drew Fustini [200913 23:04]: > The debug output in pcs_parse_one_pinctrl_entry() needs to be updated > to print the correct pinctrl register value when #pinctrl-cells is 2. > > Fixes: a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2") > Reported-by: Trent Piepho > Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/ > Signed-off-by: Drew Fustini > --- > v2 change: > this is a fix to my prior email where I referred to #pinctrl-cells = 3 > which is incorrect. pinctrl_spec.args_count is 3 but #pinctrl-cells = 2 > https://lore.kernel.org/linux-omap/20200913224746.2048603-1-drew@beagleboard.org/ Acked-by: Tony Lindgren > drivers/pinctrl/pinctrl-single.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c > index 5cbf0e55087c..f3cd7e296712 100644 > --- a/drivers/pinctrl/pinctrl-single.c > +++ b/drivers/pinctrl/pinctrl-single.c > @@ -1033,7 +1033,7 @@ static int pcs_parse_one_pinctrl_entry(struct pcs_device *pcs, > } > > dev_dbg(pcs->dev, "%pOFn index: 0x%x value: 0x%x\n", > - pinctrl_spec.np, offset, pinctrl_spec.args[1]); > + pinctrl_spec.np, offset, vals[found].val); > > pin = pcs_get_pin_by_offset(pcs, offset); > if (pin < 0) { > -- > 2.25.1 >