From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5B2FC4363D for ; Wed, 23 Sep 2020 14:04:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 676EB2220D for ; Wed, 23 Sep 2020 14:04:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600869887; bh=cXyRaF1L2ihiN1wJhVwViUjQm7XHbWY8lkRMEV1OWcI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=pun23cfDGI0b6b9HR8jbREfs80abtpITmRuR0RycLKv/lc5bVkV5Zcf8RCd9BXr3y 7vT5BKSKcRu9JUx2Tb3PpvtWwcE3/2bjFY0AeEfiogI9p1nAMvlH0PUL/UbbLbtKZE m3h+6tN7qd5EywKYbYymF7L+wBeuqCLlgd4d1V1g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726526AbgIWOEq (ORCPT ); Wed, 23 Sep 2020 10:04:46 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:37524 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726234AbgIWOEq (ORCPT ); Wed, 23 Sep 2020 10:04:46 -0400 Received: by mail-io1-f67.google.com with SMTP id y13so23812277iow.4; Wed, 23 Sep 2020 07:04:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/2YIbGPyeDVPWPtl7cPgfN2lbTkXGFerVZnaUBAltaA=; b=lj/u2bxYSUABC/FcqNSJwNRXtJ4TCCsRZNr12+oKTFeP0HuRfg0tWAb49ZZ/TCBkGr 68GP+E33mbgazj6cyg69N/mTaSxHo1dEliRyKl4LRfa8OI1GiKhAKLIP5UzLJybBNElK +tY++BC5aCyPfEWiWBQo1EClLKKXKnfEoq2VLcl6Mu5KokBr21ZEFr9UnqduVUPwKFgq TqsTJTrpAip23U+PokXQhnJBRjz/GFnuZh2w1MPBpDcwYHEvieYZWGmxz/Iqs70iXcZl FfyvJLTu4kochBZ8adhSTbOj4DfDCvCkiNtrHX0j4rUNEn9WKkyqHGbqCxFXCCwr6Hrw b2Pw== X-Gm-Message-State: AOAM533Tf+frFlofEzzMxIs8za/cNBKAAJI6COkGRVU81zIQBGoDYtDU 8BKqg7kORgqPUWn3n/4p3g== X-Google-Smtp-Source: ABdhPJxstAEhgQaXKaAuFPlgyAyzZjgHKa6/lnHgGk0H6MXAN1HOfoHNKgPecNsaSTpPJLkpHpfD2A== X-Received: by 2002:a6b:be46:: with SMTP id o67mr7181697iof.133.1600869885401; Wed, 23 Sep 2020 07:04:45 -0700 (PDT) Received: from xps15 ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id l6sm10864315ilt.34.2020.09.23.07.04.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Sep 2020 07:04:44 -0700 (PDT) Received: (nullmailer pid 644635 invoked by uid 1000); Wed, 23 Sep 2020 14:04:43 -0000 Date: Wed, 23 Sep 2020 08:04:43 -0600 From: Rob Herring To: Maxime Chevallier Cc: Mauro Carvalho Chehab , Robin Murphy , Mark Rutland , Heiko Stuebner , Hans Verkuil , Ezequiel Garcia , Helen Koike , Dafna Hirschfeld , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Thomas Petazzoni , Miquel Raynal , Paul Kocialkowski Subject: Re: [PATCH v3 1/3] media: dt-bindings: media: Document Rockchip VIP bindings Message-ID: <20200923140443.GA639013@bogus> References: <20200922165535.1356622-1-maxime.chevallier@bootlin.com> <20200922165535.1356622-2-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200922165535.1356622-2-maxime.chevallier@bootlin.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Sep 22, 2020 at 06:55:33PM +0200, Maxime Chevallier wrote: > Add a documentation for the Rockchip Camera Interface controller > binding. > > This controller can be found on platforms such as the PX30 or the > RK3288, the PX30 being the only platform supported so far. > > Signed-off-by: Maxime Chevallier > --- > V3 : > - renamed the controller > > .../bindings/media/rockchip-vip.yaml | 100 ++++++++++++++++++ > 1 file changed, 100 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/rockchip-vip.yaml > > diff --git a/Documentation/devicetree/bindings/media/rockchip-vip.yaml b/Documentation/devicetree/bindings/media/rockchip-vip.yaml > new file mode 100644 > index 000000000000..652c46053b29 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/rockchip-vip.yaml > @@ -0,0 +1,100 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/rockchip-vip.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip VIP Camera Interface > + > +maintainers: > + - Maxime Chevallier > + > +description: |- > + Camera Interface for Rockcip platforms > + > +properties: > + compatible: > + const: rockchip,px30-vip > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: ACLK > + - description: HCLK > + - description: PCLK IN > + > + clock-names: > + items: > + - const: aclk > + - const: hclkf > + - const: pclkin > + > + resets: > + items: > + - description: AXI > + - description: AHB > + - description: PCLK IN > + > + reset-names: > + items: > + - const: axi > + - const: ahb > + - const: pclkin > + > + power-domains: > + maxItems: 1 > + description: phandle to the associated power domain Drop description. > + > + # See ./video-interfaces.txt for details > + port: > + type: object > + additionalProperties: false Need a description of the data the port represents. > + > + properties: > + endpoint: You can drop 'endpoint' since you don't have any other endpoint properties. > + type: object > + > + properties: > + remote-endpoint: true > + > + required: > + - remote-endpoint > + > + required: > + - endpoint > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks port should be required. > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + > + vip: vip@ff490000 { > + compatible = "rockchip,px30-vip"; > + reg = <0x0 0xff490000 0x0 0x200>; > + interrupts = ; > + clocks = <&cru ACLK_CIF>, <&cru HCLK_CIF>, <&cru PCLK_CIF>, <&cru SCLK_CIF_OUT>; > + clock-names = "aclk", "hclk", "pclkin"; > + resets = <&cru SRST_CIF_A>, <&cru SRST_CIF_H>, <&cru SRST_CIF_PCLKIN>; > + reset-names = "axi", "ahb", "pclkin"; > + power-domains = <&power PX30_PD_VI>; > + port { Some indentation problems here. > + vip_in: endpoint { > + remote-endpoint = <&tw9900_out>; > + }; > + }; > + }; > +... > -- > 2.25.4 >