From: Rob Herring <robh@kernel.org>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>, Ohad Ben-Cohen <ohad@wizery.com>,
Rajendra Nayak <rnayak@codeaurora.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-remoteproc@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 05/10] dt-bindings: remoteproc: qcom,q6v5: Deprecate regulators for PDs
Date: Wed, 23 Sep 2020 09:35:48 -0600 [thread overview]
Message-ID: <20200923153548.GA789614@bogus> (raw)
In-Reply-To: <20200916104135.25085-6-stephan@gerhold.net>
On Wed, Sep 16, 2020 at 12:41:30PM +0200, Stephan Gerhold wrote:
> Newer platforms vote for necessary power domains through the power
> domain subsystem. For historical reasons older platforms like MSM8916
> or MSM8974 still control these as regulators.
Do you plan to change these platforms? If not then I wouldn't really
call this deprecated.
>
> Managing them as power domains is preferred since that allows us
> to vote for corners instead of raw voltages. Document that those
> should be specified as power domains and deprecate using them
> through the regulator interface.
>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> ---
> .../devicetree/bindings/remoteproc/qcom,q6v5.txt | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
> index 1f9a62e13ebe..7ccd5534b0ae 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
> @@ -113,8 +113,8 @@ should be referenced as follows:
> For the compatible strings below the following supplies are required:
> "qcom,q6v5-pil"
> "qcom,msm8916-mss-pil",
> -- cx-supply:
> -- mx-supply:
> +- cx-supply: (deprecated, use power domain instead)
> +- mx-supply: (deprecated, use power domain instead)
> - pll-supply:
> Usage: required
> Value type: <phandle>
> @@ -123,9 +123,9 @@ For the compatible strings below the following supplies are required:
>
> For the compatible string below the following supplies are required:
> "qcom,msm8974-mss-pil"
> -- cx-supply:
> +- cx-supply: (deprecated, use power domain instead)
> - mss-supply:
> -- mx-supply:
> +- mx-supply: (deprecated, use power domain instead)
> - pll-supply:
> Usage: required
> Value type: <phandle>
> @@ -149,11 +149,11 @@ For the compatible string below the following supplies are required:
> Usage: required
> Value type: <stringlist>
> Definition: The power-domains needed depend on the compatible string:
> - qcom,q6v5-pil:
> qcom,ipq8074-wcss-pil:
> + no power-domain names required
> + qcom,q6v5-pil:
> qcom,msm8916-mss-pil:
> qcom,msm8974-mss-pil:
> - no power-domain names required
> qcom,msm8996-mss-pil:
> qcom,msm8998-mss-pil:
> must be "cx", "mx"
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-09-23 15:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 10:41 [PATCH 00/10] Convert MSM8916 to use rpmpd/power domains Stephan Gerhold
2020-09-16 10:41 ` [PATCH 01/10] soc: qcom: rpmpd: Rename MAX_8996_RPMPD_STATE to MAX_CORNER_RPMPD_STATE Stephan Gerhold
2020-09-16 10:41 ` [PATCH 02/10] dt-bindings: power: rpmpd: Add MSM8916 RPM power domains Stephan Gerhold
2020-09-23 15:33 ` Rob Herring
2020-09-16 10:41 ` [PATCH 03/10] soc: qcom: rpmpd: Add MSM8916 " Stephan Gerhold
2020-09-16 10:41 ` [PATCH 04/10] arm64: dts: qcom: msm8916: Add RPM " Stephan Gerhold
2020-09-16 10:41 ` [PATCH 05/10] dt-bindings: remoteproc: qcom,q6v5: Deprecate regulators for PDs Stephan Gerhold
2020-09-23 15:35 ` Rob Herring [this message]
2020-09-23 15:51 ` Stephan Gerhold
2020-09-23 20:02 ` Rob Herring
2020-09-16 10:41 ` [PATCH 06/10] remoteproc: qcom_q6v5_mss: Allow replacing regulators with power domains Stephan Gerhold
2020-09-16 10:41 ` [PATCH 07/10] dt-bindings: remoteproc: qcom,wcnss: Deprecate regulators for PDs Stephan Gerhold
2020-09-16 10:41 ` [PATCH 08/10] remoteproc: qcom_wcnss: Allow replacing regulators with power domains Stephan Gerhold
2020-09-16 10:41 ` [PATCH 09/10] arm64: dts: qcom: msm8916: Use power domains for MSS/WCNSS remoteprocs Stephan Gerhold
2020-09-16 10:41 ` [PATCH 10/10] arm64: dts: qcom: msm8916-pm8916: Stop using s1/l3 as regulators Stephan Gerhold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200923153548.GA789614@bogus \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=rnayak@codeaurora.org \
--cc=stephan@gerhold.net \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).