From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74465C2D0A8 for ; Wed, 23 Sep 2020 16:17:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 21BB220719 for ; Wed, 23 Sep 2020 16:17:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600877836; bh=75Lyfam3hlJioJmti9jBHVI8anRA6q2y68xyvb3Xpyw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Mb7UXhF6ZxosNYovNepr4s10B0AlVS/CeuWuzt/FQZX10y4rKD7+PoT8WwHwPsjnj r8t8GuzmZIfVt2elya31UaJ3rgY3q5Q0exSlxIHyCQV1YHJYp55Jnnz3QkXLKLEuKc r0dwPXw5Xq32bdCBfTO1K8Fs4t6maeQweX4hiJSA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726184AbgIWQRP (ORCPT ); Wed, 23 Sep 2020 12:17:15 -0400 Received: from mail-io1-f53.google.com ([209.85.166.53]:38869 "EHLO mail-io1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726178AbgIWQRP (ORCPT ); Wed, 23 Sep 2020 12:17:15 -0400 Received: by mail-io1-f53.google.com with SMTP id q4so50119iop.5 for ; Wed, 23 Sep 2020 09:17:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6SQ6n7+tg5duNFb+wRc7wNGDsNgiQxy+sYGpkWZIShY=; b=TXie1U8BdrfMWSP15OPJNfohVKme+AbO7hNd96N3ZEcCBGmhJoywVN+frWUxghyovY uVB/JQWQJ4YWCodABe7RA0rEM753LDQz4g9lcAbBXT3YwGB8krFm9R/Q3snrJEkWEpJj yIZ0/UmrpmvFRP9d0kMuaggAP0wMXK0jFzBDoh9NSqW40EPUBd26sRTCiypzQj6Oe1vH 0hvuzk2VbKCsB7aJGEXD4lN3xIXp1Wg2OTfoQMT8pHPcwXdliZ9H4RfPaJ2G6FSHde6v auBo+NoBQirni3TsxdCfQxNA+yBOZ4fG1IexIAcyFIvQTi9KoJ1yQ+3xydg0LeSOUQpM bclg== X-Gm-Message-State: AOAM5312Dfxq0pjL/MYAxcGyNMZl3SZbJcg/28QF6dPcoQ9EaPP21SSG 7SutytQ5wvGBorKoN8wFug== X-Google-Smtp-Source: ABdhPJxpYKAVLagbR20YcNbcHw7nZz6VjjRgsGsDe9UV6plLdrV55DxVoaEKsTiCzT32smc1BAriTg== X-Received: by 2002:a02:a1d0:: with SMTP id o16mr113440jah.141.1600877834276; Wed, 23 Sep 2020 09:17:14 -0700 (PDT) Received: from xps15 ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id v14sm156295iol.17.2020.09.23.09.17.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Sep 2020 09:17:13 -0700 (PDT) Received: (nullmailer pid 857808 invoked by uid 1000); Wed, 23 Sep 2020 16:17:12 -0000 Date: Wed, 23 Sep 2020 10:17:12 -0600 From: Rob Herring To: Tomi Valkeinen Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, David Airlie , Daniel Vetter , Laurent Pinchart , Andrzej Hajda , Neil Armstrong , Swapnil Kashinath Jakhade Subject: Re: [PATCHv2] dt-bindings: dp-connector: add binding for DisplayPort connector Message-ID: <20200923161712.GA836725@bogus> References: <20200917055210.22868-1-tomi.valkeinen@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200917055210.22868-1-tomi.valkeinen@ti.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Sep 17, 2020 at 08:52:10AM +0300, Tomi Valkeinen wrote: > Add binding for DisplayPort connector. A few notes: > > * Similar to hdmi-connector, it has hpd-gpios as an optional property, > as the HPD could also be handled by, e.g., the DP bridge. > > * dp-pwr-supply, which provides 3.3V on DP_PWR pin, is optional, as it > is not strictly required: standard DP cables do not even have the pin > connected. > > * Connector type. Full size and mini connectors are identical except for > the connector size and form, so I believe there is no functional need > for this property. But similar to 'label' property, it might be used > to present information about the connector to the userspace. > > * No eDP. There's really no "eDP connector", as it's always a custom > made connection between the DP and the DP panel. So possibly there is > no need for edp-connector binding, but even if there is, I don't want > to guess what it could look like, and could it be part of the > dp-connector binding. I don't think that's true. Do an image search for 'edp pinout'. AFAICT, there's 2 lane 30 pin and 4 lane 40 pin. One image says 'Table 5-3 in eDP v1.2'. Of course, I'm sure there's custom ones too. From a binding perspective, we probably don't care about the differences, but just need to be able to describe HPD, backlight power, enable, and pwm, and LCD power. That said, it's fine to not handle eDP here. > > * No DP++. I'm not familiar with DP++, but I think it's all handled by > the DP bridge, and does not need any new properties to the dp-connector. > > Signed-off-by: Tomi Valkeinen > --- > > Changes in v2: Add connector type. > > > .../display/connector/dp-connector.yaml | 55 +++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/connector/dp-connector.yaml > > diff --git a/Documentation/devicetree/bindings/display/connector/dp-connector.yaml b/Documentation/devicetree/bindings/display/connector/dp-connector.yaml > new file mode 100644 > index 000000000000..b5fc3e52899e > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/connector/dp-connector.yaml > @@ -0,0 +1,55 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/connector/dp-connector.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: DisplayPort Connector > + > +maintainers: > + - Tomi Valkeinen > + > +properties: > + compatible: > + const: dp-connector > + > + label: true > + > + type: > + enum: > + - full-size > + - mini > + > + hpd-gpios: > + description: A GPIO line connected to HPD > + maxItems: 1 > + > + dp-pwr-supply: > + description: Power supply for the DP_PWR pin > + maxItems: 1 > + > + port: > + description: Connection to controller providing DP signals > + > +required: > + - compatible > + - type > + - port > + > +additionalProperties: false > + > +examples: > + - | > + connector { > + compatible = "dp-connector"; > + label = "dp0"; > + type = "full-size"; > + > + port { > + dp_connector_in: endpoint { > + remote-endpoint = <&dp_out>; > + }; > + }; > + }; > + > +... > -- > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki >