From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F530C2D0A8 for ; Wed, 23 Sep 2020 20:30:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A9B2220936 for ; Wed, 23 Sep 2020 20:30:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600893011; bh=VFt0QGlLC4JdNe56HCe3yLNw1WFqyjSGboXsrkjTu2A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=i3684iQ9Hfn1dXgegmmcNMELsLblsJmrqK+uDsm1BmXoeYnVHbxkFmNHcD+ocRKCg on7P8eo79OUqtxEUDD0zPR9o8T3P9ywTFqiHQ3uFtpQZi3gTrOrYmU41r9XLO0Hwdg CgPC0SgMuGmgNw1PVefIKsiQ4+9EGvh4rojbO0Qs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726381AbgIWUaL (ORCPT ); Wed, 23 Sep 2020 16:30:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:33406 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726199AbgIWUaL (ORCPT ); Wed, 23 Sep 2020 16:30:11 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6A8BA20725; Wed, 23 Sep 2020 20:30:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600893010; bh=VFt0QGlLC4JdNe56HCe3yLNw1WFqyjSGboXsrkjTu2A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=g2E326OL36gqvuk70ilnK5/sia8uzoNgXBR3rxA8oU2nUw9Xa3ZlBAZpc1nrxyuA0 ciXE0dRugCVi6GTUFPuvzWrPRB7dpJZGgcn74GB2V7MI6R6L9sQe3H8lkb7OG/Bc9T J9nFLKpuKorqSC8SyiV05ZhSZceA8N6OMt89FgCo= Date: Wed, 23 Sep 2020 21:30:05 +0100 From: Jonathan Cameron To: Michael Auchter Cc: j.lamorie@rocketlab.co.nz, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Rob Herring , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] dt-bindings: iio: adc: ad7291: add binding Message-ID: <20200923213005.1e52efc9@archlinux> In-Reply-To: <20200922144422.542669-2-michael.auchter@ni.com> References: <20200922144422.542669-1-michael.auchter@ni.com> <20200922144422.542669-2-michael.auchter@ni.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 22 Sep 2020 09:44:21 -0500 Michael Auchter wrote: > Add device-tree binding for ADI AD7291 ADC. > > Signed-off-by: Michael Auchter > Reviewed-by: Rob Herring Hi Michael, I tweaked this a bit whilst applying as below. Hope that's fine with you. Let me know if not. Applied series to the togreg branch of iio.git and pushed out as testing. I'm not sure if this will make 5.10 or not as we are rather tight for a final IIO pull request. Thanks, Jonathan > --- > .../bindings/iio/adc/adi,ad7291.yaml | 50 +++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7291.yaml > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7291.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7291.yaml > new file mode 100644 > index 000000000000..93aa29413049 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7291.yaml > @@ -0,0 +1,50 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/adi,ad7291.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: AD7291 8-Channel, I2C, 12-Bit SAR ADC with Temperature Sensor > + > +maintainers: > + - Michael Auchter > + > +description: | > + Analog Devices AD7291 8-Channel I2C 12-Bit SAR ADC with Temperature Sensor > + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7291.pdf > + > +properties: > + compatible: > + enum: > + - adi,ad7291 > + > + reg: > + maxItems: 1 > + > + vref-supply: > + description: | > + The regulator supply for ADC reference voltage. > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 These two don't need to be here. > + > +required: > + - compatible > + - reg additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ad7291: adc@0 { > + compatible = "adi,ad7291"; > + reg = <0>; > + vref-supply = <&adc_vref>; > + }; > + }; > + ... added and empty blank line removed.