* [PATCH] ARM: dts: cros-ec-keyboard: Add alternate keymap for KEY_LEFTMETA
@ 2020-09-25 16:26 Stephen Boyd
2020-09-25 17:50 ` Doug Anderson
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Stephen Boyd @ 2020-09-25 16:26 UTC (permalink / raw)
To: Benson Leung, Enric Balletbo i Serra
Cc: linux-kernel, devicetree, linux-arm-kernel, Douglas Anderson
On newer keyboards this key is in a different place. Add both options to
the keymap so that both new and old keyboards work.
Cc: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
arch/arm/boot/dts/cros-ec-keyboard.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/cros-ec-keyboard.dtsi b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
index 4a0c1037fbc0..165c5bcd510e 100644
--- a/arch/arm/boot/dts/cros-ec-keyboard.dtsi
+++ b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
@@ -46,6 +46,7 @@ MATRIX_KEY(0x02, 0x08, KEY_LEFTBRACE)
MATRIX_KEY(0x02, 0x09, KEY_F8)
MATRIX_KEY(0x02, 0x0a, KEY_YEN)
+ MATRIX_KEY(0x03, 0x00, KEY_LEFTMETA)
MATRIX_KEY(0x03, 0x01, KEY_GRAVE)
MATRIX_KEY(0x03, 0x02, KEY_F2)
MATRIX_KEY(0x03, 0x03, KEY_5)
--
Sent by a computer, using git, on the internet
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: cros-ec-keyboard: Add alternate keymap for KEY_LEFTMETA
2020-09-25 16:26 [PATCH] ARM: dts: cros-ec-keyboard: Add alternate keymap for KEY_LEFTMETA Stephen Boyd
@ 2020-09-25 17:50 ` Doug Anderson
2020-09-29 8:04 ` Enric Balletbo i Serra
2020-10-06 14:35 ` Enric Balletbo i Serra
2 siblings, 0 replies; 6+ messages in thread
From: Doug Anderson @ 2020-09-25 17:50 UTC (permalink / raw)
To: Stephen Boyd
Cc: Benson Leung, Enric Balletbo i Serra, LKML,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux ARM
Hi,
On Fri, Sep 25, 2020 at 9:26 AM Stephen Boyd <swboyd@chromium.org> wrote:
>
> On newer keyboards this key is in a different place. Add both options to
> the keymap so that both new and old keyboards work.
>
> Cc: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
> arch/arm/boot/dts/cros-ec-keyboard.dtsi | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: cros-ec-keyboard: Add alternate keymap for KEY_LEFTMETA
2020-09-25 16:26 [PATCH] ARM: dts: cros-ec-keyboard: Add alternate keymap for KEY_LEFTMETA Stephen Boyd
2020-09-25 17:50 ` Doug Anderson
@ 2020-09-29 8:04 ` Enric Balletbo i Serra
2020-09-29 13:09 ` Heiko Stübner
2020-09-30 10:44 ` Matthias Brugger
2020-10-06 14:35 ` Enric Balletbo i Serra
2 siblings, 2 replies; 6+ messages in thread
From: Enric Balletbo i Serra @ 2020-09-29 8:04 UTC (permalink / raw)
To: Stephen Boyd, Benson Leung
Cc: Heiko Stuebner, devicetree, linux-arm-kernel, Douglas Anderson,
Matthias Brugger
Hi Stephen,
Thank you for your patch.
cc'ing Heiko and Matthias
On 25/9/20 18:26, Stephen Boyd wrote:
> On newer keyboards this key is in a different place. Add both options to
> the keymap so that both new and old keyboards work.
>
> Cc: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Usually the DT changes go through the Rockchip dts or Mediatek dts tree, this is
not a specific Rockchip/Mediatek change but for both. Are you fine If I pick the
patch through the chrome-platform tree? I don't think there is any conflict.
Thanks,
Enric
> ---
> arch/arm/boot/dts/cros-ec-keyboard.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/cros-ec-keyboard.dtsi b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
> index 4a0c1037fbc0..165c5bcd510e 100644
> --- a/arch/arm/boot/dts/cros-ec-keyboard.dtsi
> +++ b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
> @@ -46,6 +46,7 @@ MATRIX_KEY(0x02, 0x08, KEY_LEFTBRACE)
> MATRIX_KEY(0x02, 0x09, KEY_F8)
> MATRIX_KEY(0x02, 0x0a, KEY_YEN)
>
> + MATRIX_KEY(0x03, 0x00, KEY_LEFTMETA)
> MATRIX_KEY(0x03, 0x01, KEY_GRAVE)
> MATRIX_KEY(0x03, 0x02, KEY_F2)
> MATRIX_KEY(0x03, 0x03, KEY_5)
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: cros-ec-keyboard: Add alternate keymap for KEY_LEFTMETA
2020-09-29 8:04 ` Enric Balletbo i Serra
@ 2020-09-29 13:09 ` Heiko Stübner
2020-09-30 10:44 ` Matthias Brugger
1 sibling, 0 replies; 6+ messages in thread
From: Heiko Stübner @ 2020-09-29 13:09 UTC (permalink / raw)
To: Stephen Boyd, Benson Leung, Enric Balletbo i Serra
Cc: devicetree, linux-arm-kernel, Douglas Anderson, Matthias Brugger
Am Dienstag, 29. September 2020, 10:04:45 CEST schrieb Enric Balletbo i Serra:
> Hi Stephen,
>
> Thank you for your patch.
>
> cc'ing Heiko and Matthias
>
> On 25/9/20 18:26, Stephen Boyd wrote:
> > On newer keyboards this key is in a different place. Add both options to
> > the keymap so that both new and old keyboards work.
> >
> > Cc: Douglas Anderson <dianders@chromium.org>
> > Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>
> Usually the DT changes go through the Rockchip dts or Mediatek dts tree, this is
> not a specific Rockchip/Mediatek change but for both. Are you fine If I pick the
> patch through the chrome-platform tree? I don't think there is any conflict.
So from me, sure go ahead with picking this patch :-)
Heiko
> > ---
> > arch/arm/boot/dts/cros-ec-keyboard.dtsi | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/boot/dts/cros-ec-keyboard.dtsi b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
> > index 4a0c1037fbc0..165c5bcd510e 100644
> > --- a/arch/arm/boot/dts/cros-ec-keyboard.dtsi
> > +++ b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
> > @@ -46,6 +46,7 @@ MATRIX_KEY(0x02, 0x08, KEY_LEFTBRACE)
> > MATRIX_KEY(0x02, 0x09, KEY_F8)
> > MATRIX_KEY(0x02, 0x0a, KEY_YEN)
> >
> > + MATRIX_KEY(0x03, 0x00, KEY_LEFTMETA)
> > MATRIX_KEY(0x03, 0x01, KEY_GRAVE)
> > MATRIX_KEY(0x03, 0x02, KEY_F2)
> > MATRIX_KEY(0x03, 0x03, KEY_5)
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: cros-ec-keyboard: Add alternate keymap for KEY_LEFTMETA
2020-09-29 8:04 ` Enric Balletbo i Serra
2020-09-29 13:09 ` Heiko Stübner
@ 2020-09-30 10:44 ` Matthias Brugger
1 sibling, 0 replies; 6+ messages in thread
From: Matthias Brugger @ 2020-09-30 10:44 UTC (permalink / raw)
To: Enric Balletbo i Serra, Stephen Boyd, Benson Leung
Cc: Heiko Stuebner, devicetree, linux-arm-kernel, Douglas Anderson
On 29/09/2020 10:04, Enric Balletbo i Serra wrote:
> Hi Stephen,
>
> Thank you for your patch.
>
> cc'ing Heiko and Matthias
>
> On 25/9/20 18:26, Stephen Boyd wrote:
>> On newer keyboards this key is in a different place. Add both options to
>> the keymap so that both new and old keyboards work.
>>
>> Cc: Douglas Anderson <dianders@chromium.org>
>> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> Usually the DT changes go through the Rockchip dts or Mediatek dts tree, this is
> not a specific Rockchip/Mediatek change but for both. Are you fine If I pick the
> patch through the chrome-platform tree? I don't think there is any conflict.
>
Please go ahead and take the patch through your tree.
Regards,
Matthias
> Thanks,
> Enric
>
>> ---
>> arch/arm/boot/dts/cros-ec-keyboard.dtsi | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/boot/dts/cros-ec-keyboard.dtsi b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
>> index 4a0c1037fbc0..165c5bcd510e 100644
>> --- a/arch/arm/boot/dts/cros-ec-keyboard.dtsi
>> +++ b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
>> @@ -46,6 +46,7 @@ MATRIX_KEY(0x02, 0x08, KEY_LEFTBRACE)
>> MATRIX_KEY(0x02, 0x09, KEY_F8)
>> MATRIX_KEY(0x02, 0x0a, KEY_YEN)
>>
>> + MATRIX_KEY(0x03, 0x00, KEY_LEFTMETA)
>> MATRIX_KEY(0x03, 0x01, KEY_GRAVE)
>> MATRIX_KEY(0x03, 0x02, KEY_F2)
>> MATRIX_KEY(0x03, 0x03, KEY_5)
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: cros-ec-keyboard: Add alternate keymap for KEY_LEFTMETA
2020-09-25 16:26 [PATCH] ARM: dts: cros-ec-keyboard: Add alternate keymap for KEY_LEFTMETA Stephen Boyd
2020-09-25 17:50 ` Doug Anderson
2020-09-29 8:04 ` Enric Balletbo i Serra
@ 2020-10-06 14:35 ` Enric Balletbo i Serra
2 siblings, 0 replies; 6+ messages in thread
From: Enric Balletbo i Serra @ 2020-10-06 14:35 UTC (permalink / raw)
To: Stephen Boyd, Benson Leung
Cc: linux-kernel, devicetree, linux-arm-kernel, Douglas Anderson
Hi Stephen,
On 25/9/20 18:26, Stephen Boyd wrote:
> On newer keyboards this key is in a different place. Add both options to
> the keymap so that both new and old keyboards work.
>
> Cc: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
Queued for 5.10.
Thanks,
Enric
> arch/arm/boot/dts/cros-ec-keyboard.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/cros-ec-keyboard.dtsi b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
> index 4a0c1037fbc0..165c5bcd510e 100644
> --- a/arch/arm/boot/dts/cros-ec-keyboard.dtsi
> +++ b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
> @@ -46,6 +46,7 @@ MATRIX_KEY(0x02, 0x08, KEY_LEFTBRACE)
> MATRIX_KEY(0x02, 0x09, KEY_F8)
> MATRIX_KEY(0x02, 0x0a, KEY_YEN)
>
> + MATRIX_KEY(0x03, 0x00, KEY_LEFTMETA)
> MATRIX_KEY(0x03, 0x01, KEY_GRAVE)
> MATRIX_KEY(0x03, 0x02, KEY_F2)
> MATRIX_KEY(0x03, 0x03, KEY_5)
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-10-06 14:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-25 16:26 [PATCH] ARM: dts: cros-ec-keyboard: Add alternate keymap for KEY_LEFTMETA Stephen Boyd
2020-09-25 17:50 ` Doug Anderson
2020-09-29 8:04 ` Enric Balletbo i Serra
2020-09-29 13:09 ` Heiko Stübner
2020-09-30 10:44 ` Matthias Brugger
2020-10-06 14:35 ` Enric Balletbo i Serra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).