From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DCEEC4727E for ; Mon, 28 Sep 2020 16:28:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 34FF1214D8 for ; Mon, 28 Sep 2020 16:28:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ud3QJS0L" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726485AbgI1Q2m (ORCPT ); Mon, 28 Sep 2020 12:28:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726477AbgI1Q2m (ORCPT ); Mon, 28 Sep 2020 12:28:42 -0400 Received: from mail-oi1-x244.google.com (mail-oi1-x244.google.com [IPv6:2607:f8b0:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2348C061755; Mon, 28 Sep 2020 09:28:41 -0700 (PDT) Received: by mail-oi1-x244.google.com with SMTP id 185so1947234oie.11; Mon, 28 Sep 2020 09:28:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6DkxvUBNgBtFpav9mYjrKFIEaWiPqfm8HmcCJgLtJXc=; b=Ud3QJS0LcwsuzzN7Wj8mFvl+jXGUi2TB9DDZgdvJClXa97RQgojJaYWjhnKZANTWu4 ddBRE5jnoHC526IIBjP80lVQZC9pzl46t8EWe0QvMNgcy1n9xm2h0Eg6dfQDWgmME17O lFboR1D7L59uHT9Jtpv9yTFEqmXfeaUVqJyKu8cCOQFSLEWFU9unULFH66R4bweztblP Gh5bx3NGnOUFLuBMU4zUUz0Vi4HV+RTXeEizk8BQEP7EJuic79Xdzyj5wfsFz9GxEs9H zZa0HDKw3Xef9zPbTsxrUFeSiNMiAoqk63cqtFSNe/OcT1DSw/EM7kOXNzCTD1s3M/cj KApw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=6DkxvUBNgBtFpav9mYjrKFIEaWiPqfm8HmcCJgLtJXc=; b=IXf8m8sWB95f41Iv3Q6F5U/JOW7+YueCCuYZJ+q50/Ad9bgUSYVvvo+26+XfDgUWX7 0YfJHLg72NVkmLD+yd3i0IjpraHtbjq69sHbt8IEvYpt4N5jfmj3kZOkQyFq3sZ1RD/G VkCjDyB+tyCARPlk/YpjnOiIsJ/dlsRgw3J8QsfOl+Sz6g0rqLKKoHWGNkBJ+sozp9uv Z4tcttMryB42jKKrbbbiOcO0w9Ui0dikiZ+Otj4/Q6seRR7EPivbUq0iZjA5yWpFbP2u dKWRSQU99K4tslNrJbCXNWae7uXTLV2duKk52fJq4x8npKumtMCE+Osi9RrNGavPkeiH x+dg== X-Gm-Message-State: AOAM533WrLboj9AMFc3957IKGkLEXinkm+lD+TTW9J8yUAI02KV6cyA+ +hI6rZfNXLmrBg0ycrJFbYU= X-Google-Smtp-Source: ABdhPJzWLEM4irtaNpR9OSDAn5CowIdeZ46FMAKT4VfxCVRtD0ZCTqiOQvbLK4Qjv0NcuLJmttmfpQ== X-Received: by 2002:a05:6808:54:: with SMTP id v20mr1333075oic.50.1601310521310; Mon, 28 Sep 2020 09:28:41 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id u68sm352911otb.9.2020.09.28.09.28.40 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Sep 2020 09:28:40 -0700 (PDT) Sender: Guenter Roeck Date: Mon, 28 Sep 2020 09:28:39 -0700 From: Guenter Roeck To: Biwen Li Cc: jdelvare@suse.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Reinhard Pfau , Biwen Li Subject: Re: [PATCH] hwmon: add support for SMSC EMC2305/03/02/01 fan controller Message-ID: <20200928162839.GB106276@roeck-us.net> References: <20200928104326.40386-1-biwen.li@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200928104326.40386-1-biwen.li@oss.nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Sep 28, 2020 at 06:43:26PM +0800, Biwen Li wrote: > From: Reinhard Pfau > > Add support for SMSC EMC2305, EMC2303, EMC2302, EMC2301 fan controller > chips. > The driver primary supports the EMC2305 chip which provides RPM-based > PWM control and monitoring for up to 5 fans. > > According to the SMSC data sheets the EMC2303, EMC2302 and EMC2301 chips > have basically the same functionality and register layout, but support > less fans and (in case of EMC2302 and EMC2301) less possible I2C addresses. > The driver supports them, too. > > The driver supports configuration via devicetree. This can also be used > to restrict the fans exposed via sysfs (see doc for details). > > Signed-off-by: Reinhard Pfau > Signed-off-by: Biwen Li > --- ... > + > + hwmon_dev = devm_hwmon_device_register_with_groups(&client->dev, > + client->name, data, > + data->groups); New drivers must use "[devm_]hwmon_device_register_with_info" to register with the hwmon subsystem. Guenter