From: Rob Herring <robh@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Frank Rowand <frowand.list@gmail.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
kernel@pengutronix.de, devicetree@vger.kernel.org
Subject: Re: [PATCH] scripts/dtc: only append to HOST_EXTRACFLAGS instead of overwriting
Date: Mon, 28 Sep 2020 12:20:11 -0500 [thread overview]
Message-ID: <20200928172011.GA2922882@bogus> (raw)
In-Reply-To: <20200919143922.22793-1-u.kleine-koenig@pengutronix.de>
On Sat, Sep 19, 2020 at 04:39:22PM +0200, Uwe Kleine-König wrote:
> When building with
>
> $ HOST_EXTRACFLAGS=-g make
>
> the expectation is that host tools are built with debug informations.
> This however doesn't happen if the Makefile assigns a new value to the
> HOST_EXTRACFLAGS instead of appending to it. So use += instead of := for
> the first assignment.
>
> Fixes: e3fd9b5384f3 ("scripts/dtc: consolidate include path options in Makefile")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> this is a resend as I failed to add the devicetree mailing list to Cc
> for the first mail :-\ Thanks to Rob for reminding me. Those who got
> this mail twice and want to reply please make sure you reply to the
> right (i.e. this) mail.
>
> The patch is the same as my earlier patch "scripts/dtc: Don't overwrite
> HOST_EXTRACFLAGS passed on command line" but here the commit log is not
> wrong.
>
> Thanks and sorry,
> Uwe
>
> scripts/dtc/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Rob
next prev parent reply other threads:[~2020-09-28 17:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 9:40 [PATCH] scripts/dtc: Don't overwrite HOST_EXTRACFLAGS passed on command line Uwe Kleine-König
2020-09-17 10:15 ` Uwe Kleine-König
2020-09-19 14:39 ` [PATCH] scripts/dtc: only append to HOST_EXTRACFLAGS instead of overwriting Uwe Kleine-König
2020-09-28 17:20 ` Rob Herring [this message]
2020-10-16 7:04 ` Masahiro Yamada
2020-10-16 14:30 ` Rob Herring
2020-10-17 21:24 ` Uwe Kleine-König
2020-10-19 14:35 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928172011.GA2922882@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=kernel@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).