From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jacky Bai <ping.bai@nxp.com>
Cc: shawnguo@kernel.org, robh+dt@kernel.org, s.hauer@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: freescale: Add imx8mn ddr3l evk board support
Date: Tue, 29 Sep 2020 09:54:54 +0200 [thread overview]
Message-ID: <20200929075454.GB7139@kozik-lap> (raw)
In-Reply-To: <20200927094124.2714390-2-ping.bai@nxp.com>
On Sun, Sep 27, 2020 at 05:41:24PM +0800, Jacky Bai wrote:
> For i.MX8MN DDR3L EVK board, it populates with the 11x11 package
> with no GPU, no display module compared to 14x14 package. For
> the board design, it is same as LPDDR4 board except that the
> display related interface is removed.
>
> Signed-off-by: Jacky Bai <ping.bai@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/Makefile | 1 +
> arch/arm64/boot/dts/freescale/imx8mn-ddr3l-evk.dts | 11 +++++++++++
> 2 files changed, 12 insertions(+)
> create mode 100644 arch/arm64/boot/dts/freescale/imx8mn-ddr3l-evk.dts
>
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index f8d59433af01..4edcbd920a8f 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
> +dtb-$(CONFIG_ARCH_MXC) += imx8mn-ddr3l-evk.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mn-ddr4-evk.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mn-var-som-symphony.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-ddr3l-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-ddr3l-evk.dts
> new file mode 100644
> index 000000000000..854cb3a525f0
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-ddr3l-evk.dts
> @@ -0,0 +1,11 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> + /*
> + * Copyright 2020 NXP
> + */
> +
> +#include "imx8mn-evk.dts"
This should be an include of shared DTSI. You could avoid
splitting/renaming if you started with DTSI at beginning, knowing that
there will be multiple boards like that, with only minor differences.
> +
> +/ {
> + model = "NXP i.MX8MNano DDR3L EVK board";
NXP advertises it as "i.MX 8M Nano" (with spaces).
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-09-29 7:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 9:41 [PATCH 1/2] dt-bindings: arm: fsl: Add imx8mn ddr3l evk board Jacky Bai
2020-09-27 9:41 ` [PATCH 2/2] arm64: dts: freescale: Add imx8mn ddr3l evk board support Jacky Bai
2020-09-29 7:54 ` Krzysztof Kozlowski [this message]
2020-09-29 7:50 ` [PATCH 1/2] dt-bindings: arm: fsl: Add imx8mn ddr3l evk board Krzysztof Kozlowski
2020-09-29 19:21 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929075454.GB7139@kozik-lap \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=linux-imx@nxp.com \
--cc=ping.bai@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).