From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 354C0C4346E for ; Tue, 29 Sep 2020 09:47:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E71C720936 for ; Tue, 29 Sep 2020 09:47:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NOW8WOxt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728107AbgI2JrC (ORCPT ); Tue, 29 Sep 2020 05:47:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725765AbgI2JrC (ORCPT ); Tue, 29 Sep 2020 05:47:02 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D70D6C0613D0 for ; Tue, 29 Sep 2020 02:47:01 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id z1so4635478wrt.3 for ; Tue, 29 Sep 2020 02:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Xgu+t4c0Hj/GvcOVJdD7iwVpZkR4c7q5e85qV1kBjNo=; b=NOW8WOxtXjyauKTcGXQNShd+/NM0gPC9MrygYedOz5v41mrfSXbNUNmdQfME8QDtvO f3jSB+rhaRY5W2z8QdLK51GueF373dNTEapV4x8ijeTdbjuXS7TENVmJHckAbNrP6Ggo /6yV+RFR1KKo1mIpPBslUDmJ2C887+oSC5ZyYVvHLgMetOQ5XOLTJbWak2Qx1Sp38Ixf UEv4X82/ARW2YE1S6kkP7Pb4cLXGQDuk2YiViBGqQTk0hIKsVlxcffYPpTLnbFIEnGXD qvxQ4MyNmiumjCNW3d5+TYBVrABi0v+xJPjbJTp6CdEi5IYnZHw8t5nCUnzTI2T0Z6Ug 0jXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Xgu+t4c0Hj/GvcOVJdD7iwVpZkR4c7q5e85qV1kBjNo=; b=THFn0/mGScJtRCT1puJJR2lQUn19nP3kyMeMm3DXC5I4VeFiAB0fVt7epsF7MUU5BR JSeIOXHs9oiFChbSAla8e03CD6ZVxH6NfKWIfAYN/8R0kdRgE1TnEpgnEo1XkV1LkEru YqK+88OaXMQgEffb/5EgK+Mmevt7WHWbybCVPw/GNkH0yZMB5ws11ud3pQp5ECTDrk5+ Q7c3bcmDvqMiERQ8qfwCgL1eT7qP7CCbjLf8akcSx714hB5cZ+frm/P4GOpBncXw4DnP oMD03nolGocT+/HipH/ILbahzrT2vVYCNuV6rkt0QMGr6Or4oNes2C8YrREUSgnlwG33 6VoQ== X-Gm-Message-State: AOAM533plURIo4IEJuR4gsFrE05W7Kn76ZDPWyjjxaXRn8NFclNnrVky PKt6BbN5+GIHY8xUbnUz/gomnw== X-Google-Smtp-Source: ABdhPJxXEep7SF9Qpk4Znubq9FBmlxsqdwPUuDmXdWiZ+hVgqT1yyNneHvGay0XQFwJsamVSunbhtA== X-Received: by 2002:adf:f207:: with SMTP id p7mr3523229wro.152.1601372820224; Tue, 29 Sep 2020 02:47:00 -0700 (PDT) Received: from dell ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id u186sm4763822wmu.34.2020.09.29.02.46.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Sep 2020 02:46:59 -0700 (PDT) Date: Tue, 29 Sep 2020 10:46:57 +0100 From: Lee Jones To: Krzysztof Kozlowski Cc: Rob Herring , Tim Harvey , Robert Jones , Matti Vaittinen , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-power@fi.rohmeurope.com Subject: Re: [PATCH v2] dt-bindings: mfd: correct interrupt flags in examples Message-ID: <20200929094657.GD6148@dell> References: <20200917185613.5905-1-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200917185613.5905-1-krzk@kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 17 Sep 2020, Krzysztof Kozlowski wrote: > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. > These are simple defines so they could be used in DTS but they will not > have the same meaning: > 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE > 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING > > Correct the interrupt flags, assuming the author of the code wanted same > logical behavior behind the name "ACTIVE_xxx", this is: > ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW > > Signed-off-by: Krzysztof Kozlowski > Acked-by: Matti Vaittinen # for BD70528 > Acked-by: Tim Harvey # for gateworks-gsc.yaml > Acked-by: Rob Herring > > --- > > Changes since v1: > 1. Add acks FYI, this should not bump the patch version. > --- > Documentation/devicetree/bindings/mfd/act8945a.txt | 2 +- > Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml | 3 ++- > Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt | 2 +- > 3 files changed, 4 insertions(+), 3 deletions(-) -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog