From: Krzysztof Kozlowski <krzk@kernel.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Tim Harvey <tharvey@gateworks.com>,
Robert Jones <rjones@gateworks.com>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-power@fi.rohmeurope.com
Subject: Re: [PATCH v2] dt-bindings: mfd: correct interrupt flags in examples
Date: Tue, 29 Sep 2020 11:53:07 +0200 [thread overview]
Message-ID: <20200929095307.GB11333@kozik-lap> (raw)
In-Reply-To: <20200929094657.GD6148@dell>
On Tue, Sep 29, 2020 at 10:46:57AM +0100, Lee Jones wrote:
> On Thu, 17 Sep 2020, Krzysztof Kozlowski wrote:
>
> > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
> > These are simple defines so they could be used in DTS but they will not
> > have the same meaning:
> > 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
> > 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING
> >
> > Correct the interrupt flags, assuming the author of the code wanted same
> > logical behavior behind the name "ACTIVE_xxx", this is:
> > ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > Acked-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> # for BD70528
> > Acked-by: Tim Harvey <tharvey@gateworks.com> # for gateworks-gsc.yaml
> > Acked-by: Rob Herring <robh@kernel.org>
> >
> > ---
> >
> > Changes since v1:
> > 1. Add acks
>
> FYI, this should not bump the patch version.
Yes, that was my mistake. I kept this one with multiple other similar
patches and was updating all of them.... but I sent each group
independently at the end so this one did not receive any updates
actually.
Best regards,
Krzysztof
prev parent reply other threads:[~2020-09-29 9:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 18:56 [PATCH v2] dt-bindings: mfd: correct interrupt flags in examples Krzysztof Kozlowski
2020-09-29 9:46 ` Lee Jones
2020-09-29 9:46 ` Lee Jones
2020-09-29 9:53 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929095307.GB11333@kozik-lap \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-power@fi.rohmeurope.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=rjones@gateworks.com \
--cc=robh+dt@kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox