From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 484EEC4741F for ; Tue, 29 Sep 2020 18:08:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE73221734 for ; Tue, 29 Sep 2020 18:08:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601402898; bh=wXvCEepI9+aZJ8EJ8slP1Ffv2YP2KiEBhk14LbhK6Co=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=QIBcX+P4F6cQbbb9sLbHnkJTuFOgJFDzYsQYMsGKRKljdssu/WvLJYg7q0fh3gveZ X3x7gXOGgr2bFqDq8LLpUE0e1kGEUKOEe3EEvWC2lFCX9hjin21Np6+aaARoJ0euIB Md4DXh1hG20MUbVMqyusGFAq5GcEHCju+Jpm+OX4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728044AbgI2SIS (ORCPT ); Tue, 29 Sep 2020 14:08:18 -0400 Received: from mail-oi1-f195.google.com ([209.85.167.195]:39359 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726064AbgI2SIS (ORCPT ); Tue, 29 Sep 2020 14:08:18 -0400 Received: by mail-oi1-f195.google.com with SMTP id c13so6463751oiy.6; Tue, 29 Sep 2020 11:08:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sU+G8HZjDOP5MRdUHbCt+p6p/tXjsZfEXILLEXLTGKk=; b=UrZNLDRzMobPfCBcZ0h5j7AEY+3dap7/nB8sSw1famcQylwQxAQpAlQNorOUHczwVY H8yRgKcOymomhUuUTilaXBHjuaSSqBTcF/uXnBxX5KfmOS9cEepgpDbdXF64EgOkTrlL 4PmjbJPaoKPO4z5e8tCNxLgsOtloq4AweWb/o3aF3/RcFXFzrf0waM6Zhu5ImMwLLu+5 imkVJPG06URl9mbZkdeDvHChNyRISbSmySrLi+Fly1G8tDSItQXiMoxEscUJle7BNFG4 aSnJB/qOG2urQp7kTlthOm02kW5fB/0hqgTp+JFvOOiQksxOEFm7VRt+i1Q9EaW5Ng0P hmnw== X-Gm-Message-State: AOAM532EpVDBi6c0RMBraEps2RZvoAOzgCksz5Uudxenkev21awLgM/m 3lai+VPE2iLK/QXnrhj8bw== X-Google-Smtp-Source: ABdhPJz56B8S1F50AdUm8skiSUxwaNOgLIFcS5ICv5Jn5u0GiuSyXnNAj4hFIR8xLsNWCl8z8U7x2g== X-Received: by 2002:aca:f5cb:: with SMTP id t194mr3210736oih.144.1601402896731; Tue, 29 Sep 2020 11:08:16 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id v20sm1150556oiv.47.2020.09.29.11.08.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Sep 2020 11:08:16 -0700 (PDT) Received: (nullmailer pid 882710 invoked by uid 1000); Tue, 29 Sep 2020 18:08:15 -0000 Date: Tue, 29 Sep 2020 13:08:15 -0500 From: Rob Herring To: Chunfeng Yun Cc: Chun-Kuang Hu , Kishon Vijay Abraham I , Stanley Chu , Philipp Zabel , David Airlie , Daniel Vetter , Vinod Koul , Matthias Brugger , CK Hu , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 1/4] dt-bindings: phy: convert phy-mtk-xsphy.txt to YAML schema Message-ID: <20200929180815.GA865690@bogus> References: <5af7c097d1c71a180d8ed1f1a44055859b42f1a0.1600760719.git.chunfeng.yun@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5af7c097d1c71a180d8ed1f1a44055859b42f1a0.1600760719.git.chunfeng.yun@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Sep 22, 2020 at 03:55:05PM +0800, Chunfeng Yun wrote: > Convert phy-mtk-xsphy.txt to YAML schema mediatek,xsphy.yaml > > Signed-off-by: Chunfeng Yun > --- > .../bindings/phy/mediatek,xsphy.yaml | 203 ++++++++++++++++++ > .../devicetree/bindings/phy/phy-mtk-xsphy.txt | 109 ---------- > 2 files changed, 203 insertions(+), 109 deletions(-) > create mode 100644 Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml > delete mode 100644 Documentation/devicetree/bindings/phy/phy-mtk-xsphy.txt > > diff --git a/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml > new file mode 100644 > index 000000000000..0aaa10640b5a > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml > @@ -0,0 +1,203 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (c) 2020 MediaTek > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/mediatek,xsphy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek XS-PHY Controller Device Tree Bindings > + > +maintainers: > + - Chunfeng Yun > + > +description: | > + The XS-PHY controller supports physical layer functionality for USB3.1 > + GEN2 controller on MediaTek SoCs. > + > +properties: > + $nodename: > + pattern: "^xs-phy@[0-9a-f]+$" > + > + compatible: > + oneOf: > + - items: > + - enum: > + - mediatek,mt3611-xsphy > + - enum: > + - mediatek,xsphy > + - items: > + - const: mediatek,xsphy mediatek,xsphy alone should not be valid. > + > + reg: > + description: | > + Register shared by multiple U3 ports, exclude port's private register, > + if only U2 ports provided, shouldn't use the property. > + maxItems: 1 > + > + "#address-cells": > + enum: [1, 2] > + > + "#size-cells": > + enum: [1, 2] > + > + ranges: true > + > + mediatek,src-ref-clk-mhz: > + description: > + Frequency of reference clock for slew rate calibrate > + $ref: /schemas/types.yaml#/definitions/uint32 > + default: 26 > + > + mediatek,src-coef: > + description: > + Coefficient for slew rate calibrate, depends on SoC process > + $ref: /schemas/types.yaml#/definitions/uint32 > + default: 17 > + > +# Required child node: > +patternProperties: > + "^usb-phy@[0-9a-f]+$": > + type: object > + description: | > + A sub-node is required for each port the controller provides. > + Address range information including the usual 'reg' property > + is used inside these nodes to describe the controller's topology. > + > + properties: > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: Reference clock, (HS is 48Mhz, SS/P is 24~27Mhz) > + > + clock-names: > + items: > + - const: ref > + > + "#phy-cells": > + const: 1 > + description: | > + The cells contain the following arguments. > + > + - description: The PHY type > + enum: > + - PHY_TYPE_USB2 > + - PHY_TYPE_USB3 > + > + #The following optional vendor properties are only for debug or HQA test > + mediatek,eye-src: > + description: > + The value of slew rate calibrate (U2 phy) > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 1 > + maximum: 7 > + > + mediatek,eye-vrt: > + description: > + The selection of VRT reference voltage (U2 phy) > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 1 > + maximum: 7 > + > + mediatek,eye-term: > + description: > + The selection of HS_TX TERM reference voltage (U2 phy) > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 1 > + maximum: 7 > + > + mediatek,efuse-intr: > + description: > + The selection of Internal Resistor (U2/U3 phy) > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 1 > + maximum: 63 > + > + mediatek,efuse-tx-imp: > + description: > + The selection of TX Impedance (U3 phy) > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 1 > + maximum: 31 > + > + mediatek,efuse-rx-imp: > + description: > + The selection of RX Impedance (U3 phy) > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 1 > + maximum: 31 > + > + required: > + - reg > + - clocks > + - clock-names > + - "#phy-cells" > + > + additionalProperties: false > + > +required: > + - compatible > + - "#address-cells" > + - "#size-cells" > + - ranges > + > +additionalProperties: false > + > +#Banks layout of xsphy > +#------------------------------------------------------------- Move this to top-level 'description'. > +#port offset bank > +#u2 port0 0x0000 MISC > +# 0x0100 FMREG > +# 0x0300 U2PHY_COM > +#u2 port1 0x1000 MISC > +# 0x1100 FMREG > +# 0x1300 U2PHY_COM > +#u2 port2 0x2000 MISC > +# ... > +#u31 common 0x3000 DIG_GLB > +# 0x3100 PHYA_GLB > +#u31 port0 0x3400 DIG_LN_TOP > +# 0x3500 DIG_LN_TX0 > +# 0x3600 DIG_LN_RX0 > +# 0x3700 DIG_LN_DAIF > +# 0x3800 PHYA_LN > +#u31 port1 0x3a00 DIG_LN_TOP > +# 0x3b00 DIG_LN_TX0 > +# 0x3c00 DIG_LN_RX0 > +# 0x3d00 DIG_LN_DAIF > +# 0x3e00 PHYA_LN > +# ... > +#DIG_GLB & PHYA_GLB are shared by U31 ports. > + > +examples: > + - | > + #include > + > + u3phy: xs-phy@11c40000 { > + compatible = "mediatek,mt3611-xsphy", "mediatek,xsphy"; > + reg = <0x11c43000 0x0200>; > + mediatek,src-ref-clk-mhz = <26>; > + mediatek,src-coef = <17>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + u2port0: usb-phy@11c40000 { > + reg = <0x11c40000 0x0400>; > + clocks = <&clk48m>; > + clock-names = "ref"; > + mediatek,eye-src = <4>; > + #phy-cells = <1>; > + }; > + > + u3port0: usb-phy@11c43000 { > + reg = <0x11c43400 0x0500>; > + clocks = <&clk26m>; > + clock-names = "ref"; > + mediatek,efuse-intr = <28>; > + #phy-cells = <1>; > + }; > + }; > + > +...