From: Rob Herring <robh@kernel.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
kernel@pengutronix.de, linux-media@vger.kernel.org
Subject: Re: [PATCH v2] media: dt-bindings: convert CODA VPU bindings to yaml
Date: Tue, 29 Sep 2020 13:47:01 -0500 [thread overview]
Message-ID: <20200929184701.GA945136@bogus> (raw)
In-Reply-To: <20200923082112.26477-1-p.zabel@pengutronix.de>
On Wed, 23 Sep 2020 10:21:12 +0200, Philipp Zabel wrote:
> Convert to YAML and add generic IP core compatibles "cnm,codadx6",
> "cnm,codahx4", "cnm,coda7541", and "cnm,coda960" in addition to the SoC
> specific compatibles. The new generic compatibles are already used in
> the SoC device trees and replace the free form comments. For example:
>
> - compatible : should be "fsl,<chip>-src" for i.MX SoCs:
> (a) "fsl,imx27-vpu" for CodaDx6 present in i.MX27
>
> turns into:
>
> properties:
> compatible:
> oneOf:
> - items:
> - const: fsl,imx27-vpu
> - const: cnm,codadx6
>
> This allows to properly specify the secondary JPEG unit interrupt that
> is only present on cnm,coda960.
>
> Also add the missing "fsl,imx6dl-vpu", "cnm,coda960" compatible.
> The AXI bus connection to the internal SRAM is different between i.MX6Q
> and i.MX6DL, which requires the driver to load a different firmware
> depending on the SoC.
>
> Further, specify the power-domain property for i.MX6 and change the
> clock order from "ahb", "per" to "per", "ahb". This order is currently
> used in all SoC device trees.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> Changes since v1:
> - Improve commit description
> - Fix clock order in example
> ---
> .../devicetree/bindings/media/coda.txt | 31 -----
> .../devicetree/bindings/media/coda.yaml | 109 ++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 110 insertions(+), 32 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/coda.txt
> create mode 100644 Documentation/devicetree/bindings/media/coda.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2020-09-29 18:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 8:21 [PATCH v2] media: dt-bindings: convert CODA VPU bindings to yaml Philipp Zabel
2020-09-29 18:47 ` Rob Herring [this message]
2020-10-01 20:34 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929184701.GA945136@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-media@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox