From: Thomas Kopp <thomas.kopp@microchip.com>
To: <mkl@pengutronix.de>, <manivannan.sadhasivam@linaro.org>,
<o.rempel@pengutronix.de>, <geert@linux-m68k.org>
Cc: <linux-can@vger.kernel.org>, <thomas.kopp@microchip.com>,
<dev.kurt@vandijck-laurijssen.be>, <devicetree@vger.kernel.org>,
<robh+dt@kernel.org>, <wg@grandegger.com>
Subject: [PATCH 2/2] can: mcp25xxfd: narrow down wildcards in device tree bindings
Date: Wed, 30 Sep 2020 11:14:23 +0200 [thread overview]
Message-ID: <20200930091423.755-2-thomas.kopp@microchip.com> (raw)
In-Reply-To: <20200930091423.755-1-thomas.kopp@microchip.com>
The wildcard should be narrowed down to prevent existing and
future devices that are not compatible from matching.
It is very unlikely that incompatible devices will be released
that do not match the wildcard.
This is the documentation part of the commit.
Discussion Reference: https://lore.kernel.org/r/CAMuHMdVkwGjr6dJuMyhQNqFoJqbh6Ec5V2b5LenCshwpM2SDsQ@mail.gmail.com/
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Thomas Kopp <thomas.kopp@microchip.com>
---
.../devicetree/bindings/net/can/microchip,mcp25xxfd.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/can/microchip,mcp25xxfd.yaml b/Documentation/devicetree/bindings/net/can/microchip,mcp25xxfd.yaml
index 5beb00a614bf..6765f4c611c5 100644
--- a/Documentation/devicetree/bindings/net/can/microchip,mcp25xxfd.yaml
+++ b/Documentation/devicetree/bindings/net/can/microchip,mcp25xxfd.yaml
@@ -18,7 +18,7 @@ properties:
description: for MCP2517FD
- const: microchip,mcp2518fd
description: for MCP2518FD
- - const: microchip,mcp25xxfd
+ - const: microchip,mcp251xfd
description: to autodetect chip variant
reg:
@@ -65,7 +65,7 @@ examples:
#size-cells = <0>;
can@0 {
- compatible = "microchip,mcp25xxfd";
+ compatible = "microchip,mcp251xfd";
reg = <0>;
clocks = <&can0_osc>;
pinctrl-names = "default";
--
2.25.1
next prev parent reply other threads:[~2020-09-30 9:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 9:14 [PATCH 1/2] can: mcp25xxfd: narrow down wildcards in device tree bindings Thomas Kopp
2020-09-30 9:14 ` Thomas Kopp [this message]
2020-09-30 9:15 ` Marc Kleine-Budde
2020-09-30 9:26 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930091423.755-2-thomas.kopp@microchip.com \
--to=thomas.kopp@microchip.com \
--cc=dev.kurt@vandijck-laurijssen.be \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-can@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mkl@pengutronix.de \
--cc=o.rempel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).