Re: [PATCH 0/8] Add support for UHS modes in TI's J721e and J7200 boards

Faiz Abbas
2020-10-02T16:09:56Z

Hi Nishanth,

On 02/10/20 6:19 pm, Nishanth Menon wrote:
> On 10:14-20201002, Faiz Abbas wrote:
>> Hi Nishanth,
>>
>> On 02/10/20 12:43 am, Nishanth Menon wrote:
>>> On 00:35-20201002, Faiz Abbas wrote:
>>>> The following patches add support for UHS modes for TI's j721e and j7200
>>>> boards.
>>>>
>>>> Patches 1-3 add support for gpios to j7200-evm
>>>>
>>>> Patches 4-6 add support for voltage regulators for required by the
>>>> SD card in both devices as well as enable UHS modes at 1.8V
>>>>
>>>> Patches 5-6 add some required configs to the arm64 defconfig.
>>>>
>>>> This series depends on driver patches adding tuning support here:
>>>> https://lore.kernel.org/linux-arm-kernel/20200923105206.7988-1-faiz_abbas@ti.com/
>>>>
>>>> Faiz Abbas (8):
>>>> arm64: dts: ti: k3-j7200-main: Add gpio nodes in main domain
>>>> arm64: dts: ti: k3-j7200: Add gpio nodes in wakeup domain
>>>> arm64: dts: ti: k3-j7200-common-proc-board: Disable unused gpio
>>>> modules
>>>> arm64: dts: ti: k3-j721e-main: Add output tap delay values
>>>> arm64: dts: ti: k3-j721e-common-proc-board: Add support SD card UHS
>>>> modes
>>>> arm64: dts: ti: k3-j7200-common-proc-board: Add support SD card UHS
>>>> modes
>>>
>>> Split these up please!
>>
>> Into SD card UHS and gpio series?
>>
>>>> arm64: defconfig: Enable OMAP I2C driver
>>>> arm64: defconfig: Enable DAVINCI_GPIO driver
>>>>
>>>
>>> defconfig patches can be posted independent of dts patches, they go to
>>> different branches.
>>
>> I was trying to follow Arnd's advice here:
>> https://lore.kernel.org/linux-arm-kernel/CAK8P3a1JpCCCV-CVQj3+eMfWF+=4AuHPpv390Tyj2pKn63_ZVg@mail.gmail.com/
>>
>> He says that defconfig patches can be sent at the same time as dts updates and maintainers can send those
>> as separate pull requests.
>
> BTW, [1] your patches 7/8 and 8/8 never hit the mailing list, So, I am
> commenting on the defconfig patches without actually seeing the patches,
> and solely based on $subject in the cover letter.

This is weird. They are there in my patches/ folder and I always do a "git send-email patches/* ..."

Not sure why they didn't get sent. My last send-email command does have all the patches being sent:

https://pastebin.ubuntu.com/p/VNWsrMcBZd/

>
> The reason for my comment was that I think defconfig series could go
> independent of the remaining series into 5.10, since they are not
> related specifically to this series, they are probably needed even for
> am654 and j721e nodes that already exist and was a miss that we didn't
> enable. Tying that to this specific series didn't make sense to me.

You're right that they are not tied to the series.

>
> But either way, we are way past rc7. I don't have enough time for
> these patches to bake in -next to make it to 5.10 window. So, lets try
> reposting this after rc1 tag is done so that I can send the defconfig
> (separately for 5.10 window) and the dts staged towards 5.11 (and no,
> I don't consider the dts patches as fixes - they are enabling the next
> level of functionality).
>

Ok. I'll send only the defconfig patches in a new series and repost v2 of this at rc1.

Thanks,
Fai