From: Sebastian Reichel <sre@kernel.org>
To: Ricardo Rivera-Matos <r-rivera-matos@ti.com>
Cc: robh+dt@kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dmurphy@ti.com
Subject: Re: [PATCH v5 2/2] power: supply: bq256xx: Introduce the BQ256XX charger driver
Date: Sat, 3 Oct 2020 12:54:48 +0200 [thread overview]
Message-ID: <20201003105448.eqeyfpr7dugsp4in@earth.universe> (raw)
In-Reply-To: <20201001214034.5925-3-r-rivera-matos@ti.com>
[-- Attachment #1: Type: text/plain, Size: 461 bytes --]
Hi Ricardo,
On Thu, Oct 01, 2020 at 04:40:34PM -0500, Ricardo Rivera-Matos wrote:
> The BQ256XX family of devices are highly integrated buck chargers
> for single cell batteries.
>
> Signed-off-by: Ricardo Rivera-Matos <r-rivera-matos@ti.com>
>
> v5 - adds power_supply_put_battery_info() and devm_add_action_or_reset() calls
> ---
changes look good, but you are still missing
usb_unregister_notifier() calls on drival removal.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-10-03 10:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 21:40 [PATCH v5 0/2] Introduce the BQ256XX family of chargers Ricardo Rivera-Matos
2020-10-01 21:40 ` [PATCH v5 1/2] dt-bindings: power: Add the bq256xx dt bindings Ricardo Rivera-Matos
2020-10-01 21:40 ` [PATCH v5 2/2] power: supply: bq256xx: Introduce the BQ256XX charger driver Ricardo Rivera-Matos
2020-10-03 10:54 ` Sebastian Reichel [this message]
2020-10-05 17:33 ` [EXTERNAL] " Ricardo Rivera-Matos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201003105448.eqeyfpr7dugsp4in@earth.universe \
--to=sre@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=r-rivera-matos@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox