From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACB76C4363C for ; Sun, 4 Oct 2020 12:46:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 58B6820735 for ; Sun, 4 Oct 2020 12:46:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601815571; bh=KmlOPDI70o6oZU+d45F/jzuxfUWYoVayUg2hJ7fdtXk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=uCDsgam0lMO9lO8cQm+o94Sg0f7j2f6BDBiiOeERjgJaWZ99bQ7j262V+EVe1jPJN k2sNINb0MalBDqStY4boJqjpahsGScjqrkGDV536xetUcUy4uIv0O1jKDvckKPy31s 2bEG1+Uwds7yXjORk78D3+cnVwsy0t94nYps2Lg4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725868AbgJDMqK (ORCPT ); Sun, 4 Oct 2020 08:46:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:54458 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725840AbgJDMqJ (ORCPT ); Sun, 4 Oct 2020 08:46:09 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3D3D5206C1; Sun, 4 Oct 2020 12:46:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601815569; bh=KmlOPDI70o6oZU+d45F/jzuxfUWYoVayUg2hJ7fdtXk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m5zXzEeVvnzVMH3HoN78Ppoz9GCrFs1Ea5iwlpRkhjj4Z8EntXyUUzszRNs0F6CGt wbUCUCsqOuijVE61LGLlJNdh/cuBaJaMYcBkOstJS/n5tVCx9wauqY6ZoWr5AXqfFN qtQEwDVD5415kNqCC3hxEARHAFTkhJ9DC7g3UFpM= Date: Sun, 4 Oct 2020 08:46:08 -0400 From: Sasha Levin To: Helmut Grohne Cc: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Alexandre Belloni , "David S . Miller" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH AUTOSEL 5.8 08/29] net: dsa: microchip: look for phy-mode in port nodes Message-ID: <20201004124608.GJ2415204@sasha-vm> References: <20200929013027.2406344-1-sashal@kernel.org> <20200929013027.2406344-8-sashal@kernel.org> <20200929055630.GA9320@laureti-dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200929055630.GA9320@laureti-dev> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Sep 29, 2020 at 07:56:30AM +0200, Helmut Grohne wrote: >Hi Sascha, > >On Tue, Sep 29, 2020 at 03:30:05AM +0200, Sasha Levin wrote: >> From: Helmut Grohne >> >> [ Upstream commit edecfa98f602a597666e3c5cab2677ada38d93c5 ] >> >> Documentation/devicetree/bindings/net/dsa/dsa.txt says that the phy-mode >> property should be specified on port nodes. However, the microchip >> drivers read it from the switch node. >> >> Let the driver use the per-port property and fall back to the old >> location with a warning. >> >> Fix in-tree users. > >I don't think this patch is useful for stable users. It corrects a >device tree layout issue. Any existing users of the functionality will >have an odd, but working device tree and that will continue working >(with a warning) after applying this patch. It just has a property on >the "wrong" node. I don't think I'd like to update my device tree in a >stable update. I've dropped it, thanks! -- Thanks, Sasha