From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63AEEC4363D for ; Mon, 5 Oct 2020 14:04:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D02E208B6 for ; Mon, 5 Oct 2020 14:04:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601906650; bh=lwuFuDAmuFoKwEMtUJpox0jwsSA+0WkYvleLCBYyn+0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=V1PX6EExeJJaqwKQT5ACpGslymeQjnnuHRFeFP2v6wzA6sM+EmkNn91G0Tlrmzwn1 iLw6jnocz/UWeXjvXvxh+7BAGbpxvSdcP8h7CoqsZzNX7owFlVlM/WE1Gq6XTrElFh r02S/E/lu6aTRwZJAERF/w7x12W/EHAFlEeOd1vY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726362AbgJEOED (ORCPT ); Mon, 5 Oct 2020 10:04:03 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:42240 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725903AbgJEOEC (ORCPT ); Mon, 5 Oct 2020 10:04:02 -0400 Received: by mail-oi1-f193.google.com with SMTP id 16so1174920oix.9; Mon, 05 Oct 2020 07:04:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=jcb+2/70PszYHXyW4L95C/uGG2EZ8iNbr9zT465Oa80=; b=q2Y3LmguVa0+xeBKieIvGGUXJ7b45Nxs2t3k9l8D/W+mdkOgwA/n3dlmPROLFYOEvK ZEjmmKWFOw6NSxozesoralXBgEQC8X6u0Oock23cCsEQzh+9Yg5VtxUMe9M9yJY3iwO+ lV9CFurod/mQnBw7DyA69bRE43pp28bftI45UfL4HQTQJn3dTTIkd958VI9GLKjv2Hav GTCQKbovbKeiOe+iBb2ITaID2OT1cVzPlaebWiOIgdwNKi5sK+RZ2KBx0a/a4PXcpG+O KiR8wdcWnay1eZNPlFi6sDlbDRBJ+VlGYruz8ye2LFidj2LOEyMLJq3d4d0shuueH7/6 xZ+A== X-Gm-Message-State: AOAM53025B8dIhU37/iJIo7De/zd/2Ww9LDXT4nEef6rHgdVt0fod+qY WgzMC1npRwz5ZDuNxWuvFw== X-Google-Smtp-Source: ABdhPJy3QFjx9s0Phb6R+RWSxq5sCwP+Ktun0EurtTGiFSdb4RaCkut6rj30bR9aJFbk0V23t6U52Q== X-Received: by 2002:aca:d03:: with SMTP id 3mr7996466oin.112.1601906641296; Mon, 05 Oct 2020 07:04:01 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id m205sm53951oib.43.2020.10.05.07.03.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2020 07:04:00 -0700 (PDT) Received: (nullmailer pid 99419 invoked by uid 1000); Mon, 05 Oct 2020 14:03:59 -0000 Date: Mon, 5 Oct 2020 09:03:59 -0500 From: Rob Herring To: Krzysztof Kozlowski Cc: =?utf-8?Q?=C5=81ukasz?= Stelmach , "David S. Miller" , Jakub Kicinski , Kukjin Kim , Russell King , Andrew Lunn , jim.cromie@gmail.com, linux-arm-kernel@lists.infradead.org, "linux-kernel@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , netdev@vger.kernel.org, devicetree@vger.kernel.org, =?utf-8?Q?Bart=C5=82omiej_=C5=BBolnierkiewicz?= , Marek Szyprowski Subject: Re: [PATCH v2 1/4] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter Message-ID: <20201005140359.GB92530@bogus> References: <20201002192210.19967-1-l.stelmach@samsung.com> <20201002192210.19967-2-l.stelmach@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, Oct 03, 2020 at 12:09:55PM +0200, Krzysztof Kozlowski wrote: > On Fri, 2 Oct 2020 at 21:22, Łukasz Stelmach wrote: > > > > Add bindings for AX88796C SPI Ethernet Adapter. > > > > Signed-off-by: Łukasz Stelmach > > --- > > .../bindings/net/asix,ax88796c-spi.yaml | 76 +++++++++++++++++++ > > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > > 2 files changed, 78 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/asix,ax88796c-spi.yaml > > > > diff --git a/Documentation/devicetree/bindings/net/asix,ax88796c-spi.yaml b/Documentation/devicetree/bindings/net/asix,ax88796c-spi.yaml > > new file mode 100644 > > index 000000000000..50a488d59dbf > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/asix,ax88796c-spi.yaml > > @@ -0,0 +1,76 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/asix,ax88796c-spi.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: ASIX AX88796C SPI Ethernet Adapter > > + > > +allOf: > > + - $ref: ethernet-controller.yaml# > > Order of top-level entries please: > 1. id, schema > 2. title > 3. maintainers > 4. description > and then allOf. See example-schema.yaml. > > > + > > +description: | > > + ASIX AX88796C is an Ethernet controller with a built in PHY. This > > + describes SPI mode of the chip. > > + > > + The node for this driver must be a child node of a SPI controller, hence > > + all mandatory properties described in ../spi/spi-bus.txt must be specified. Did you read spi-bus.txt? > > + > > +maintainers: > > + - Łukasz Stelmach > > + > > +properties: > > + compatible: > > + const: asix,ax99796c-spi 'spi' is implied by the bus the device is on, so drop. > > + > > + reg: > > + description: > > + SPI device address. > > Skip description, it's trivial. > > > + maxItems: 1 > > + > > + spi-max-frequency: > > + maximum: 40000000 > > + > > + interrupts: > > + description: > > + GPIO interrupt to which the chip is connected. > > Skip the description. It's trivial and might be not accurate (does not > have to be a GPIO). > > > + maxItems: 1 > > + > > + interrupt-parrent: Typo. But you don't need to list interrupt-parent. > > + description: > > + A phandle of an interrupt controller. > > Skip description. > > > + maxItems: 1 > > + > > + reset-gpios: > > + description: > > + A GPIO line handling reset of the chip. As the line is active low, > > + it should be marked GPIO_ACTIVE_LOW. > > + maxItems: 1 > > + > > + local-mac-address: true > > + > > + mac-address: true > > + > > +required: > > + - compatible > > + - reg > > + - spi-max-frequency > > + - interrupts > > + - interrupt-parrent > > + - reset-gpios > > Additional properties false. > > > + > > +examples: > > + # Artik5 eval board > > + - | > > + ax88796c@0 { ethernet@0 > > + compatible = "asix,ax88796c"; > > + local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */ > > + interrupt-parent = <&gpx2>; > > + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > > + spi-max-frequency = <40000000>; > > + reg = <0x0>; > > + reset-gpios = <&gpe0 2 GPIO_ACTIVE_LOW>; > > + controller-data { Not documented. > > + samsung,spi-feedback-delay = <2>; > > + }; > > + }; > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > > index 2baee2c817c1..5ce5c4a43735 100644 > > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > > @@ -117,6 +117,8 @@ patternProperties: > > description: Asahi Kasei Corp. > > "^asc,.*": > > description: All Sensors Corporation > > + "^asix,.*": > > + description: ASIX Electronics Corporation > > Separate patch please. > > Best regards, > Krzysztof > > > "^aspeed,.*": > > description: ASPEED Technology Inc. > > "^asus,.*": > > -- > > 2.26.2 > >