From: Rob Herring <robh@kernel.org>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [RESEND PATCH 023/100] dt-bindings: nokia,smia: Convert to YAML
Date: Tue, 6 Oct 2020 14:58:07 -0500 [thread overview]
Message-ID: <20201006195807.GA2724596@bogus> (raw)
In-Reply-To: <20200930201914.31377-5-sakari.ailus@linux.intel.com>
On Wed, Sep 30, 2020 at 11:19:11PM +0300, Sakari Ailus wrote:
> Convert nokia,smia DT bindings to YAML.
>
> Also add explicit license to bindings.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> .../bindings/media/i2c/nokia,smia.txt | 68 --------
> .../bindings/media/i2c/nokia,smia.yaml | 147 ++++++++++++++++++
> 2 files changed, 147 insertions(+), 68 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/i2c/nokia,smia.txt
> create mode 100644 Documentation/devicetree/bindings/media/i2c/nokia,smia.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/nokia,smia.txt b/Documentation/devicetree/bindings/media/i2c/nokia,smia.txt
> deleted file mode 100644
> index 5ea4f799877b..000000000000
> --- a/Documentation/devicetree/bindings/media/i2c/nokia,smia.txt
> +++ /dev/null
> @@ -1,68 +0,0 @@
> -SMIA/SMIA++ sensor
> -
> -SMIA (Standard Mobile Imaging Architecture) is an image sensor standard
> -defined jointly by Nokia and ST. SMIA++, defined by Nokia, is an extension
> -of that. These definitions are valid for both types of sensors.
> -
> -More detailed documentation can be found in
> -Documentation/devicetree/bindings/media/video-interfaces.txt .
> -
> -The device node should contain a "port" node which may contain one or more
> -endpoint nodes, in accordance with video interface bindings defined in
> -Documentation/devicetree/bindings/media/video-interfaces.txt .
> -
> -Mandatory properties
> ---------------------
> -
> -- compatible: "nokia,smia"
> -- reg: I2C address (0x10, or an alternative address)
> -- clocks: External clock to the sensor
> -- clock-frequency: Frequency of the external clock to the sensor
> -
> -
> -Optional properties
> --------------------
> -
> -- reset-gpios: XSHUTDOWN GPIO
> -- flash-leds: See ../video-interfaces.txt
> -- lens-focus: See ../video-interfaces.txt
> -- rotation: Integer property; valid values are 0 (sensor mounted upright)
> - and 180 (sensor mounted upside down). See
> - ../video-interfaces.txt .
> -- vana-supply: Analogue voltage supply (VANA), typically 2,8 volts (sensor
> - dependent).
> -
> -
> -Endpoint node mandatory properties
> -----------------------------------
> -
> -- data-lanes: <1..n>
> -- link-frequencies: List of allowed data link frequencies. An array of
> - 64-bit elements.
> -
> -
> -Example
> --------
> -
> -&i2c2 {
> - clock-frequency = <400000>;
> -
> - camera-sensor@10 {
> - compatible = "nokia,smia";
> - reg = <0x10>;
> - reset-gpios = <&gpio3 20 0>;
> - vana-supply = <&vaux3>;
> - clocks = <&omap3_isp 0>;
> - clock-frequency = <9600000>;
> - nokia,nvm-size = <512>; /* 8 * 64 */
> - port {
> - smiapp_ep: endpoint {
> - data-lanes = <1 2>;
> - remote-endpoint = <&csi2a_ep>;
> - link-frequencies =
> - /bits/ 64 <199200000 210000000
> - 499200000>;
> - };
> - };
> - };
> -};
> diff --git a/Documentation/devicetree/bindings/media/i2c/nokia,smia.yaml b/Documentation/devicetree/bindings/media/i2c/nokia,smia.yaml
> new file mode 100644
> index 000000000000..3d6f68b0e559
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/nokia,smia.yaml
> @@ -0,0 +1,147 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2014--2020 Intel Corporation
> +
> +$id: http://devicetree.org/schemas/media/i2c/nokia,smia.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: SMIA/SMIA++ sensor
> +
> +maintainers:
> + - Sakari Ailus <sakari.ailus@linux.intel.com>
> +
> +description:
> +
> + SMIA (Standard Mobile Imaging Architecture) is an image sensor standard
> + defined jointly by Nokia and ST. SMIA++, defined by Nokia, is an extension of
> + that. These definitions are valid for both types of sensors.
> +
> + More detailed documentation can be found in
> + Documentation/devicetree/bindings/media/video-interfaces.txt .
> +
> +properties:
> + compatible:
> + const: nokia,smia
> +
> + reg:
> + maxItems: 1
> +
> + vana-supply:
> + description: Analogue voltage supply (VANA), typically 2,8 volts (sensor
> + dependent).
> + maxItems: 1
> +
> + clocks:
> + description: External clock to the sensor.
> + maxItems: 1
> +
> + clock-frequency:
> + description: Frequency of the external clock to the sensor.
> +
> + reset-gpios:
> + description: Reset GPIO. Also commonly called XSHUTDOWN in hardware
> + documentation.
> + maxItems: 1
> +
> + flash-leds:
> + description: Flash LED phandles. See ../video-interfaces.txt for details.
> +
> + lens-focus:
> + description: Lens focus controller phandles. See ../video-interfaces.txt
> + for details.
> +
> + rotation:
> + description: Rotation; either 0 or 180 degrees.
enum: [ 0, 180 ]
> +
> + port:
> + type: object
> + properties:
> + endpoint:
> + type: object
> + properties:
> + link-frequencies:
> + $ref: /schemas/types.yaml#/definitions/uint64-array
> + description: List of allowed data link frequencies. An array of
> + 64-bit elements.
Just 'link-frequencies: true' unless you have some additional
constraints.
> + data-lanes:
> + oneOf:
> + - items:
> + - const: 1
> + - items:
> + - const: 1
> + - const: 2
> + - items:
> + - const: 1
> + - const: 2
> + - const: 3
> + - items:
> + - const: 1
> + - const: 2
> + - const: 3
> + - const: 4
> + - items:
> + - const: 1
> + - const: 2
> + - const: 3
> + - const: 4
> + - const: 5
> + - items:
> + - const: 1
> + - const: 2
> + - const: 3
> + - const: 4
> + - const: 5
> + - const: 6
> + - items:
> + - const: 1
> + - const: 2
> + - const: 3
> + - const: 4
> + - const: 5
> + - const: 6
> + - const: 7
> + - items:
> + - const: 1
> + - const: 2
> + - const: 3
> + - const: 4
> + - const: 5
> + - const: 6
> + - const: 7
> + - const: 8
This all can be just the last 'items' plus:
minItems: 1
maxItems: 8
> + required:
> + - link-frequencies
> + - data-lanes
> +
> +required:
> + - compatible
> + - reg
> + - clock-frequency
> + - clocks
additionalProperties: false
> +
> +examples:
> + - |
> + i2c2 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + clock-frequency = <400000>;
> +
> + camera-sensor@10 {
> + compatible = "nokia,smia";
> + reg = <0x10>;
> + reset-gpios = <&gpio3 20 0>;
> + vana-supply = <&vaux3>;
> + clocks = <&omap3_isp 0>;
> + clock-frequency = <9600000>;
> + nokia,nvm-size = <512>; /* 8 * 64 */
Not documented.
> + port {
> + smiapp_ep: endpoint {
> + data-lanes = <1 2>;
> + remote-endpoint = <&csi2a_ep>;
> + link-frequencies = /bits/ 64 <199200000 210000000
> + 499200000>;
> + };
> + };
> + };
> + };
> +...
> --
> 2.27.0
>
next prev parent reply other threads:[~2020-10-06 19:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 20:19 [RESEND PATCH 000/100] Linux CCS driver Sakari Ailus
2020-09-30 20:19 ` [RESEND PATCH 020/100] dt-bindings: Add vendor prefix for MIPI Alliance Sakari Ailus
2020-10-06 19:50 ` Rob Herring
2020-10-06 19:52 ` Sakari Ailus
2020-09-30 20:19 ` [RESEND PATCH 021/100] dt-bindings: nokia,smia: Fix link-frequencies documentation Sakari Ailus
2020-10-06 19:51 ` Rob Herring
2020-09-30 20:19 ` [RESEND PATCH 022/100] dt-bindings: nokia,smia: Make vana-supply optional Sakari Ailus
2020-10-06 19:52 ` Rob Herring
2020-09-30 20:19 ` [RESEND PATCH 023/100] dt-bindings: nokia,smia: Convert to YAML Sakari Ailus
2020-10-06 19:58 ` Rob Herring [this message]
2020-10-07 7:38 ` Sakari Ailus
2020-09-30 20:19 ` [RESEND PATCH 024/100] dt-bindings: nokia,smia: Use better active polarity for reset Sakari Ailus
2020-10-06 19:58 ` Rob Herring
2020-09-30 20:19 ` [RESEND PATCH 025/100] dt-bindings: nokia,smia: Amend SMIA bindings with MIPI CCS support Sakari Ailus
2020-09-30 20:19 ` [RESEND PATCH 026/100] dt-bindings: ccs: Add bus-type for C-PHY support Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006195807.GA2724596@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).