From: Rob Herring <robh@kernel.org>
To: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
Cc: Collabora Kernel ML <kernel@collabora.com>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Simon Glass <sjg@chromium.org>,
Doug Anderson <dianders@chromium.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] dt-bindings: mfd: google,cros-ec: add missing properties
Date: Tue, 6 Oct 2020 16:35:43 -0500 [thread overview]
Message-ID: <20201006213543.GA2881522@bogus> (raw)
In-Reply-To: <20201006061317.rs63e3dh4grxij2v@rcn-XPS-13-9360>
On Tue, Oct 06, 2020 at 08:13:17AM +0200, Ricardo Cañuelo wrote:
> Hi Rob,
>
> thanks for reviewing the patch. Find my comments below:
>
> On lun 05-10-2020 10:37:09, Rob Herring wrote:
> > > + '#address-cells':
> > > + enum: [1, 2]
> > > +
> > > + '#size-cells':
> > > + enum: [0, 1]
> >
> > This doesn't really make sense. Either there's a size or there isn't.
> >
> > [...]
> >
> > > + "^regulator@[a-f0-9]+$":
> > > + "^ec-codec@[a-f0-9]+$":
> >
> > What does the number space represent and is it the same for each of
> > these? If not, then this is kind of broken. There's only 1 number
> > space at a given level.
>
> I see what you mean. In the regulator, the unit-address means the identifier
> for the voltage regulator and I guess it could also be defined as
> simply "^regulator@[0-9]+$". In the codec, though, it's a physical base
> address.
>
> The reg property in these has a different format, that's why I
> defined #address-cells and #size-cells above to have a range of values
> instead of fixed values.
But in any given DT it is going to be fixed, so that doesn't help you.
> >From your experience, what's the best course of action here? I can't
> find a driver managing google,cros-ec-codec yet, although the binding
> was submitted in January.
Normally, you just add another layer with a 'regulators' and/or 'codecs'
node. Do you really have more than 1 codec?
Rob
next prev parent reply other threads:[~2020-10-06 21:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 7:13 [PATCH 0/3] Fix checker warnings related to cros-ec binding Ricardo Cañuelo
2020-10-05 7:14 ` [PATCH 1/3] dt-bindings: i2c: convert i2c-cros-ec-tunnel to json-schema Ricardo Cañuelo
2020-10-05 8:52 ` Enric Balletbo i Serra
2020-10-05 9:18 ` Ricardo Cañuelo
2020-10-05 9:27 ` Enric Balletbo i Serra
2020-10-05 14:04 ` Rob Herring
2020-10-05 7:14 ` [PATCH 2/3] dt-bindings: input: convert cros-ec-keyb " Ricardo Cañuelo
2020-10-05 9:03 ` Enric Balletbo i Serra
2020-10-05 9:35 ` Ricardo Cañuelo
2020-10-05 7:14 ` [PATCH 3/3] dt-bindings: mfd: google,cros-ec: add missing properties Ricardo Cañuelo
2020-10-05 9:23 ` Enric Balletbo i Serra
2020-10-05 9:48 ` Ricardo Cañuelo
2020-10-05 15:37 ` Rob Herring
2020-10-05 15:48 ` Enric Balletbo i Serra
2020-10-06 6:13 ` Ricardo Cañuelo
2020-10-06 11:28 ` Guenter Roeck
2020-10-06 13:07 ` Ricardo Cañuelo
2020-10-06 21:35 ` Rob Herring [this message]
2020-10-07 6:31 ` Ricardo Cañuelo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006213543.GA2881522@bogus \
--to=robh@kernel.org \
--cc=bleung@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=kernel@collabora.com \
--cc=ricardo.canuelo@collabora.com \
--cc=sjg@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).