From: Guenter Roeck <linux@roeck-us.net>
To: Chu Lin <linchuyuan@google.com>
Cc: jdelvare@suse.com, robh+dt@kernel.org,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: hwmon: max20730: adding device tree doc for max20730
Date: Tue, 6 Oct 2020 14:55:28 -0700 [thread overview]
Message-ID: <20201006215528.GA96892@roeck-us.net> (raw)
In-Reply-To: <20201004031445.2321090-2-linchuyuan@google.com>
On Sun, Oct 04, 2020 at 03:14:44AM +0000, Chu Lin wrote:
> max20730 Integrated, Step-Down Switching Regulator with PMBus
>
> Signed-off-by: Chu Lin <linchuyuan@google.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
Applied to hwmon-next.
Thanks,
Guenter
> ---
> ChangeLog v1 -> v2
> hwmon: pmbus: max20730:
> - Don't do anything to the ret if an error is returned from pmbus_read_word
> - avoid overflow when doing multiplication
>
> ChangeLog v2 -> v3
> dt-bindings: hwmon: max20730:
> - Provide the binding documentation in yaml format
> hwmon: pmbus: max20730:
> - No change
>
> ChangeLog v3 -> v4
> dt-bindings: hwmon: max20730:
> - Fix highefficiency to high efficiency in description
> - Fix presents to present in vout-voltage-divider
> - Add additionalProperties: false
> hwmon: pmbus: max20730:
> - No change
>
> .../bindings/hwmon/maxim,max20730.yaml | 65 +++++++++++++++++++
> 1 file changed, 65 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max20730.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max20730.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max20730.yaml
> new file mode 100644
> index 000000000000..93e86e3b4602
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/maxim,max20730.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +
> +$id: http://devicetree.org/schemas/hwmon/maxim,max20730.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Maxim max20730
> +
> +maintainers:
> + - Jean Delvare <jdelvare@suse.com>
> + - Guenter Roeck <linux@roeck-us.net>
> +
> +description: |
> + The MAX20730 is a fully integrated, highly efficient switching regulator
> + with PMBus for applications operating from 4.5V to 16V and requiring
> + up to 25A (max) load. This single-chip regulator provides extremely
> + compact, high efficiency power-delivery solutions with high-precision
> + output voltages and excellent transient response.
> +
> + Datasheets:
> + https://datasheets.maximintegrated.com/en/ds/MAX20730.pdf
> + https://datasheets.maximintegrated.com/en/ds/MAX20734.pdf
> + https://datasheets.maximintegrated.com/en/ds/MAX20743.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - maxim,max20730
> + - maxim,max20734
> + - maxim,max20743
> +
> + reg:
> + maxItems: 1
> +
> + vout-voltage-divider:
> + description: |
> + If voltage divider present at vout, the voltage at voltage sensor pin
> + will be scaled. The properties will convert the raw reading to a more
> + meaningful number if voltage divider present. It has two numbers,
> + the first number is the output resistor, the second number is the total
> + resistance. Therefore, the adjusted vout is equal to
> + Vout = Vout * output_resistance / total resistance.
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + minItems: 2
> + maxItems: 2
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + max20730@10 {
> + compatible = "maxim,max20730";
> + reg = <0x10>;
> + vout-voltage-divider = <1000 2000>; // vout would be scaled to 0.5
> + };
> + };
next prev parent reply other threads:[~2020-10-06 21:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-04 3:14 [PATCH v4 0/2] hwmon: pmbus: max20730: adjust the vout base on Chu Lin
2020-10-04 3:14 ` [PATCH v4 1/2] dt-bindings: hwmon: max20730: adding device tree doc for max20730 Chu Lin
2020-10-06 21:17 ` Rob Herring
2020-10-06 21:55 ` Guenter Roeck [this message]
2020-10-04 3:14 ` [PATCH v4 2/2] hwmon: pmbus: max20730: adjust the vout reading given voltage divider Chu Lin
2020-10-04 15:43 ` Guenter Roeck
2020-10-05 3:07 ` Chu Lin
2020-10-05 5:24 ` Guenter Roeck
2020-10-05 15:03 ` Guenter Roeck
2020-10-06 21:55 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006215528.GA96892@roeck-us.net \
--to=linux@roeck-us.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linchuyuan@google.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).