From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17689C433E7 for ; Fri, 9 Oct 2020 07:33:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4F0E22269 for ; Fri, 9 Oct 2020 07:33:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732006AbgJIHdx (ORCPT ); Fri, 9 Oct 2020 03:33:53 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:50544 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726326AbgJIHdx (ORCPT ); Fri, 9 Oct 2020 03:33:53 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 585261C0B88; Fri, 9 Oct 2020 09:33:50 +0200 (CEST) Date: Fri, 9 Oct 2020 09:33:49 +0200 From: Pavel Machek To: Lad Prabhakar Cc: Geert Uytterhoeven , Magnus Damm , Rob Herring , linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Biju Das , Prabhakar Subject: Re: [PATCH v2 3/3] ARM: dts: r8a7742-iwg21d-q7: Enable SD2 LED indication Message-ID: <20201009073349.GD10335@amd> References: <20200907155541.2011-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20200907155541.2011-4-prabhakar.mahadev-lad.rj@bp.renesas.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2Z2K0IlrPCVsbNpk" Content-Disposition: inline In-Reply-To: <20200907155541.2011-4-prabhakar.mahadev-lad.rj@bp.renesas.com> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --2Z2K0IlrPCVsbNpk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts > @@ -63,6 +63,16 @@ > enable-gpios =3D <&gpio3 11 GPIO_ACTIVE_HIGH>; > }; > =20 > + leds { > + compatible =3D "gpio-leds"; > + > + sdhi2_led { > + label =3D "sdio-led"; This should use appropriate label... probably mmc1:green:activity. Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --2Z2K0IlrPCVsbNpk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl+AEl0ACgkQMOfwapXb+vKrjQCfROOMQBVSBONI7IRKZfJ6Ibpn aHUAoKBKPHGLOLWavFe+rh2y6O/uXRN+ =Nd9K -----END PGP SIGNATURE----- --2Z2K0IlrPCVsbNpk--