From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Dan Murphy <dmurphy@ti.com>, sre@kernel.org
Cc: lkp@intel.com, kbuild-all@lists.01.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, Dan Murphy <dmurphy@ti.com>,
Ricardo Rivera-Matos <r-rivera-matos@ti.com>
Subject: Re: [PATCH v3 2/2] power: supply: bq25790: Introduce the BQ25790 charger driver
Date: Fri, 9 Oct 2020 15:15:32 +0300 [thread overview]
Message-ID: <20201009121532.GN1042@kadam> (raw)
In-Reply-To: <20201008154356.19692-2-dmurphy@ti.com>
[-- Attachment #1: Type: text/plain, Size: 2320 bytes --]
Hi Dan,
url: https://github.com/0day-ci/linux/commits/Dan-Murphy/dt-bindings-power-Add-the-bq25790-dt-bindings/20201008-234450
base: https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
config: i386-randconfig-m021-20201009 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/power/supply/bq25790_charger.c:170 bq25790_usb_work() warn: ignoring unreachable code.
drivers/power/supply/bq25790_charger.c:624 bq25790_get_property() warn: should this be a bitwise op?
vim +170 drivers/power/supply/bq25790_charger.c
bc435a97ea513a3 Dan Murphy 2020-10-08 154 static void bq25790_usb_work(struct work_struct *data)
bc435a97ea513a3 Dan Murphy 2020-10-08 155 {
bc435a97ea513a3 Dan Murphy 2020-10-08 156 struct bq25790_device *bq =
bc435a97ea513a3 Dan Murphy 2020-10-08 157 container_of(data, struct bq25790_device, usb_work);
bc435a97ea513a3 Dan Murphy 2020-10-08 158
bc435a97ea513a3 Dan Murphy 2020-10-08 159 switch (bq->usb_event) {
bc435a97ea513a3 Dan Murphy 2020-10-08 160 case USB_EVENT_ID:
bc435a97ea513a3 Dan Murphy 2020-10-08 161 break;
bc435a97ea513a3 Dan Murphy 2020-10-08 162
bc435a97ea513a3 Dan Murphy 2020-10-08 163 case USB_EVENT_NONE:
bc435a97ea513a3 Dan Murphy 2020-10-08 164 power_supply_changed(bq->charger);
bc435a97ea513a3 Dan Murphy 2020-10-08 165 break;
bc435a97ea513a3 Dan Murphy 2020-10-08 166 }
bc435a97ea513a3 Dan Murphy 2020-10-08 167
bc435a97ea513a3 Dan Murphy 2020-10-08 168 return;
^^^^^^
bc435a97ea513a3 Dan Murphy 2020-10-08 169
bc435a97ea513a3 Dan Murphy 2020-10-08 @170 dev_err(bq->dev, "Error switching to charger mode.\n");
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Unreachable.
bc435a97ea513a3 Dan Murphy 2020-10-08 171 }
The bitwise warning is this:
if (state.fault_1 && (BQ25790_OTG_OVP | BQ25790_VSYS_OVP))
^^
This && should be &.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35137 bytes --]
next prev parent reply other threads:[~2020-10-09 12:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 15:43 [PATCH v3 1/2] dt-bindings: power: Add the bq25790 dt bindings Dan Murphy
2020-10-08 15:43 ` [PATCH v3 2/2] power: supply: bq25790: Introduce the BQ25790 charger driver Dan Murphy
2020-10-09 0:51 ` kernel test robot
2020-10-09 12:15 ` Dan Carpenter [this message]
2020-10-09 12:18 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009121532.GN1042@kadam \
--to=dan.carpenter@oracle.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lkp@intel.com \
--cc=r-rivera-matos@ti.com \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).