From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBFF8C433E7 for ; Mon, 12 Oct 2020 18:48:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7FB7620838 for ; Mon, 12 Oct 2020 18:48:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602528486; bh=0rzAKmzJ2d9B8LLhS+r+kuBIEOOX808xwTbAl85FTB4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Ttp9tQWLLsW1U4P6wtnMjMMOG2TEOB6KuXDto3fwiuuVkvSFpggNreffYBPp4jd6y u9g4+EYbOmHwXGOhcjAQ0o3pp+srZAfM/kh7l4j3Od2vAbdSyIhzEmWAzg3ZUUQCjH xBqdq4R11WqLc3nLQ1hsM63ezsC/vtLk03mlsHv8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730635AbgJLSsG (ORCPT ); Mon, 12 Oct 2020 14:48:06 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:37936 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726267AbgJLSsF (ORCPT ); Mon, 12 Oct 2020 14:48:05 -0400 Received: by mail-ot1-f66.google.com with SMTP id i12so16771743ota.5; Mon, 12 Oct 2020 11:48:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6XXJOfO7U4hxEa5RGS+xMQKrs9V5PRPthZW1rOFN0zg=; b=lKQWoVXqhV4Bf/VFkJfoZNCWxPisDAAzEdQD0+REe8/0DNyAYRs9EB8M5JxtSI9YQl yBcdrnk79vHj3gglT5mkEeOf1yWqgVOBOLuuuuL0julgVk3mjZte0EUDgJ1WTgK0FLOU wi7yLK2D08sev8IWi45PqN+N+iJNESK6sDZAPpGHp/yKWiG+LDQlb26cxiYN2/M3sE10 8MpBcx84yIIkRqGo2jqhSDeKZQVbJOlwUkLJpJ3QqxKKGrpzcZGNjCDrgGUdC0dijWc9 m4a932euHSciSyFuhOGPl/iHMOLlyEvT4oSIxAWcB8zJmCxnTvTzntSWyHN3aftBUo8Z 5tDg== X-Gm-Message-State: AOAM533J65wLTCeeoRcWPpfLneWTHJuiiYLPg8+3qjP3SaLb5t20LAcU tDHJLRYhCfY7Up+bleNs7g== X-Google-Smtp-Source: ABdhPJyutzG/CtBSo2AbNwxTQRPhoMC69LSSASIpnyv8Pknp6DCor79KIyNjWfH7xwLJ0tgZgDRPng== X-Received: by 2002:a9d:2087:: with SMTP id x7mr19777191ota.119.1602528484942; Mon, 12 Oct 2020 11:48:04 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id w30sm403234oow.15.2020.10.12.11.48.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 11:48:04 -0700 (PDT) Received: (nullmailer pid 1895055 invoked by uid 1000); Mon, 12 Oct 2020 18:48:03 -0000 Date: Mon, 12 Oct 2020 13:48:03 -0500 From: Rob Herring To: Kurt Kanzenbach Cc: Florian Fainelli , Kurt Kanzenbach , Andrew Lunn , Vivien Didelot , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH net-next 1/2] dt-bindings: net: dsa: b53: Add YAML bindings Message-ID: <20201012184803.GB1886314@bogus> References: <20201010164627.9309-1-kurt@kmk-computers.de> <20201010164627.9309-2-kurt@kmk-computers.de> <3249c764-ec4a-26be-a52d-e9e85f3162ea@gmail.com> <877drxp3i5.fsf@kmk-computers.de> <08c1a0f5-84e1-1c92-2c57-466a28d0346a@gmail.com> <87o8l8f15l.fsf@kurt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87o8l8f15l.fsf@kurt> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Oct 12, 2020 at 07:45:10AM +0200, Kurt Kanzenbach wrote: > On Sun Oct 11 2020, Florian Fainelli wrote: > > On 10/11/2020 1:32 AM, Kurt Kanzenbach wrote: > >> How should we proceed? Adding the missing compatible strings and ports > >> to the DTS files? Or adjusting the include files? > > > > The include is correct as it provides the fallback family string which > > is what the driver will be looking for unless we do not provide a chip > > compatible. The various DTS should be updated to contain both the chip > > compatible and the fallback family (brcm,bcm5301x-srab) string, I will > > update the various DTS and submit these for review later next week. > > OK. It's not just the compatible strings, there are other issues as > well. You can check with `make dtbs_check DT_SCHEMA_FILES=path/to/b53.yaml'. > > > > > Then we could imagine me taking this YAML change through the Broadcom > > ARM SoC pull requests that way no new regressions are introduced. > > > > Sounds good? > > Sounds like a plan. But, Rob or other device tree maintainers should > have a look at the YAML file to spot issues in there first. Looks pretty good to me. Rob