From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45495C433DF for ; Mon, 12 Oct 2020 21:19:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E718D20790 for ; Mon, 12 Oct 2020 21:19:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728769AbgJLVTN (ORCPT ); Mon, 12 Oct 2020 17:19:13 -0400 Received: from mail.baikalelectronics.com ([87.245.175.226]:36672 "EHLO mail.baikalelectronics.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726897AbgJLVTM (ORCPT ); Mon, 12 Oct 2020 17:19:12 -0400 Received: from localhost (unknown [127.0.0.1]) by mail.baikalelectronics.ru (Postfix) with ESMTP id 67B7080307C2; Mon, 12 Oct 2020 21:19:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at baikalelectronics.ru Received: from mail.baikalelectronics.ru ([127.0.0.1]) by localhost (mail.baikalelectronics.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S_-sb4mYbKKE; Tue, 13 Oct 2020 00:19:08 +0300 (MSK) Date: Tue, 13 Oct 2020 00:19:05 +0300 From: Serge Semin To: Greg Kroah-Hartman CC: Serge Semin , Mathias Nyman , Felipe Balbi , Rob Herring , Alexey Malahov , Pavel Parkhomenko , Andy Gross , Bjorn Andersson , Manu Gautam , Roger Quadros , Lad Prabhakar , Yoshihiro Shimoda , Neil Armstrong , Kevin Hilman , , , Subject: Re: [PATCH 02/18] dt-bindings: usb: usb-hcd: Add "wireless" maximum-speed property value Message-ID: <20201012211905.6x4lfj4phxit5zi4@mobilestation> References: <20201010224121.12672-1-Sergey.Semin@baikalelectronics.ru> <20201010224121.12672-3-Sergey.Semin@baikalelectronics.ru> <20201011144236.GA271079@kroah.com> <20201011175333.2v46x6kiugqnvlpk@mobilestation> <20201012154150.GA1565332@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20201012154150.GA1565332@kroah.com> X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Oct 12, 2020 at 05:41:50PM +0200, Greg Kroah-Hartman wrote: > On Sun, Oct 11, 2020 at 08:53:33PM +0300, Serge Semin wrote: > > On Sun, Oct 11, 2020 at 04:42:36PM +0200, Greg Kroah-Hartman wrote: > > > On Sun, Oct 11, 2020 at 01:41:05AM +0300, Serge Semin wrote: > > > > It appears that the "maximum-speed" property can also accept the > > > > "wireless" value. Add it to the enumeration of the possible property > > > > values then. > > > > > > > > Signed-off-by: Serge Semin > > > > --- > > > > Documentation/devicetree/bindings/usb/usb-hcd.yaml | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/usb/usb-hcd.yaml b/Documentation/devicetree/bindings/usb/usb-hcd.yaml > > > > index 815de24127db..e1a82a2b3295 100644 > > > > --- a/Documentation/devicetree/bindings/usb/usb-hcd.yaml > > > > +++ b/Documentation/devicetree/bindings/usb/usb-hcd.yaml > > > > @@ -28,7 +28,7 @@ properties: > > > > isn't passed via DT, USB controllers should default to their maximum HW > > > > capability. > > > > $ref: /schemas/types.yaml#/definitions/string > > > > - enum: ["low-speed", "full-speed", "high-speed", "super-speed", > > > > + enum: ["low-speed", "full-speed", "high-speed", "wireless", "super-speed", > > > > "super-speed-plus"] > > > > > > > > Are you sure? wireless usb has been removed from the kernel, where do > > > you see a user of this? If it's still in there, we need to just drop > > > it. > > > > My decision on suggesting this patch has been based purely on the speed types > > the USB core API supports and what usb_get_maximum_speed() can return. > > USB_SPEED_WIRELESS type is one of the possible return values. As I can see > > aside the rest of the USB speeds the wireless speed is also defined > > in the kernel USB subsystem. Moreover it is used in some kernel drivers. > > (See the USB_SPEED_WIRELESS enumeration constant usage.) > > Are you sure that the wireless speed support has been really removed? > > All of the drivers that implement and support this should have been > removed. Code in the USB core is probably not removed, but patches are > gladly welcome. > > Please do not add new wireless support as it is not going to happen, > because there are no wireless devices in the world. Ok. Thanks for clarification. I'll drop this patch then. -Sergey > > thanks, > > greg k-h