* [PATCH v4 1/6] dt-bindings: update usb-c-connector example
2020-09-20 13:48 [PATCH v4 0/6] Remodel HD3SS3220 device nodes Biju Das
@ 2020-09-20 13:49 ` Biju Das
2020-10-13 12:53 ` Rob Herring
2020-09-20 13:49 ` [PATCH v4 2/6] dt-bindings: usb: convert ti,hd3ss3220 bindings to json-schema Biju Das
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Biju Das @ 2020-09-20 13:49 UTC (permalink / raw)
To: Rob Herring
Cc: Biju Das, Alexandre Belloni, Wesley Cheng, Maxime Ripard,
Lee Jones, Mark Brown, Thierry Reding, Prashant Malani,
devicetree, Geert Uytterhoeven, Chris Paterson, Biju Das,
Prabhakar Mahadev Lad, linux-renesas-soc
Some hardware designs have USB typec connector attached to both
SoC and super speed mux. We need to use separate connector node for
such design.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
* New patch
---
.../bindings/connector/usb-connector.yaml | 30 ++++++++++++++++++-
1 file changed, 29 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
index 9bd52e63c935..0df6cb788b2e 100644
--- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
+++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
@@ -11,7 +11,8 @@ maintainers:
description:
A USB connector node represents a physical USB connector. It should be a child
- of a USB interface controller.
+ of a USB interface controller or a separate node when it is attached to both
+ MUX and USB interface controller.
properties:
compatible:
@@ -221,6 +222,33 @@ examples:
};
};
+ # USB-C connector attached to SoC and USB3 typec port controller(hd3ss3220)
+ # with SS 2:1 MUX. HS lines routed to SoC, SS lines routed to the MUX and
+ # the output of MUX is connected to the SoC.
+ - |
+ connector {
+ compatible = "usb-c-connector";
+ label = "USB-C";
+ data-role = "dual";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port@0 {
+ reg = <0>;
+ hs_ep: endpoint {
+ remote-endpoint = <&usb3_hs_ep>;
+ };
+ };
+ port@1 {
+ reg = <1>;
+ ss_ep: endpoint {
+ remote-endpoint = <&hd3ss3220_in_ep>;
+ };
+ };
+ };
+ };
+
# USB connector with GPIO control lines
- |
#include <dt-bindings/gpio/gpio.h>
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v4 1/6] dt-bindings: update usb-c-connector example
2020-09-20 13:49 ` [PATCH v4 1/6] dt-bindings: update usb-c-connector example Biju Das
@ 2020-10-13 12:53 ` Rob Herring
0 siblings, 0 replies; 11+ messages in thread
From: Rob Herring @ 2020-10-13 12:53 UTC (permalink / raw)
To: Biju Das
Cc: Lee Jones, Biju Das, Thierry Reding, Alexandre Belloni,
Rob Herring, Wesley Cheng, Prashant Malani, Geert Uytterhoeven,
Prabhakar Mahadev Lad, Chris Paterson, Mark Brown,
linux-renesas-soc, devicetree, Maxime Ripard
On Sun, 20 Sep 2020 14:49:00 +0100, Biju Das wrote:
> Some hardware designs have USB typec connector attached to both
> SoC and super speed mux. We need to use separate connector node for
> such design.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> * New patch
> ---
> .../bindings/connector/usb-connector.yaml | 30 ++++++++++++++++++-
> 1 file changed, 29 insertions(+), 1 deletion(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v4 2/6] dt-bindings: usb: convert ti,hd3ss3220 bindings to json-schema
2020-09-20 13:48 [PATCH v4 0/6] Remodel HD3SS3220 device nodes Biju Das
2020-09-20 13:49 ` [PATCH v4 1/6] dt-bindings: update usb-c-connector example Biju Das
@ 2020-09-20 13:49 ` Biju Das
2020-09-20 13:49 ` [PATCH v4 3/6] dt-bindings: usb: renesas,usb3-peri: Document HS and SS data bus Biju Das
` (2 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Biju Das @ 2020-09-20 13:49 UTC (permalink / raw)
To: Rob Herring, Greg Kroah-Hartman
Cc: Lad Prabhakar, Yoshihiro Shimoda, Heikki Krogerus, linux-usb,
devicetree, Geert Uytterhoeven, Chris Paterson, Biju Das,
linux-renesas-soc, Biju Das
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Convert ti,hd3ss3220.txt to YAML. Updated the binding documentation
as graph bindings of this device model Super Speed (SS) data bus to
the Super Speed (SS) capable connector.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
v3->v4: Updated the description as per Rob's suggestion.
v2->v3: Replaced Tabs with spaces in the example section.
v1->v2 : No change
Ref: https://patchwork.kernel.org/patch/11669423/
---
.../devicetree/bindings/usb/ti,hd3ss3220.txt | 38 ---------
.../devicetree/bindings/usb/ti,hd3ss3220.yaml | 82 +++++++++++++++++++
2 files changed, 82 insertions(+), 38 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/usb/ti,hd3ss3220.txt
create mode 100644 Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml
diff --git a/Documentation/devicetree/bindings/usb/ti,hd3ss3220.txt b/Documentation/devicetree/bindings/usb/ti,hd3ss3220.txt
deleted file mode 100644
index 2bd21b22ce95..000000000000
--- a/Documentation/devicetree/bindings/usb/ti,hd3ss3220.txt
+++ /dev/null
@@ -1,38 +0,0 @@
-TI HD3SS3220 TypeC DRP Port Controller.
-
-Required properties:
- - compatible: Must be "ti,hd3ss3220".
- - reg: I2C slave address, must be 0x47 or 0x67 based on ADDR pin.
- - interrupts: An interrupt specifier.
-
-Required sub-node:
- - connector: The "usb-c-connector" attached to the hd3ss3220 chip. The
- bindings of the connector node are specified in:
-
- Documentation/devicetree/bindings/connector/usb-connector.yaml
-
-Example:
-hd3ss3220@47 {
- compatible = "ti,hd3ss3220";
- reg = <0x47>;
- interrupt-parent = <&gpio6>;
- interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
-
- connector {
- compatible = "usb-c-connector";
- label = "USB-C";
- data-role = "dual";
-
- ports {
- #address-cells = <1>;
- #size-cells = <0>;
-
- port@1 {
- reg = <1>;
- hd3ss3220_ep: endpoint {
- remote-endpoint = <&usb3_role_switch>;
- };
- };
- };
- };
-};
diff --git a/Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml b/Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml
new file mode 100644
index 000000000000..5fe9e6211ba2
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml
@@ -0,0 +1,82 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/ti,hd3ss3220.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TI HD3SS3220 TypeC DRP Port Controller
+
+maintainers:
+ - Biju Das <biju.das.jz@bp.renesas.com>
+
+description: |-
+ HD3SS3220 is a USB SuperSpeed (SS) 2:1 mux with DRP port controller. The device provides Channel
+ Configuration (CC) logic and 5V VCONN sourcing for ecosystems implementing USB Type-C. The
+ HD3SS3220 can be configured as a Downstream Facing Port (DFP), Upstream Facing Port (UFP) or a
+ Dual Role Port (DRP) making it ideal for any application.
+
+properties:
+ compatible:
+ const: ti,hd3ss3220
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ ports:
+ description: OF graph bindings (specified in bindings/graph.txt) that model
+ SS data bus to the SS capable connector.
+ type: object
+ properties:
+ port@0:
+ type: object
+ description: Super Speed (SS) MUX inputs connected to SS capable connector.
+ $ref: /connector/usb-connector.yaml#/properties/ports/properties/port@1
+
+ port@1:
+ type: object
+ description: Output of 2:1 MUX connected to Super Speed (SS) data bus.
+
+ required:
+ - port@0
+ - port@1
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+additionalProperties: false
+
+examples:
+ - |
+ i2c0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ hd3ss3220@47 {
+ compatible = "ti,hd3ss3220";
+ reg = <0x47>;
+ interrupt-parent = <&gpio6>;
+ interrupts = <3>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port@0 {
+ reg = <0>;
+ hd3ss3220_in_ep: endpoint {
+ remote-endpoint = <&ss_ep>;
+ };
+ };
+ port@1 {
+ reg = <1>;
+ hd3ss3220_out_ep: endpoint {
+ remote-endpoint = <&usb3_role_switch>;
+ };
+ };
+ };
+ };
+ };
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v4 3/6] dt-bindings: usb: renesas,usb3-peri: Document HS and SS data bus
2020-09-20 13:48 [PATCH v4 0/6] Remodel HD3SS3220 device nodes Biju Das
2020-09-20 13:49 ` [PATCH v4 1/6] dt-bindings: update usb-c-connector example Biju Das
2020-09-20 13:49 ` [PATCH v4 2/6] dt-bindings: usb: convert ti,hd3ss3220 bindings to json-schema Biju Das
@ 2020-09-20 13:49 ` Biju Das
2020-09-20 13:49 ` [PATCH v4 5/6] arm64: dts: renesas: cat874: Move connector node out of hd3ss3220 device Biju Das
2020-09-20 13:49 ` [PATCH v4 6/6] arm64: dts: renesas: beacon-renesom-baseboard: " Biju Das
4 siblings, 0 replies; 11+ messages in thread
From: Biju Das @ 2020-09-20 13:49 UTC (permalink / raw)
To: Rob Herring, Greg Kroah-Hartman, Yoshihiro Shimoda
Cc: Biju Das, Heikki Krogerus, linux-usb, devicetree,
Geert Uytterhoeven, Chris Paterson, Biju Das,
Prabhakar Mahadev Lad, linux-renesas-soc
Document HS and SS data bus for the "usb-role-switch" enabled case.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
v3->v4: Added Rb tags
v2->v3: Replaced Tabs with spaces
Ref:https://patchwork.kernel.org/patch/11708831/
v1->v2: No change
Ref:https://patchwork.kernel.org/patch/11669423/
---
.../bindings/usb/renesas,usb3-peri.yaml | 34 ++++++++++++++++---
1 file changed, 29 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/renesas,usb3-peri.yaml b/Documentation/devicetree/bindings/usb/renesas,usb3-peri.yaml
index e3cdeab1199f..86df8cdd9993 100644
--- a/Documentation/devicetree/bindings/usb/renesas,usb3-peri.yaml
+++ b/Documentation/devicetree/bindings/usb/renesas,usb3-peri.yaml
@@ -52,11 +52,24 @@ properties:
$ref: /schemas/types.yaml#/definitions/phandle
description: phandle of a companion.
- port:
+ ports:
description: |
any connector to the data bus of this controller should be modelled
using the OF graph bindings specified, if the "usb-role-switch"
property is used.
+ type: object
+ properties:
+ port@0:
+ type: object
+ description: High Speed (HS) data bus.
+
+ port@1:
+ type: object
+ description: Super Speed (SS) data bus.
+
+ required:
+ - port@0
+ - port@1
required:
- compatible
@@ -79,9 +92,20 @@ examples:
companion = <&xhci0>;
usb-role-switch;
- port {
- usb3_role_switch: endpoint {
- remote-endpoint = <&hd3ss3220_ep>;
- };
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port@0 {
+ reg = <0>;
+ usb3_hs_ep: endpoint {
+ remote-endpoint = <&hs_ep>;
+ };
+ };
+ port@1 {
+ reg = <1>;
+ usb3_role_switch: endpoint {
+ remote-endpoint = <&hd3ss3220_out_ep>;
+ };
+ };
};
};
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v4 5/6] arm64: dts: renesas: cat874: Move connector node out of hd3ss3220 device
2020-09-20 13:48 [PATCH v4 0/6] Remodel HD3SS3220 device nodes Biju Das
` (2 preceding siblings ...)
2020-09-20 13:49 ` [PATCH v4 3/6] dt-bindings: usb: renesas,usb3-peri: Document HS and SS data bus Biju Das
@ 2020-09-20 13:49 ` Biju Das
2020-10-27 8:55 ` Biju Das
2020-10-29 13:38 ` Geert Uytterhoeven
2020-09-20 13:49 ` [PATCH v4 6/6] arm64: dts: renesas: beacon-renesom-baseboard: " Biju Das
4 siblings, 2 replies; 11+ messages in thread
From: Biju Das @ 2020-09-20 13:49 UTC (permalink / raw)
To: Rob Herring
Cc: Biju Das, Geert Uytterhoeven, Yoshihiro Shimoda, Magnus Damm,
linux-renesas-soc, devicetree, Chris Paterson, Biju Das,
Prabhakar Mahadev Lad
Move connector node out of hd3ss3220 device in order to comply with usb
connector bindings.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
v3->v4: No change
v2->v3: No change
v1->v2: No change
---
.../boot/dts/renesas/r8a774c0-cat874.dts | 67 ++++++++++++++-----
1 file changed, 50 insertions(+), 17 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
index 26aee004a44e..ea87cb5a459c 100644
--- a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
+++ b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
@@ -129,6 +129,29 @@
#clock-cells = <0>;
clock-frequency = <74250000>;
};
+
+ connector {
+ compatible = "usb-c-connector";
+ label = "USB-C";
+ data-role = "dual";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port@0 {
+ reg = <0>;
+ hs_ep: endpoint {
+ remote-endpoint = <&usb3_hs_ep>;
+ };
+ };
+ port@1 {
+ reg = <1>;
+ ss_ep: endpoint {
+ remote-endpoint = <&hd3ss3220_in_ep>;
+ };
+ };
+ };
+ };
};
&audio_clk_a {
@@ -186,20 +209,19 @@
interrupt-parent = <&gpio6>;
interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
- connector {
- compatible = "usb-c-connector";
- label = "USB-C";
- data-role = "dual";
-
- ports {
- #address-cells = <1>;
- #size-cells = <0>;
-
- port@1 {
- reg = <1>;
- hd3ss3220_ep: endpoint {
- remote-endpoint = <&usb3_role_switch>;
- };
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port@0 {
+ reg = <0>;
+ hd3ss3220_in_ep: endpoint {
+ remote-endpoint = <&ss_ep>;
+ };
+ };
+ port@1 {
+ reg = <1>;
+ hd3ss3220_out_ep: endpoint {
+ remote-endpoint = <&usb3_role_switch>;
};
};
};
@@ -405,9 +427,20 @@
status = "okay";
usb-role-switch;
- port {
- usb3_role_switch: endpoint {
- remote-endpoint = <&hd3ss3220_ep>;
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port@0 {
+ reg = <0>;
+ usb3_hs_ep: endpoint {
+ remote-endpoint = <&hs_ep>;
+ };
+ };
+ port@1 {
+ reg = <1>;
+ usb3_role_switch: endpoint {
+ remote-endpoint = <&hd3ss3220_out_ep>;
+ };
};
};
};
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* RE: [PATCH v4 5/6] arm64: dts: renesas: cat874: Move connector node out of hd3ss3220 device
2020-09-20 13:49 ` [PATCH v4 5/6] arm64: dts: renesas: cat874: Move connector node out of hd3ss3220 device Biju Das
@ 2020-10-27 8:55 ` Biju Das
2020-10-29 13:38 ` Geert Uytterhoeven
1 sibling, 0 replies; 11+ messages in thread
From: Biju Das @ 2020-10-27 8:55 UTC (permalink / raw)
To: Rob Herring
Cc: Geert Uytterhoeven, Yoshihiro Shimoda, Magnus Damm,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
Chris Paterson, Biju Das, Prabhakar Mahadev Lad, Adam Ford
Hi Geert,
The dependencies patches hit on 5.10-rc1 [1] [2][3]. This patch cleanly applies on renesas-devel.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.10-rc1&id=588614be61b7cb46f697c3e141b2aef7f6b49347
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.10-rc1&id=a6806e32e7a41c20c6b288009cb6f30929668327
[3] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.10-rc1&id=1c6e8ee63adbaf02a1e5177610fe9b77bec93d8a
Regards,
Biju
> -----Original Message-----
> From: Biju Das <biju.das.jz@bp.renesas.com>
> Sent: 20 September 2020 14:49
> To: Rob Herring <robh+dt@kernel.org>
> Cc: Biju Das <biju.das.jz@bp.renesas.com>; Geert Uytterhoeven
> <geert+renesas@glider.be>; Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com>; Magnus Damm
> <magnus.damm@gmail.com>; linux-renesas-soc@vger.kernel.org;
> devicetree@vger.kernel.org; Chris Paterson
> <Chris.Paterson2@renesas.com>; Biju Das <biju.das@bp.renesas.com>;
> Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Subject: [PATCH v4 5/6] arm64: dts: renesas: cat874: Move connector node
> out of hd3ss3220 device
>
> Move connector node out of hd3ss3220 device in order to comply with usb
> connector bindings.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> v3->v4: No change
> v2->v3: No change
> v1->v2: No change
> ---
> .../boot/dts/renesas/r8a774c0-cat874.dts | 67 ++++++++++++++-----
> 1 file changed, 50 insertions(+), 17 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
> b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
> index 26aee004a44e..ea87cb5a459c 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
> @@ -129,6 +129,29 @@
> #clock-cells = <0>;
> clock-frequency = <74250000>;
> };
> +
> + connector {
> + compatible = "usb-c-connector";
> + label = "USB-C";
> + data-role = "dual";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@0 {
> + reg = <0>;
> + hs_ep: endpoint {
> + remote-endpoint = <&usb3_hs_ep>;
> + };
> + };
> + port@1 {
> + reg = <1>;
> + ss_ep: endpoint {
> + remote-endpoint =
> <&hd3ss3220_in_ep>;
> + };
> + };
> + };
> + };
> };
>
> &audio_clk_a {
> @@ -186,20 +209,19 @@
> interrupt-parent = <&gpio6>;
> interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
>
> - connector {
> - compatible = "usb-c-connector";
> - label = "USB-C";
> - data-role = "dual";
> -
> - ports {
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - port@1 {
> - reg = <1>;
> - hd3ss3220_ep: endpoint {
> - remote-endpoint =
> <&usb3_role_switch>;
> - };
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@0 {
> + reg = <0>;
> + hd3ss3220_in_ep: endpoint {
> + remote-endpoint = <&ss_ep>;
> + };
> + };
> + port@1 {
> + reg = <1>;
> + hd3ss3220_out_ep: endpoint {
> + remote-endpoint =
> <&usb3_role_switch>;
> };
> };
> };
> @@ -405,9 +427,20 @@
> status = "okay";
> usb-role-switch;
>
> - port {
> - usb3_role_switch: endpoint {
> - remote-endpoint = <&hd3ss3220_ep>;
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@0 {
> + reg = <0>;
> + usb3_hs_ep: endpoint {
> + remote-endpoint = <&hs_ep>;
> + };
> + };
> + port@1 {
> + reg = <1>;
> + usb3_role_switch: endpoint {
> + remote-endpoint = <&hd3ss3220_out_ep>;
> + };
> };
> };
> };
> --
> 2.17.1
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v4 5/6] arm64: dts: renesas: cat874: Move connector node out of hd3ss3220 device
2020-09-20 13:49 ` [PATCH v4 5/6] arm64: dts: renesas: cat874: Move connector node out of hd3ss3220 device Biju Das
2020-10-27 8:55 ` Biju Das
@ 2020-10-29 13:38 ` Geert Uytterhoeven
1 sibling, 0 replies; 11+ messages in thread
From: Geert Uytterhoeven @ 2020-10-29 13:38 UTC (permalink / raw)
To: Biju Das
Cc: Rob Herring, Yoshihiro Shimoda, Magnus Damm, Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Chris Paterson, Biju Das, Prabhakar Mahadev Lad
On Sun, Sep 20, 2020 at 3:49 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Move connector node out of hd3ss3220 device in order to comply with usb
> connector bindings.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.11.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v4 6/6] arm64: dts: renesas: beacon-renesom-baseboard: Move connector node out of hd3ss3220 device
2020-09-20 13:48 [PATCH v4 0/6] Remodel HD3SS3220 device nodes Biju Das
` (3 preceding siblings ...)
2020-09-20 13:49 ` [PATCH v4 5/6] arm64: dts: renesas: cat874: Move connector node out of hd3ss3220 device Biju Das
@ 2020-09-20 13:49 ` Biju Das
2020-10-27 8:54 ` Biju Das
2020-10-29 13:40 ` Geert Uytterhoeven
4 siblings, 2 replies; 11+ messages in thread
From: Biju Das @ 2020-09-20 13:49 UTC (permalink / raw)
To: Rob Herring
Cc: Biju Das, Geert Uytterhoeven, Yoshihiro Shimoda, Magnus Damm,
linux-renesas-soc, devicetree, Chris Paterson, Biju Das,
Prabhakar Mahadev Lad
Move connector node out of hd3ss3220 device in order to comply with usb
connector bindings.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
v3->v4: No change
v2->v3: No change
v1->v2: No change
---
.../dts/renesas/beacon-renesom-baseboard.dtsi | 67 ++++++++++++++-----
1 file changed, 50 insertions(+), 17 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi b/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi
index 66c9153b3101..e66b5b36e489 100644
--- a/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi
+++ b/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi
@@ -223,6 +223,29 @@
#clock-cells = <0>;
clock-frequency = <25000000>;
};
+
+ connector {
+ compatible = "usb-c-connector";
+ label = "USB-C";
+ data-role = "dual";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port@0 {
+ reg = <0>;
+ hs_ep: endpoint {
+ remote-endpoint = <&usb3_hs_ep>;
+ };
+ };
+ port@1 {
+ reg = <1>;
+ ss_ep: endpoint {
+ remote-endpoint = <&hd3ss3220_in_ep>;
+ };
+ };
+ };
+ };
};
&audio_clk_a {
@@ -427,20 +450,19 @@
interrupt-parent = <&gpio6>;
interrupts = <4 IRQ_TYPE_LEVEL_LOW>;
- connector {
- compatible = "usb-c-connector";
- label = "USB-C";
- data-role = "dual";
-
- ports {
- #address-cells = <1>;
- #size-cells = <0>;
-
- port@1 {
- reg = <1>;
- hd3ss3220_ep: endpoint {
- remote-endpoint = <&usb3_role_switch>;
- };
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port@0 {
+ reg = <0>;
+ hd3ss3220_in_ep: endpoint {
+ remote-endpoint = <&ss_ep>;
+ };
+ };
+ port@1 {
+ reg = <1>;
+ hd3ss3220_out_ep: endpoint {
+ remote-endpoint = <&usb3_role_switch>;
};
};
};
@@ -714,9 +736,20 @@
status = "okay";
usb-role-switch;
- port {
- usb3_role_switch: endpoint {
- remote-endpoint = <&hd3ss3220_ep>;
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port@0 {
+ reg = <0>;
+ usb3_hs_ep: endpoint {
+ remote-endpoint = <&hs_ep>;
+ };
+ };
+ port@1 {
+ reg = <1>;
+ usb3_role_switch: endpoint {
+ remote-endpoint = <&hd3ss3220_out_ep>;
+ };
};
};
};
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* RE: [PATCH v4 6/6] arm64: dts: renesas: beacon-renesom-baseboard: Move connector node out of hd3ss3220 device
2020-09-20 13:49 ` [PATCH v4 6/6] arm64: dts: renesas: beacon-renesom-baseboard: " Biju Das
@ 2020-10-27 8:54 ` Biju Das
2020-10-29 13:40 ` Geert Uytterhoeven
1 sibling, 0 replies; 11+ messages in thread
From: Biju Das @ 2020-10-27 8:54 UTC (permalink / raw)
To: Rob Herring, Geert Uytterhoeven
Cc: Yoshihiro Shimoda, Magnus Damm, linux-renesas-soc@vger.kernel.org,
devicetree@vger.kernel.org, Chris Paterson, Biju Das,
Prabhakar Mahadev Lad
Hi Geert,
The dependencies patches hit on 5.10-rc1 [1] [2][3]. This patch cleanly applies on renesas-devel.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.10-rc1&id=588614be61b7cb46f697c3e141b2aef7f6b49347
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.10-rc1&id=a6806e32e7a41c20c6b288009cb6f30929668327
[3] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.10-rc1&id=1c6e8ee63adbaf02a1e5177610fe9b77bec93d8a
Regards,
Biju
> Subject: [PATCH v4 6/6] arm64: dts: renesas: beacon-renesom-baseboard:
> Move connector node out of hd3ss3220 device
>
> Move connector node out of hd3ss3220 device in order to comply with usb
> connector bindings.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> v3->v4: No change
> v2->v3: No change
> v1->v2: No change
> ---
> .../dts/renesas/beacon-renesom-baseboard.dtsi | 67 ++++++++++++++-----
> 1 file changed, 50 insertions(+), 17 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi
> b/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi
> index 66c9153b3101..e66b5b36e489 100644
> --- a/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi
> +++ b/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi
> @@ -223,6 +223,29 @@
> #clock-cells = <0>;
> clock-frequency = <25000000>;
> };
> +
> + connector {
> + compatible = "usb-c-connector";
> + label = "USB-C";
> + data-role = "dual";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@0 {
> + reg = <0>;
> + hs_ep: endpoint {
> + remote-endpoint = <&usb3_hs_ep>;
> + };
> + };
> + port@1 {
> + reg = <1>;
> + ss_ep: endpoint {
> + remote-endpoint =
> <&hd3ss3220_in_ep>;
> + };
> + };
> + };
> + };
> };
>
> &audio_clk_a {
> @@ -427,20 +450,19 @@
> interrupt-parent = <&gpio6>;
> interrupts = <4 IRQ_TYPE_LEVEL_LOW>;
>
> - connector {
> - compatible = "usb-c-connector";
> - label = "USB-C";
> - data-role = "dual";
> -
> - ports {
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - port@1 {
> - reg = <1>;
> - hd3ss3220_ep: endpoint {
> - remote-endpoint =
> <&usb3_role_switch>;
> - };
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@0 {
> + reg = <0>;
> + hd3ss3220_in_ep: endpoint {
> + remote-endpoint = <&ss_ep>;
> + };
> + };
> + port@1 {
> + reg = <1>;
> + hd3ss3220_out_ep: endpoint {
> + remote-endpoint =
> <&usb3_role_switch>;
> };
> };
> };
> @@ -714,9 +736,20 @@
> status = "okay";
> usb-role-switch;
>
> - port {
> - usb3_role_switch: endpoint {
> - remote-endpoint = <&hd3ss3220_ep>;
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@0 {
> + reg = <0>;
> + usb3_hs_ep: endpoint {
> + remote-endpoint = <&hs_ep>;
> + };
> + };
> + port@1 {
> + reg = <1>;
> + usb3_role_switch: endpoint {
> + remote-endpoint = <&hd3ss3220_out_ep>;
> + };
> };
> };
> };
> --
> 2.17.1
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v4 6/6] arm64: dts: renesas: beacon-renesom-baseboard: Move connector node out of hd3ss3220 device
2020-09-20 13:49 ` [PATCH v4 6/6] arm64: dts: renesas: beacon-renesom-baseboard: " Biju Das
2020-10-27 8:54 ` Biju Das
@ 2020-10-29 13:40 ` Geert Uytterhoeven
1 sibling, 0 replies; 11+ messages in thread
From: Geert Uytterhoeven @ 2020-10-29 13:40 UTC (permalink / raw)
To: Biju Das
Cc: Rob Herring, Yoshihiro Shimoda, Magnus Damm, Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Chris Paterson, Biju Das, Prabhakar Mahadev Lad
On Sun, Sep 20, 2020 at 3:49 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Move connector node out of hd3ss3220 device in order to comply with usb
> connector bindings.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.11.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 11+ messages in thread