From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9A35C43457 for ; Wed, 14 Oct 2020 10:11:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6BD9E20848 for ; Wed, 14 Oct 2020 10:11:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ragnatech-se.20150623.gappssmtp.com header.i=@ragnatech-se.20150623.gappssmtp.com header.b="nvcLzqFy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729225AbgJNKL4 (ORCPT ); Wed, 14 Oct 2020 06:11:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729022AbgJNKL4 (ORCPT ); Wed, 14 Oct 2020 06:11:56 -0400 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89D58C0613D3 for ; Wed, 14 Oct 2020 03:11:55 -0700 (PDT) Received: by mail-lf1-x142.google.com with SMTP id 184so3058508lfd.6 for ; Wed, 14 Oct 2020 03:11:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech-se.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=D9gEsuKCqY5ac7Bsj84oLcUjfey4ei4xQdjhdzjkOSE=; b=nvcLzqFy+/hxA1Pw1QucXdkoo5krViAR74k1syfntvZjJrKSOzyInK5lkbaIHqJoyR LJeJ4M9TW4P5OQ+EYDyhRbMFooUQhx4toDUOdTGAftO9o2SM1y0f2CwGpxGmmN1agbLJ U2G8kd5llQ0jUV5IyKjbW2KWm2Tmaz0VtT6Qw+6vp619RZSdxhTxxYHjKLyHfk+DJS1q z/1sIh1HUPtbjHZGu44tO6hzbe2R+A0eT0DLN4g8UBTs5y9KJBProQcDiv/ArNUyMlxK kh+QvJRK+SQkzPdLAlhpFl98vhGzSO1xvDPURjPnk+frxgSHClhUTxzU6TJZV1YHn2zN vjVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=D9gEsuKCqY5ac7Bsj84oLcUjfey4ei4xQdjhdzjkOSE=; b=mr2ynJeSAYIxsiCUk/CrF+Cgm/zr8p3dH4qx4+0rlggnh6kTmNEnL/waLImFqdLdaZ 8pNqNjUS1/ZuPzdpTllDxbRdWUXdOTZ0NQ7abo7WthTj4oQoNqnahgWveI4kPphG6Hhp rt0IIDc/yU3rzWQbpbY9LDaUAmRKwY16OqH2JsyLDA61yuLBONXYTcMGV6EF+tMCfv7R s68581q/Y7D88US9afr7OGDIKh4kSqhgkhZCgdFH3HylzZ365hedBqBo060n8bAIiYBQ Tz85cJp4L358/Rmv1h2Vcd5nZBOX2dzl3GSygzcd8mLryGB7yph4LaZEyW3iuGzPnNlh G7xA== X-Gm-Message-State: AOAM533cI/OUPKNErFb8Db5s/+VimmdeKUck67YA4chrAF/4y8iBMnzP YbI0SGm+E/CkChdt60XZKzgEOw== X-Google-Smtp-Source: ABdhPJzyMrzpeDZ4LfCDAueIHnsskeqRxsVCSXw9df6G4ICj30Qq1EywTW97Y/fPEEnApfVlfu1XnA== X-Received: by 2002:a05:6512:1dd:: with SMTP id f29mr1256228lfp.379.1602670313884; Wed, 14 Oct 2020 03:11:53 -0700 (PDT) Received: from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203]) by smtp.gmail.com with ESMTPSA id f9sm956972lfc.164.2020.10.14.03.11.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2020 03:11:52 -0700 (PDT) Date: Wed, 14 Oct 2020 12:11:52 +0200 From: Niklas =?utf-8?Q?S=C3=B6derlund?= To: Jacopo Mondi Cc: linux-renesas-soc@vger.kernel.org, geert+renesas@glider.be, laurent.pinchart@ideasonboard.com, devicetree@vger.kernel.org, robh+dt@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] dt-bindings: media: renesas,vin: Add V3U support Message-ID: <20201014101152.mqmv2klq2mwsjlpf@oden.dyn.berto.se> References: <20201014094443.11070-1-jacopo+renesas@jmondi.org> <20201014094443.11070-6-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201014094443.11070-6-jacopo+renesas@jmondi.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Jacopo, Thanks for your patch. On 2020-10-14 11:44:42 +0200, Jacopo Mondi wrote: > Add compatible string definition for R-Car V3U. > > Signed-off-by: Jacopo Mondi > --- > Documentation/devicetree/bindings/media/renesas,vin.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/media/renesas,vin.yaml b/Documentation/devicetree/bindings/media/renesas,vin.yaml > index ad2fe660364b..7b629a6ea035 100644 > --- a/Documentation/devicetree/bindings/media/renesas,vin.yaml > +++ b/Documentation/devicetree/bindings/media/renesas,vin.yaml > @@ -51,6 +51,7 @@ properties: > - renesas,vin-r8a77980 # R-Car V3H > - renesas,vin-r8a77990 # R-Car E3 > - renesas,vin-r8a77995 # R-Car D3 > + - renesas,vin-r8a779a0 # R-Car V3U Documenting the compat string here might give the wrong impression the IP is supported. Which it's not as the V3U is quiet different then the it's siblings. Whit a new pipeline and small but important changes in in the register set. I'm primarily thinking about that the IFMD register is gone and dealing with that will be quiet significant work in the driver. I'm not yet 100% sure the best idea is to support V3U with this driver, maybe it's finally time to make it more modular, with more distinct support for Gen2, Gen3 and a new module for V3U? > > reg: > maxItems: 1 > -- > 2.28.0 > -- Regards, Niklas Söderlund