From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83019C433E7 for ; Thu, 15 Oct 2020 05:40:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D6A122247 for ; Thu, 15 Oct 2020 05:40:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728146AbgJOFk3 (ORCPT ); Thu, 15 Oct 2020 01:40:29 -0400 Received: from verein.lst.de ([213.95.11.211]:59161 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727397AbgJOFk3 (ORCPT ); Thu, 15 Oct 2020 01:40:29 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 6CD5C68BEB; Thu, 15 Oct 2020 07:40:26 +0200 (CEST) Date: Thu, 15 Oct 2020 07:40:26 +0200 From: Christoph Hellwig To: Nicolas Saenz Julienne Cc: robh+dt@kernel.org, catalin.marinas@arm.com, hch@lst.de, ardb@kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, jeremy.linton@arm.com, iommu@lists.linux-foundation.org, devicetree@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 8/8] mm: Update DMA zones description Message-ID: <20201015054026.GC12218@lst.de> References: <20201014191211.27029-1-nsaenzjulienne@suse.de> <20201014191211.27029-9-nsaenzjulienne@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201014191211.27029-9-nsaenzjulienne@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Oct 14, 2020 at 09:12:10PM +0200, Nicolas Saenz Julienne wrote: > The default behavior for arm64 changed, so reflect that. > > Signed-off-by: Nicolas Saenz Julienne > Acked-by: Catalin Marinas > --- > include/linux/mmzone.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index fb3bf696c05e..4ee2306351b9 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -363,8 +363,9 @@ enum zone_type { > * - arm only uses ZONE_DMA, the size, up to 4G, may vary depending on > * the specific device. > * > - * - arm64 has a fixed 1G ZONE_DMA and ZONE_DMA32 for the rest of the > - * lower 4G. > + * - arm64 uses a single 4GB ZONE_DMA, except on the Raspberry Pi 4, > + * in which ZONE_DMA covers the first GB and ZONE_DMA32 the rest of > + * the lower 4GB. Honestly I think this comment just needs to go away. We can't really list every setup in a comment in common code.