From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Li Jun <jun.li@nxp.com>
Cc: heikki.krogerus@linux.intel.com, robh+dt@kernel.org,
rafael@kernel.org, gregkh@linuxfoundation.org,
hdegoede@redhat.com, lee.jones@linaro.org,
mika.westerberg@linux.intel.com, dmitry.torokhov@gmail.com,
prabhakar.mahadev-lad.rj@bp.renesas.com,
laurent.pinchart+renesas@ideasonboard.com,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-imx@nxp.com, peter.chen@nxp.com
Subject: Re: [PATCH v4 4/4] usb: typec: mux: add typec switch simple driver
Date: Mon, 19 Oct 2020 15:31:14 +0300 [thread overview]
Message-ID: <20201019123114.GO4077@smile.fi.intel.com> (raw)
In-Reply-To: <1603098195-9923-4-git-send-email-jun.li@nxp.com>
On Mon, Oct 19, 2020 at 05:03:15PM +0800, Li Jun wrote:
> This patch adds a simple typec switch driver for cases which only
> needs some simple operations but a dedicated driver is required,
> current driver only supports GPIO toggle to switch the super speed
> active channel according to typec orientation.
...
> Driver for USB muxes controlled by Intel PMC FW. Intel PMC FW can
> control the USB role switch and also the multiplexer/demultiplexer
> switches used with USB Type-C Alternate Modes.
Missed blank line.
> +config TYPEC_SWITCH_SIMPLE
> + tristate "Type-c orientation switch Simple driver"
Type-c -> Type-C
Simple -> simple
> + depends on GPIOLIB
> + help
> + Say Y or M if your system need a simple driver for typec switch
> + control, like use GPIO to select active channel.
Driver name?
...
> +/**
Is it kernel doc?!
> + * switch-simple.c - typec switch simple control.
Remove file name from the file.
> + *
> + * Copyright 2020 NXP
> + * Author: Jun Li <jun.li@nxp.com>
> + *
Redundant blank line.
> + */
...
> +#include <linux/of.h>
> +#include <linux/of_gpio.h>
No evidence of use of these headers, but
mod_devicetable.h along with gpio/consumer.h are missed.
...
> + switch (orientation) {
> + case TYPEC_ORIENTATION_NORMAL:
> + if (typec_sw->sel_gpio)
Optional GPIO does not require these checks. Drop them and learn what "optional" means.
> + gpiod_set_value_cansleep(typec_sw->sel_gpio, 1);
> + break;
> + case TYPEC_ORIENTATION_REVERSE:
> + if (typec_sw->sel_gpio)
> + gpiod_set_value_cansleep(typec_sw->sel_gpio, 0);
> + break;
> + case TYPEC_ORIENTATION_NONE:
> + break;
> + }
...
> + struct typec_switch_simple *typec_sw;
> + struct device *dev = &pdev->dev;
> + struct typec_switch_desc sw_desc;
Be consistent with indentation.
...
> + /* Get the super speed active channel selection GPIO */
> + typec_sw->sel_gpio = devm_gpiod_get_optional(dev, "switch",
> + GPIOD_OUT_LOW);
It can be one line.
> + if (IS_ERR(typec_sw->sel_gpio))
> + return PTR_ERR(typec_sw->sel_gpio);
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-10-19 12:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 9:03 [PATCH v4 1/4] dt-bindings: usb: add documentation for typec switch simple driver Li Jun
2020-10-19 9:03 ` [PATCH v4 2/4] device property: Add fwnode_is_compatible() and device_is_compatible() helpers Li Jun
2020-10-19 12:25 ` Andy Shevchenko
2020-10-20 11:13 ` Jun Li
2020-10-20 12:06 ` Andy Shevchenko
2020-10-21 18:55 ` dmitry.torokhov
2020-10-22 11:03 ` Jun Li
2020-10-19 9:03 ` [PATCH v4 3/4] usb: typec: mux: add "compatible" property for switch match Li Jun
2020-10-20 6:05 ` Peter Chen
2020-10-20 13:02 ` Jun Li
2020-10-21 0:16 ` Peter Chen
2020-10-21 2:43 ` Jun Li
2020-10-19 9:03 ` [PATCH v4 4/4] usb: typec: mux: add typec switch simple driver Li Jun
2020-10-19 12:31 ` Andy Shevchenko [this message]
2020-10-20 12:48 ` Jun Li
2020-10-21 19:55 ` dmitry.torokhov
2020-10-22 11:52 ` Jun Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019123114.GO4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jun.li@nxp.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=lee.jones@linaro.org \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=peter.chen@nxp.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).