From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43379C433E7 for ; Mon, 19 Oct 2020 20:48:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE657223EA for ; Mon, 19 Oct 2020 20:48:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603140505; bh=oi8wGhEsvuY/SFHt/nDa0WBwIEEttQAUKB/mGGvThRA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=NmUXyWDDBh3VxjORP7QWyF/tuumJGDsdmoxYNA7r7lu0w1RuaV3hkK5droydC+t8u 3zhba678r0zOaN3fNT5aggXYtHbYvQwDwhufctBGO/0ScJdrwAH/00k9SGVsgTIV/e tj5WILvuu1o6IIKzxILwfc+FFkiXUmqMONJGWJUQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727082AbgJSUsZ (ORCPT ); Mon, 19 Oct 2020 16:48:25 -0400 Received: from mail-oo1-f67.google.com ([209.85.161.67]:39964 "EHLO mail-oo1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727007AbgJSUsZ (ORCPT ); Mon, 19 Oct 2020 16:48:25 -0400 Received: by mail-oo1-f67.google.com with SMTP id w7so267436oow.7; Mon, 19 Oct 2020 13:48:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fxa3uzHmULeVmNdtF5y01CM2QpDZ2ApdIjLlwOHG4sY=; b=Va2X7wBuu+NBS4fj2JxIadcxzkqIo8mUISO+Oyy57HAI9+lxrvx2mgsdyiwlPrSw8s nwEuNG8gFhb1wRtOBTg/Wv2shnk1OWm4xQ6nDykpYlxE/dfQlJxKxLTfG+OVePf6EOjc JKqXwolpGT7Bj1ZZjhV+r1m021AdaycW7G4sEYtAeZoosnw0a3dCP7Xx2tLOQmDbqnox P3vfxqms48sq0rrbnvcWb+hrGI6KAf8H8RfHzDJ5tpRhrsi+L5984atDO5tzNaU5T1mU mdm+nvKwCj+y/EUmYeTT+SzWauwnOqVytnKs14cms1E0kIOLUP5u3pVbwYfRbN3PEOZd ftzw== X-Gm-Message-State: AOAM532Gvt87raJf2QMrhNAlIUzPE3dX97mjhIWD57jJx/8IVSuaAgF3 lClEwTMhUVJXGAKcnZCsRdcDfVQ6Ew== X-Google-Smtp-Source: ABdhPJwl/iQfkO5suixU4PBWEHxz8p2fHudaNaiDXdTvQ5KBbgmlpr2GV9/HQXy//V7q3Emcotkdtw== X-Received: by 2002:a4a:dc0d:: with SMTP id p13mr1278563oov.2.1603140504163; Mon, 19 Oct 2020 13:48:24 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id j191sm237505oib.52.2020.10.19.13.48.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 13:48:23 -0700 (PDT) Received: (nullmailer pid 3577895 invoked by uid 1000); Mon, 19 Oct 2020 20:48:21 -0000 Date: Mon, 19 Oct 2020 15:48:21 -0500 From: Rob Herring To: Richard Fitzgerald Cc: Mark Brown , nsaenzjulienne@suse.de, patches@opensource.cirrus.com, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Subject: Re: [PATCH 0/7] Add dts for Rpi4 + Cirrus Lochnagar and codecs Message-ID: <20201019204821.GA3569507@bogus> References: <20201014145418.31838-1-rf@opensource.cirrus.com> <20201014185632.GD4580@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Oct 16, 2020 at 02:30:08PM +0100, Richard Fitzgerald wrote: > On 14/10/2020 19:56, Mark Brown wrote: > > On Wed, Oct 14, 2020 at 03:54:11PM +0100, Richard Fitzgerald wrote: > > > This set of patches provides support for using the Cirrus Logic > > > Lochnagar audio development platform plus Cirrus Logic Madera/Arizona > > > codecs with the simple-card machine driver and a Raspberry Pi4. The > > > ultimate aim is to provide the dts file but some updates are needed to > > > the simple-card machine driver. > > > > Why extend simple-card and not the more modern and flexible > > audio-graph-card? > > > > I'm struggling to understand how to use audio-graph-card where there are > multiple alternative codecs. The host I2S endpoint has to point back to > the codec endpoint, like this: > > cpu_i2s_ep_cs47l15: endpoint { > remote-endpoint = <&cs47l15_aif1>; > }; > > But obviously that depends on which codec node was enabled. Listing > multiple endpoints makes the whole port node disabled if any remote > endpoint is in a disabled node. I've tried adding status="disabled" > to endpoints or multiple port definitions with status="disabled" but > I haven't figured out a solution. Multiple endpoints is what you should do. And 'status' goes in the device nodes (not the graph nodes). Rob