From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 011B4C43457 for ; Tue, 20 Oct 2020 10:38:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC21F22283 for ; Tue, 20 Oct 2020 10:38:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392165AbgJTKik (ORCPT ); Tue, 20 Oct 2020 06:38:40 -0400 Received: from mga03.intel.com ([134.134.136.65]:50941 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389722AbgJTKij (ORCPT ); Tue, 20 Oct 2020 06:38:39 -0400 IronPort-SDR: nCPkdDI1t/HogS4BjH7Ojy2jiFGbiZkvYS+dFh2kMK4cx/qNaWIWN4jMAbQwfxY+Yix0b9p0ho LYl+AoQnr6Zw== X-IronPort-AV: E=McAfee;i="6000,8403,9779"; a="167276935" X-IronPort-AV: E=Sophos;i="5.77,396,1596524400"; d="scan'208";a="167276935" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2020 03:38:38 -0700 IronPort-SDR: nMQbRZD4Q4/nC6JYt/ZopTnm264ux7lyhK+5oY2af1Ds8fse9tbcxwsczWMFHkSn0yqCMeLNw8 +ibolxJIUZcA== X-IronPort-AV: E=Sophos;i="5.77,396,1596524400"; d="scan'208";a="347815287" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2020 03:38:35 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 307A12062D; Tue, 20 Oct 2020 13:38:33 +0300 (EEST) Date: Tue, 20 Oct 2020 13:38:33 +0300 From: Sakari Ailus To: Krzysztof Kozlowski Cc: Mauro Carvalho Chehab , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org Subject: Re: [PATCH v5 1/4] dt-bindings: media: imx258: add bindings for IMX258 sensor Message-ID: <20201020103833.GT13341@paasikivi.fi.intel.com> References: <20201019170247.92002-1-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201019170247.92002-1-krzk@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Krzysztof, On Mon, Oct 19, 2020 at 07:02:44PM +0200, Krzysztof Kozlowski wrote: > Add bindings for the IMX258 camera sensor. The bindings, just like the > driver, are quite limited, e.g. do not support regulator supplies. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Rob Herring > > --- > > Changes since v4: > 1. Add clock-lanes, > 2. Add Rob's review, > 3. Add one more example and extend existing one, > 4. Add common clock properties (assigned-*). Using the assigned-* clock properties may be workable for this driver at the moment. But using these properties does not guarantee the external clock frequency intended to be used on the hardware. Using other frequencies *is not* expected to work. That applies to this driver as well. This, instead of the clock-frequency property, effectively removes the ability to set the correct frequency from the driver, at least with current set of the used APIs. I suppose you could add a function to set the assigned clock frequency and keep it, just as clk_set_rate_exclusive does? Cc the common clock framework list + maintainers. -- Regards, Sakari Ailus