[PATCH v2] arm: dts: imx6qdl-udoo: fix rgmii phy-mode for ksz9031 phy

devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH v2] arm: dts: imx6qdl-udoo: fix rgmii phy-mode for ksz9031 phy
@ 2020-10-20 19:33 Sergey Matyukevich
  2020-10-23 21:15 ` Fabio Estevam
  0 siblings, 1 reply; 2+ messages in thread
From: Sergey Matyukevich @ 2020-10-20 19:33 UTC (permalink / raw)
  To: devicetree, linux-arm-kernel
  Cc: Fabio Estevam, Shawn Guo, Sascha Hauer, NXP Linux Team,
	Sergey Matyukevich

Commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the
KSZ9031 PHY") fixed micrel phy driver adding proper support for phy
modes. Adapt imx6q-udoo board phy settings accordingly: explicitly
set required delay configuration using "rgmii-id".

Fixes: bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY")

Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
---

v1 -> v2
- add Fixes tag to commit message


 arch/arm/boot/dts/imx6qdl-udoo.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl-udoo.dtsi b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
index c9e122865312..050642d7c582 100644
--- a/arch/arm/boot/dts/imx6qdl-udoo.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
@@ -98,7 +98,7 @@ sound {
 &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	status = "okay";
 };
 
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] arm: dts: imx6qdl-udoo: fix rgmii phy-mode for ksz9031 phy
  2020-10-20 19:33 [PATCH v2] arm: dts: imx6qdl-udoo: fix rgmii phy-mode for ksz9031 phy Sergey Matyukevich
@ 2020-10-23 21:15 ` Fabio Estevam
  0 siblings, 0 replies; 2+ messages in thread
From: Fabio Estevam @ 2020-10-23 21:15 UTC (permalink / raw)
  To: Sergey Matyukevich
  Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	Shawn Guo, Sascha Hauer, NXP Linux Team

Hi Sergey,

On Tue, Oct 20, 2020 at 4:28 PM Sergey Matyukevich <geomatsi@gmail.com> wrote:
>
> Commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the
> KSZ9031 PHY") fixed micrel phy driver adding proper support for phy
> modes. Adapt imx6q-udoo board phy settings accordingly: explicitly
> set required delay configuration using "rgmii-id".
>
> Fixes: bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY")

This commit exposed the issue, but the Fixes tag should be the commit
that introduced Ethernet support on udoo board.

This is similar to the fix in 0672d22a1924 ("ARM: dts: imx: Fix the
AR803X phy-mode").

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-10-23 21:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-20 19:33 [PATCH v2] arm: dts: imx6qdl-udoo: fix rgmii phy-mode for ksz9031 phy Sergey Matyukevich
2020-10-23 21:15 ` Fabio Estevam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).