* [PATCH 6/6] doc: dt-binding: cdns,usb3: add wakeup-irq
@ 2020-10-22 1:44 Peter Chen
2020-10-30 15:22 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Peter Chen @ 2020-10-22 1:44 UTC (permalink / raw)
To: robh+dt
Cc: devicetree, linux-usb, linux-imx, pawell, rogerq, jun.li,
Peter Chen
To support low power mode for controller, the driver needs wakeup-irq
to reflect the signal changing after controller is stopped, and waking
the controller up accordingly.
Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
Documentation/devicetree/bindings/usb/cdns,usb3.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
index ac20b98e9910..0171e64ef95e 100644
--- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
+++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
@@ -30,12 +30,15 @@ properties:
- description: OTG/DRD controller interrupt
- description: XHCI host controller interrupt
- description: Device controller interrupt
+ - description: interrupt used to wake up core, eg: when usbcmd.rs is
+ cleared by xhci core, this interrupt is optional.
interrupt-names:
items:
- const: host
- const: peripheral
- const: otg
+ - const: wakeup
dr_mode:
enum: [host, otg, peripheral]
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 6/6] doc: dt-binding: cdns,usb3: add wakeup-irq
2020-10-22 1:44 [PATCH 6/6] doc: dt-binding: cdns,usb3: add wakeup-irq Peter Chen
@ 2020-10-30 15:22 ` Rob Herring
2020-10-30 23:10 ` Peter Chen
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2020-10-30 15:22 UTC (permalink / raw)
To: Peter Chen; +Cc: devicetree, linux-usb, linux-imx, pawell, rogerq, jun.li
On Thu, Oct 22, 2020 at 09:44:11AM +0800, Peter Chen wrote:
> To support low power mode for controller, the driver needs wakeup-irq
> to reflect the signal changing after controller is stopped, and waking
> the controller up accordingly.
>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
> Documentation/devicetree/bindings/usb/cdns,usb3.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
> index ac20b98e9910..0171e64ef95e 100644
> --- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
> +++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
> @@ -30,12 +30,15 @@ properties:
> - description: OTG/DRD controller interrupt
> - description: XHCI host controller interrupt
> - description: Device controller interrupt
> + - description: interrupt used to wake up core, eg: when usbcmd.rs is
> + cleared by xhci core, this interrupt is optional.
You need 'minItems: 3' here and below to make this optional. I guess we
don't have an example for this binding or it would fail.
>
> interrupt-names:
> items:
> - const: host
> - const: peripheral
> - const: otg
> + - const: wakeup
>
> dr_mode:
> enum: [host, otg, peripheral]
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH 6/6] doc: dt-binding: cdns,usb3: add wakeup-irq
2020-10-30 15:22 ` Rob Herring
@ 2020-10-30 23:10 ` Peter Chen
0 siblings, 0 replies; 3+ messages in thread
From: Peter Chen @ 2020-10-30 23:10 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
dl-linux-imx, pawell@cadence.com, rogerq@ti.com, Jun Li
> > @@ -30,12 +30,15 @@ properties:
> > - description: OTG/DRD controller interrupt
> > - description: XHCI host controller interrupt
> > - description: Device controller interrupt
> > + - description: interrupt used to wake up core, eg: when usbcmd.rs is
> > + cleared by xhci core, this interrupt is optional.
>
> You need 'minItems: 3' here and below to make this optional. I guess we don't
> have an example for this binding or it would fail.
>
Updated, and sent v2. Yes, we don't need it for example, the probe will not fail even
this property is not there.
Peter
> >
> > interrupt-names:
> > items:
> > - const: host
> > - const: peripheral
> > - const: otg
> > + - const: wakeup
> >
> > dr_mode:
> > enum: [host, otg, peripheral]
> > --
> > 2.17.1
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-30 23:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-22 1:44 [PATCH 6/6] doc: dt-binding: cdns,usb3: add wakeup-irq Peter Chen
2020-10-30 15:22 ` Rob Herring
2020-10-30 23:10 ` Peter Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).