From: "Pali Rohár" <pali@kernel.org>
To: Gregory CLEMENT <gregory.clement@bootlin.com>,
Andrew Lunn <andrew@lunn.ch>, Andre Heider <a.heider@gmail.com>,
Tomasz Maciej Nowak <tmn505@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Reducing number of Espressobin DTS files
Date: Thu, 22 Oct 2020 16:00:07 +0200 [thread overview]
Message-ID: <20201022140007.hppmeyt34lubotbc@pali> (raw)
Hello!
For Espressobin A3720 board there are currently 4 DTS files:
https://git.kernel.org/pub/scm/linux/kernel/git/gclement/mvebu.git/tree/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts?h=for-next
https://git.kernel.org/pub/scm/linux/kernel/git/gclement/mvebu.git/tree/arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dts?h=for-next
https://git.kernel.org/pub/scm/linux/kernel/git/gclement/mvebu.git/tree/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts?h=for-next
https://git.kernel.org/pub/scm/linux/kernel/git/gclement/mvebu.git/tree/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts?h=for-next
There are two board revisions (V5 and V7) and each has variant with and
without eMMC.
V5 and V7 DTS files differs order of ethernet switch ports and presence
of led2 (not in next branch yet).
I would like to ask, do we need two DTS files for eMMC and non-eMMC
variants? Is there any issue if we enable sdhci0 globally for all
Espressobin board and therefore reduce number of DTS variants?
For example, Turris MOX board which is also A3720 based has optional
SDIO module which can be plugged / unplugged, standard variant is sold
without it and in DTS file is this node always enabled:
https://git.kernel.org/pub/scm/linux/kernel/git/gclement/mvebu.git/tree/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts?h=for-next#n178
Could not we enable by default this node also on Espressobin? It is a
problem if node for eMMC is enabled also on board without eMMC? As it
would simplify configuration, compilation and setup of system for
Espressobin boards.
next reply other threads:[~2020-10-22 14:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 14:00 Pali Rohár [this message]
2020-10-22 14:29 ` Reducing number of Espressobin DTS files Andrew Lunn
2020-10-22 14:44 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201022140007.hppmeyt34lubotbc@pali \
--to=pali@kernel.org \
--cc=a.heider@gmail.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tmn505@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox