From: Krzysztof Kozlowski <krzk@kernel.org>
To: Adam Ford <aford173@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, marex@denx.de,
l.stach@pengutronix.de, aford@beaconembedded.com,
Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] arm64: dts: imx8mn: Add power-domain reference in USB controller
Date: Fri, 23 Oct 2020 11:55:18 +0200 [thread overview]
Message-ID: <20201023095518.GF42872@kozik-lap> (raw)
In-Reply-To: <20201022150808.763082-5-aford173@gmail.com>
On Thu, Oct 22, 2020 at 10:08:07AM -0500, Adam Ford wrote:
> The USB OTG controller cannot be used until the power-domain is enabled
> unless it was started in the bootloader.
>
> Adding the power-domain reference to the OTG node allows the OTG
> controller to operate.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
I wonder, why your patches do not have usual Git trailer with summary of
changes (after '---')?
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> index 27733fbe87e9..605e6dbd2c6f 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> @@ -979,6 +979,7 @@ usbotg1: usb@32e40000 {
> assigned-clock-parents = <&clk IMX8MN_SYS_PLL2_500M>;
> fsl,usbphy = <&usbphynop1>;
> fsl,usbmisc = <&usbmisc1 0>;
> + power-domains = <&pgc_otg1>;
I guess you need it also for the usbphynop1 and usbmisc1.
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-10-23 9:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 15:08 [PATCH 0/4] Add i.MX8MN power domain and fix USB Adam Ford
2020-10-22 15:08 ` [PATCH 1/4] dt-bindings: add defines for i.MX8MN power domains Adam Ford
2020-10-23 9:46 ` Krzysztof Kozlowski
2020-10-30 15:36 ` Rob Herring
2020-10-22 15:08 ` [PATCH 2/4] soc: imx: gpcv2: add support " Adam Ford
2020-10-23 9:47 ` Krzysztof Kozlowski
2020-10-22 15:08 ` [PATCH 3/4] arm64: dts: imx8mn: add GPC node and " Adam Ford
2020-10-23 9:52 ` Krzysztof Kozlowski
2020-10-23 10:56 ` Adam Ford
2020-10-22 15:08 ` [PATCH 4/4] arm64: dts: imx8mn: Add power-domain reference in USB controller Adam Ford
2020-10-23 9:55 ` Krzysztof Kozlowski [this message]
2020-10-23 11:03 ` Adam Ford
2020-10-23 11:08 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201023095518.GF42872@kozik-lap \
--to=krzk@kernel.org \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=andrew.smirnov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).